Date
1 - 3 of 3
[PATCH] BaseTools: Fix dependency issue in PcdValueInit
|
Jake Garver
The generated Makefile was missing a dependency. This resulted in a
build-time race condition if the recursive make is multi-threaded and shares job control. Signed-off-by: Jake Garver <jake@...> --- BaseTools/Source/Python/Workspace/DscBuildData.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py index fc1e773417..d55ea1bbe2 100644 --- a/BaseTools/Source/Python/Workspace/DscBuildData.py +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py @@ -97,7 +97,8 @@ PcdMakefileEnd = ''' AppTarget = ''' all: $(APPFILE) -$(APPFILE): $(OBJECTS) +$(APPLICATION): $(OBJECTS) +$(APPFILE): $(APPLICATION) %s ''' -- 2.17.1
|
|
|
|
Jake Garver
Hello maintainers,
Any interest in accepting this and the "BaseTools/Conf: Fix Dynamic-Library-File template" patch? Thanks, Jake
|
|
|
|
Bob Feng
Reviewed-by: Bob Feng <bob.c.feng@...>
toggle quoted messageShow quoted text
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jake Garver via groups.io Sent: Friday, April 8, 2022 12:59 AM To: devel@edk2.groups.io; jbrasen@...; ashishsingha@... Cc: Jake Garver <jake@...> Subject: [edk2-devel] [PATCH] BaseTools: Fix dependency issue in PcdValueInit The generated Makefile was missing a dependency. This resulted in a build-time race condition if the recursive make is multi-threaded and shares job control. Signed-off-by: Jake Garver <jake@...> --- BaseTools/Source/Python/Workspace/DscBuildData.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py index fc1e773417..d55ea1bbe2 100644 --- a/BaseTools/Source/Python/Workspace/DscBuildData.py +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py @@ -97,7 +97,8 @@ PcdMakefileEnd = ''' AppTarget = ''' all: $(APPFILE) -$(APPFILE): $(OBJECTS) +$(APPLICATION): $(OBJECTS) +$(APPFILE): $(APPLICATION) %s ''' -- 2.17.1
|
|
|