devel@edk2.groups.io | [PATCH 3/3] Basetools: turn off gcc12 warning

Home Messages Hashtags Subgroups Calendar

Date Date 1 - 6 of 6

[PATCH 3/3] Basetools: turn off gcc12 warning

Gerd Hoffmann #87986 In function ‘SetDevicePathEndNode’, inlined from ‘FileDevicePath’ at DevicePathUtilities.c:857:5: DevicePathUtilities.c:321:3: error: writing 4 bytes into a region of size 1 [-Werror=stringop-overflow=] 321 \| memcpy (Node, &mUefiDevicePathLibEndDevicePath, sizeof (mUefiDevicePathLibEndDevicePath)); \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from UefiDevicePathLib.h:22, from DevicePathUtilities.c:16: ../Include/Protocol/DevicePath.h: In function ‘FileDevicePath’: ../Include/Protocol/DevicePath.h:51:9: note: destination object ‘Type’ of size 1 51 \| UINT8 Type; ///< 0x01 Hardware Device Path. \| ^~~~ Signed-off-by: Gerd Hoffmann <kraxel@...> --- BaseTools/Source/C/DevicePath/GNUmakefile \| 3 +++ 1 file changed, 3 insertions(+) diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index 7ca08af9662d..b05d2bddfa68 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile @@ -13,6 +13,9 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile +# gcc 12 trips over device path handling +BUILD_CFLAGS += -Wno-error=stringop-overflow + LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) LIBS += -L/lib/e2fsprogs -luuid -- 2.35.1
More All Messages By This Member
Rebecca Cran #88140 This breaks building BaseTools with clang 13.1.6 on macOS: /Applications/Xcode.app/Contents/Developer/usr/bin/make -C DevicePath gcc -c -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . -I ../Include/AArch64/ -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g -O2 -Wno-error=stringop-overflow DevicePath.c -o DevicePath.o error: unknown warning option '-Werror=stringop-overflow'; did you mean '-Werror=shift-overflow'? [-Werror,-Wunknown-warning-option] -- Rebecca Cran toggle quoted message Show quoted text On 3/24/22 6:04 AM, Gerd Hoffmann wrote: In function ‘SetDevicePathEndNode’, inlined from ‘FileDevicePath’ at DevicePathUtilities.c:857:5: DevicePathUtilities.c:321:3: error: writing 4 bytes into a region of size 1 [-Werror=stringop-overflow=] 321 \| memcpy (Node, &mUefiDevicePathLibEndDevicePath, sizeof (mUefiDevicePathLibEndDevicePath)); \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from UefiDevicePathLib.h:22, from DevicePathUtilities.c:16: ../Include/Protocol/DevicePath.h: In function ‘FileDevicePath’: ../Include/Protocol/DevicePath.h:51:9: note: destination object ‘Type’ of size 1 51 \| UINT8 Type; ///< 0x01 Hardware Device Path. \| ^~~~ Signed-off-by: Gerd Hoffmann <kraxel@...> --- BaseTools/Source/C/DevicePath/GNUmakefile \| 3 +++ 1 file changed, 3 insertions(+) diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index 7ca08af9662d..b05d2bddfa68 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile @@ -13,6 +13,9 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile +# gcc 12 trips over device path handling +BUILD_CFLAGS += -Wno-error=stringop-overflow + LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) LIBS += -L/lib/e2fsprogs -luuid
More All Messages By This Member
Bob Feng #88147 Hi Gerd, Could you provide a patch to fix this issue or revert the original commit? Thanks, Bob toggle quoted message Show quoted text -----Original Message----- From: Rebecca Cran <rebecca@...> Sent: Tuesday, March 29, 2022 5:30 AM To: devel@edk2.groups.io; kraxel@... Cc: Pawel Polawski <ppolawsk@...>; Gao, Liming <gaoliming@...>; Chen, Christine <yuwei.chen@...>; Oliver Steffen <osteffen@...>; Feng, Bob C <bob.c.feng@...> Subject: Re: [edk2-devel] [PATCH 3/3] Basetools: turn off gcc12 warning This breaks building BaseTools with clang 13.1.6 on macOS: /Applications/Xcode.app/Contents/Developer/usr/bin/make -C DevicePath gcc -c -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . -I ../Include/AArch64/ -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g -O2 -Wno-error=stringop-overflow DevicePath.c -o DevicePath.o error: unknown warning option '-Werror=stringop-overflow'; did you mean '-Werror=shift-overflow'? [-Werror,-Wunknown-warning-option] -- Rebecca Cran On 3/24/22 6:04 AM, Gerd Hoffmann wrote: In function ‘SetDevicePathEndNode’, inlined from ‘FileDevicePath’ at DevicePathUtilities.c:857:5: DevicePathUtilities.c:321:3: error: writing 4 bytes into a region of size 1 [-Werror=stringop-overflow=] 321 \| memcpy (Node, &mUefiDevicePathLibEndDevicePath, sizeof (mUefiDevicePathLibEndDevicePath)); \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from UefiDevicePathLib.h:22, from DevicePathUtilities.c:16: ../Include/Protocol/DevicePath.h: In function ‘FileDevicePath’: ../Include/Protocol/DevicePath.h:51:9: note: destination object ‘Type’ of size 1 51 \| UINT8 Type; ///< 0x01 Hardware Device Path. \| ^~~~ Signed-off-by: Gerd Hoffmann <kraxel@...> --- BaseTools/Source/C/DevicePath/GNUmakefile \| 3 +++ 1 file changed, 3 insertions(+) diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index 7ca08af9662d..b05d2bddfa68 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile @@ -13,6 +13,9 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile +# gcc 12 trips over device path handling BUILD_CFLAGS += +-Wno-error=stringop-overflow + LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) LIBS += -L/lib/e2fsprogs -luuid
More All Messages By This Member
grant@... #88203 While I can't test this myself, the following does appear to result in a successful build using the same clang version: diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index b05d2bddfa..81aa35aa31 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile @@ -14,7 +14,9 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile # gcc 12 trips over device path handling -BUILD_CFLAGS += -Wno-error=stringop-overflow +ifeq($(CC), gcc) + BUILD_CFLAGS += -Wno-error=stringop-overflow +endif LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN)
More All Messages By This Member
Andrew Fish #88206 On Mar 29, 2022, at 11:14 AM, grant@... wrote: While I can't test this myself, the following does appear to result in a successful build using the same clang version: diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index b05d2bddfa..81aa35aa31 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile @@ -14,7 +14,9 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile # gcc 12 trips over device path handling -BUILD_CFLAGS += -Wno-error=stringop-overflow +ifeq($(CC), gcc) + BUILD_CFLAGS += -Wno-error=stringop-overflow +endif Gerd, I’m not sure if this was caused by my email client but your fix did not work for me. GNUmakefile:17: * missing separator. Stop. I had to add a space after `ifeq` to get it to work. diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index b05d2bddfa68..ebab1d3e2617 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile @@ -14,7 +14,9 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile # gcc 12 trips over device path handling -BUILD_CFLAGS += -Wno-error=stringop-overflow +ifeq ($(CC), gcc) + BUILD_CFLAGS += -Wno-error=stringop-overflow +endif LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) I had been working around like this previously (I’m not sure about the portability of -Wno-unknown-warning-option): diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index b05d2bddfa68..d08588a81f80 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile** @@ -14,7 +14,7 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile # gcc 12 trips over device path handling -BUILD_CFLAGS += -Wno-error=stringop-overflow +BUILD_CFLAGS += -Wno-error=stringop-overflow -Wno-unknown-warning-option LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) Thanks, Andrew Fish LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN)
More All Messages By This Member
Andrew Fish #88207 On Mar 29, 2022, at 2:38 PM, Andrew Fish via groups.io <afish@...> wrote: On Mar 29, 2022, at 11:14 AM, grant@... wrote: While I can't test this myself, the following does appear to result in a successful build using the same clang version: diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index b05d2bddfa..81aa35aa31 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile @@ -14,7 +14,9 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile # gcc 12 trips over device path handling -BUILD_CFLAGS += -Wno-error=stringop-overflow +ifeq($(CC), gcc) + BUILD_CFLAGS += -Wno-error=stringop-overflow +endif Gerd, I’m not sure if this was caused by my email client but your fix did not work for me. GNUmakefile:17: * missing separator. Stop. Sorry I forgot to mention I was using an Xcode clang on macOS. Thanks, Andrew Fish I had to add a space after `ifeq` to get it to work. diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index b05d2bddfa68..ebab1d3e2617 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile @@ -14,7 +14,9 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile # gcc 12 trips over device path handling -BUILD_CFLAGS += -Wno-error=stringop-overflow +ifeq ($(CC), gcc) + BUILD_CFLAGS += -Wno-error=stringop-overflow +endif LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) I had been working around like this previously (I’m not sure about the portability of -Wno-unknown-warning-option): diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile b/BaseTools/Source/C/DevicePath/GNUmakefile index b05d2bddfa68..d08588a81f80 100644 --- a/BaseTools/Source/C/DevicePath/GNUmakefile +++ b/BaseTools/Source/C/DevicePath/GNUmakefile** @@ -14,7 +14,7 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o DevicePathFromText.o DevicePathUtili include $(MAKEROOT)/Makefiles/app.makefile # gcc 12 trips over device path handling -BUILD_CFLAGS += -Wno-error=stringop-overflow +BUILD_CFLAGS += -Wno-error=stringop-overflow -Wno-unknown-warning-option LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) Thanks, Andrew Fish LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN)
More All Messages By This Member

1 - 6 of 6

1

Previous Topic Next Topic

Home Hashtags Subgroups Calendar About Features Pricing Updates Terms Help Twitter