Date
1 - 4 of 4
[edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path
|
Abdul Lateef Attar
(Resending patch with [edk2-platforms] prefix with correct emailid).
GCC compiler puts the DevicePath PCDs to the read-only section. During boot if try to process the device path after PtrGetPtr it throws a page fault exception. Hence making a local copy using DuplicateDevicePath() to avoid the page fault exception. REF : https://github.com/abdattar/edk2-platforms/tree/BoardModulePkg Cc: Eric Dong <eric.dong@...> Cc: Liming Gao <gaoliming@...> Abdul Lateef Attar (1): BoardModulePkg: Copy device path before processing Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) -- 2.25.1
|
|
|
|
Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@...>
[Public]
toggle quoted messageShow quoted text
Hi, Could you please review the patch? Thanks AbduL
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abdul Lateef Attar via groups.io Sent: 15 March 2022 10:16 To: devel@edk2.groups.io Cc: Eric Dong <eric.dong@...>; Liming Gao <gaoliming@...> Subject: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path [CAUTION: External Email] (Resending patch with [edk2-platforms] prefix with correct emailid). GCC compiler puts the DevicePath PCDs to the read-only section. During boot if try to process the device path after PtrGetPtr it throws a page fault exception. Hence making a local copy using DuplicateDevicePath() to avoid the page fault exception. REF : https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fabdattar%2Fedk2-platforms%2Ftree%2FBoardModulePkg&;data=04%7C01%7CAbdulLateef.Attar%40amd.com%7Cdd04fc2187754979081008da063ebd5d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637829164332474465%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=MX%2FlzKO2jVyPHaaURb7b8kMyNWFAlMPZ%2B0gK%2Ffrh5xo%3D&reserved=0 Cc: Eric Dong <eric.dong@...> Cc: Liming Gao <gaoliming@...> Abdul Lateef Attar (1): BoardModulePkg: Copy device path before processing Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) -- 2.25.1
|
|
|
|
Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@...>
[Public]
toggle quoted messageShow quoted text
Hi, Please review the patch. Thanks AbduL
-----Original Message-----
From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@...> Sent: 05 April 2022 11:25 To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@...>; Eric Dong <eric.dong@...>; Liming Gao <gaoliming@...> Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path [Public] Hi, Could you please review the patch? Thanks AbduL -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abdul Lateef Attar via groups.io Sent: 15 March 2022 10:16 To: devel@edk2.groups.io Cc: Eric Dong <eric.dong@...>; Liming Gao <gaoliming@...> Subject: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path [CAUTION: External Email] (Resending patch with [edk2-platforms] prefix with correct emailid). GCC compiler puts the DevicePath PCDs to the read-only section. During boot if try to process the device path after PtrGetPtr it throws a page fault exception. Hence making a local copy using DuplicateDevicePath() to avoid the page fault exception. REF : https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fabdattar%2Fedk2-platforms%2Ftree%2FBoardModulePkg&;data=04%7C01%7CAbdulLateef.Attar%40amd.com%7Cdd04fc2187754979081008da063ebd5d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637829164332474465%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=MX%2FlzKO2jVyPHaaURb7b8kMyNWFAlMPZ%2B0gK%2Ffrh5xo%3D&reserved=0 Cc: Eric Dong <eric.dong@...> Cc: Liming Gao <gaoliming@...> Abdul Lateef Attar (1): BoardModulePkg: Copy device path before processing Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) -- 2.25.1
|
|
|
|
Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@...>
[Public]
toggle quoted messageShow quoted text
Maintainers, Reviewers, please review the patch. Thanks AbduL
-----Original Message-----
From: Attar, AbdulLateef (Abdul Lateef) Sent: 25 April 2022 12:45 To: devel@edk2.groups.io; Eric Dong <eric.dong@...>; Liming Gao <gaoliming@...> Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path Hi, Please review the patch. Thanks AbduL -----Original Message----- From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@...> Sent: 05 April 2022 11:25 To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@...>; Eric Dong <eric.dong@...>; Liming Gao <gaoliming@...> Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path [Public] Hi, Could you please review the patch? Thanks AbduL -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abdul Lateef Attar via groups.io Sent: 15 March 2022 10:16 To: devel@edk2.groups.io Cc: Eric Dong <eric.dong@...>; Liming Gao <gaoliming@...> Subject: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path [CAUTION: External Email] (Resending patch with [edk2-platforms] prefix with correct emailid). GCC compiler puts the DevicePath PCDs to the read-only section. During boot if try to process the device path after PtrGetPtr it throws a page fault exception. Hence making a local copy using DuplicateDevicePath() to avoid the page fault exception. REF : https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fabdattar%2Fedk2-platforms%2Ftree%2FBoardModulePkg&;data=04%7C01%7CAbdulLateef.Attar%40amd.com%7Cdd04fc2187754979081008da063ebd5d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637829164332474465%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=MX%2FlzKO2jVyPHaaURb7b8kMyNWFAlMPZ%2B0gK%2Ffrh5xo%3D&reserved=0 Cc: Eric Dong <eric.dong@...> Cc: Liming Gao <gaoliming@...> Abdul Lateef Attar (1): BoardModulePkg: Copy device path before processing Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) -- 2.25.1
|
|
|