1. Topics
  2. Change from "BaseTools/LzmaCompress: Fix possible uninitialized variable" patch was reverted

Change from "BaseTools/LzmaCompress: Fix possible uninitialized variable" patch was reverted

Denis Nikitin <denik@...>
 

Hi Hao,

While updating edk2 in Chrome OS we noticed that the change in your
patch https://edk2.groups.io/g/devel/message/19270 was reverted in
commit:
5ec5a236d1 BaseTools Lzma: Update LZMA SDK version to 18.05.

If you think the fix is critical I think it should be merged in
https://www.7-zip.org/sdk.html.

Thanks,
Denis

Wu, Hao A
 

Hello Denis,

As far as I can recall, the fix you mentioned is a change that to please the static analysis tool.
My opinion is that it not a critical fix.

Best Regards,
Hao Wu

-----Original Message-----
From: Denis Nikitin <denik@...>
Sent: Thursday, January 6, 2022 3:19 AM
To: Wu, Hao A <hao.a.wu@...>
Cc: liming.gao@...; yonghong.zhu@...; devel@edk2.groups.io;
Ramasubramanian, Karthik <kramasub@...>
Subject: Change from "BaseTools/LzmaCompress: Fix possible uninitialized
variable" patch was reverted

Hi Hao,

While updating edk2 in Chrome OS we noticed that the change in your patch
https://edk2.groups.io/g/devel/message/19270 was reverted in
commit:
5ec5a236d1 BaseTools Lzma: Update LZMA SDK version to 18.05.

If you think the fix is critical I think it should be merged in https://www.7-
zip.org/sdk.html.

Thanks,
Denis
Denis Nikitin <denik@...>
 

Thanks for confirmation. I agree that the warning doesn't look severe.

- Denis

On Wed, Jan 5, 2022 at 4:46 PM Wu, Hao A <hao.a.wu@...> wrote:

Hello Denis,

As far as I can recall, the fix you mentioned is a change that to please the static analysis tool.
My opinion is that it not a critical fix.

Best Regards,
Hao Wu

-----Original Message-----
From: Denis Nikitin <denik@...>
Sent: Thursday, January 6, 2022 3:19 AM
To: Wu, Hao A <hao.a.wu@...>
Cc: liming.gao@...; yonghong.zhu@...; devel@edk2.groups.io;
Ramasubramanian, Karthik <kramasub@...>
Subject: Change from "BaseTools/LzmaCompress: Fix possible uninitialized
variable" patch was reverted

Hi Hao,

While updating edk2 in Chrome OS we noticed that the change in your patch
https://edk2.groups.io/g/devel/message/19270 was reverted in
commit:
5ec5a236d1 BaseTools Lzma: Update LZMA SDK version to 18.05.

If you think the fix is critical I think it should be merged in https://www.7-
zip.org/sdk.html.

Thanks,
Denis
1 - 3 of 3