Signed-off-by: JackX Lin <JackX.Lin@...> Cc: Chasel Chiu <chasel.chiu@...> Cc: Dong Eric <eric.dong@...> Cc: Jiewen Yao <jiewen.yao@...> Cc: Ray Ni <ray.ni@...> Cc: Rangasai V Chaganty <rangasai.v.chaganty@...> Cc: Donald Kuo <Donald.Kuo@...> Cc: Chandana C Kumar <chandana.c.kumar@...> Cc: JackX Lin <JackX.Lin@...> --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 785cf4c2f9..05fc7799fb 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -169,7 +169,7 @@ SortCpuLocalApicInTable ( UINT32 Index; UINT32 CurrProcessor; UINT32 BspApicId; - EFI_CPU_ID_ORDER_MAP *TempVal; + EFI_CPU_ID_ORDER_MAP TempVal; EFI_CPU_ID_ORDER_MAP *CpuIdMapPtr; UINT32 CoreThreadMask; EFI_CPU_ID_ORDER_MAP *TempCpuApicIdOrderTable; @@ -183,7 +183,6 @@ SortCpuLocalApicInTable ( } TempCpuApicIdOrderTable = AllocateZeroPool (mNumberOfCpus * sizeof (EFI_CPU_ID_ORDER_MAP)); - TempVal = AllocateZeroPool (sizeof (EFI_CPU_ID_ORDER_MAP)); CoreThreadMask = (UINT32) ((1 << mNumOfBitShift) - 1); for (CurrProcessor = 0, Index = 0; CurrProcessor < mNumberOfCpus; CurrProcessor++, Index++) { -- 2.32.0.windows.2
|
|
Reviewed-by: Ray Ni <ray.ni@...>
toggle quoted message
Show quoted text
-----Original Message----- From: Lin, JackX <jackx.lin@...> Sent: Tuesday, December 21, 2021 2:48 PM To: devel@edk2.groups.io Cc: Lin, JackX <jackx.lin@...>; Lin, JackX <jackx.lin@...>; Chiu, Chasel <chasel.chiu@...>; Dong, Eric <eric.dong@...>; Yao, Jiewen <jiewen.yao@...>; Ni, Ray <ray.ni@...>; Chaganty, Rangasai V <rangasai.v.chaganty@...>; Kuo, Donald <donald.kuo@...>; Kumar, Chandana C <chandana.c.kumar@...> Subject: [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.
Signed-off-by: JackX Lin <JackX.Lin@...> Cc: Chasel Chiu <chasel.chiu@...> Cc: Dong Eric <eric.dong@...> Cc: Jiewen Yao <jiewen.yao@...> Cc: Ray Ni <ray.ni@...> Cc: Rangasai V Chaganty <rangasai.v.chaganty@...> Cc: Donald Kuo <Donald.Kuo@...> Cc: Chandana C Kumar <chandana.c.kumar@...> Cc: JackX Lin <JackX.Lin@...> --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 785cf4c2f9..05fc7799fb 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -169,7 +169,7 @@ SortCpuLocalApicInTable ( UINT32 Index; UINT32 CurrProcessor; UINT32 BspApicId; - EFI_CPU_ID_ORDER_MAP *TempVal; + EFI_CPU_ID_ORDER_MAP TempVal; EFI_CPU_ID_ORDER_MAP *CpuIdMapPtr; UINT32 CoreThreadMask; EFI_CPU_ID_ORDER_MAP *TempCpuApicIdOrderTable; @@ -183,7 +183,6 @@ SortCpuLocalApicInTable ( }
TempCpuApicIdOrderTable = AllocateZeroPool (mNumberOfCpus * sizeof (EFI_CPU_ID_ORDER_MAP)); - TempVal = AllocateZeroPool (sizeof (EFI_CPU_ID_ORDER_MAP)); CoreThreadMask = (UINT32) ((1 << mNumOfBitShift) - 1);
for (CurrProcessor = 0, Index = 0; CurrProcessor < mNumberOfCpus; CurrProcessor++, Index++) { -- 2.32.0.windows.2
|
|
Reviewed-by: Chandana C Kumar <chandana.c.kumar@...>
toggle quoted message
Show quoted text
-----Original Message----- From: Lin, JackX <jackx.lin@...> Sent: Tuesday, December 21, 2021 12:18 PM To: devel@edk2.groups.io Cc: Lin, JackX <jackx.lin@...>; Lin, JackX <jackx.lin@...>; Chiu, Chasel <chasel.chiu@...>; Dong, Eric <eric.dong@...>; Yao, Jiewen <jiewen.yao@...>; Ni, Ray <ray.ni@...>; Chaganty, Rangasai V <rangasai.v.chaganty@...>; Kuo, Donald <donald.kuo@...>; Kumar, Chandana C <chandana.c.kumar@...> Subject: [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.
Signed-off-by: JackX Lin <JackX.Lin@...> Cc: Chasel Chiu <chasel.chiu@...> Cc: Dong Eric <eric.dong@...> Cc: Jiewen Yao <jiewen.yao@...> Cc: Ray Ni <ray.ni@...> Cc: Rangasai V Chaganty <rangasai.v.chaganty@...> Cc: Donald Kuo <Donald.Kuo@...> Cc: Chandana C Kumar <chandana.c.kumar@...> Cc: JackX Lin <JackX.Lin@...> --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 785cf4c2f9..05fc7799fb 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -169,7 +169,7 @@ SortCpuLocalApicInTable ( UINT32 Index; UINT32 CurrProcessor; UINT32 BspApicId; - EFI_CPU_ID_ORDER_MAP *TempVal; + EFI_CPU_ID_ORDER_MAP TempVal; EFI_CPU_ID_ORDER_MAP *CpuIdMapPtr; UINT32 CoreThreadMask; EFI_CPU_ID_ORDER_MAP *TempCpuApicIdOrderTable; @@ -183,7 +183,6 @@ SortCpuLocalApicInTable ( }
TempCpuApicIdOrderTable = AllocateZeroPool (mNumberOfCpus * sizeof (EFI_CPU_ID_ORDER_MAP)); - TempVal = AllocateZeroPool (sizeof (EFI_CPU_ID_ORDER_MAP)); CoreThreadMask = (UINT32) ((1 << mNumOfBitShift) - 1);
for (CurrProcessor = 0, Index = 0; CurrProcessor < mNumberOfCpus; CurrProcessor++, Index++) { -- 2.32.0.windows.2
|
|
Reviewed-by: Donald Kuo <Donald.Kuo@...>
toggle quoted message
Show quoted text
-----Original Message----- From: Kumar, Chandana C <chandana.c.kumar@...> Sent: Wednesday, December 22, 2021 12:33 AM To: Lin, JackX <jackx.lin@...>; devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@...>; Dong, Eric <eric.dong@...>; Yao, Jiewen <jiewen.yao@...>; Ni, Ray <ray.ni@...>; Chaganty, Rangasai V <rangasai.v.chaganty@...>; Kuo, Donald <donald.kuo@...> Subject: RE: [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space. Reviewed-by: Chandana C Kumar <chandana.c.kumar@...> -----Original Message----- From: Lin, JackX <jackx.lin@...> Sent: Tuesday, December 21, 2021 12:18 PM To: devel@edk2.groups.io Cc: Lin, JackX <jackx.lin@...>; Lin, JackX <jackx.lin@...>; Chiu, Chasel <chasel.chiu@...>; Dong, Eric <eric.dong@...>; Yao, Jiewen <jiewen.yao@...>; Ni, Ray <ray.ni@...>; Chaganty, Rangasai V <rangasai.v.chaganty@...>; Kuo, Donald <donald.kuo@...>; Kumar, Chandana C <chandana.c.kumar@...> Subject: [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.
Signed-off-by: JackX Lin <JackX.Lin@...> Cc: Chasel Chiu <chasel.chiu@...> Cc: Dong Eric <eric.dong@...> Cc: Jiewen Yao <jiewen.yao@...> Cc: Ray Ni <ray.ni@...> Cc: Rangasai V Chaganty <rangasai.v.chaganty@...> Cc: Donald Kuo <Donald.Kuo@...> Cc: Chandana C Kumar <chandana.c.kumar@...> Cc: JackX Lin <JackX.Lin@...> --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 785cf4c2f9..05fc7799fb 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -169,7 +169,7 @@ SortCpuLocalApicInTable ( UINT32 Index; UINT32 CurrProcessor; UINT32 BspApicId; - EFI_CPU_ID_ORDER_MAP *TempVal; + EFI_CPU_ID_ORDER_MAP TempVal; EFI_CPU_ID_ORDER_MAP *CpuIdMapPtr; UINT32 CoreThreadMask; EFI_CPU_ID_ORDER_MAP *TempCpuApicIdOrderTable; @@ -183,7 +183,6 @@ SortCpuLocalApicInTable ( }
TempCpuApicIdOrderTable = AllocateZeroPool (mNumberOfCpus * sizeof (EFI_CPU_ID_ORDER_MAP)); - TempVal = AllocateZeroPool (sizeof (EFI_CPU_ID_ORDER_MAP)); CoreThreadMask = (UINT32) ((1 << mNumOfBitShift) - 1);
for (CurrProcessor = 0, Index = 0; CurrProcessor < mNumberOfCpus; CurrProcessor++, Index++) { -- 2.32.0.windows.2
|
|