devel@edk2.groups.io | [PATCH v2 0/6] MM communicate functionality in variable policy

Kun Qin

#85116

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751

This patch series is a follow up of previous submission:
https://edk2.groups.io/g/devel/message/84140

v2 patches mainly focus on feedback for commits submitted in v1 patches:
a. Splitted the original ArmPkg patch into 4 separate patches;
b. Updated patches according to Uncrustify scanning results;

Patch v2 branch: https://github.com/kuqin12/edk2/tree/mm_communicate_check_v2

Cc: Jian J Wang <jian.j.wang@...>
Cc: Liming Gao <gaoliming@...>
Cc: Hao A Wu <hao.a.wu@...>
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Zhiguang Liu <zhiguang.liu@...>
Cc: Leif Lindholm <leif@...>
Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Bret Barkelew <Bret.Barkelew@...>
Cc: Michael Kubacki <michael.kubacki@...>

Kun Qin (6):
  MdeModulePkg: VariableSmmRuntimeDxe: Fix Variable Policy Message
    Length
  MdePkg: MmCommunication2: Update MM communicate2 function description
  ArmPkg: MmCommunicationDxe: MM communicate function argument
    attributes
  ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**`
    checks
  ArmPkg: MmCommunicationDxe: Update MM communicate `CommSize` check
  ArmPkg: MmCommunicationDxe: Update MM communicate `MessageLength`
    check

 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c               | 46 ++++++++++++--------
 MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c | 10 ++---
 MdePkg/Include/Protocol/MmCommunication2.h                        | 13 +++---
 3 files changed, 41 insertions(+), 28 deletions(-)

-- 
2.32.0.windows.1

Kun Qin

#85263

Hi MdePkg, MdeModulePkg and ArmPkg maintainers,

Happy new year!

It has been a while since this v2 patch series has been sent out for review. Could you please take a look and provide feedback? Any input is appreciated.

Regards,
Kun

Show quoted text

On 12/20/2021 17:33, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751
This patch series is a follow up of previous submission:
https://edk2.groups.io/g/devel/message/84140
v2 patches mainly focus on feedback for commits submitted in v1 patches:
a. Splitted the original ArmPkg patch into 4 separate patches;
b. Updated patches according to Uncrustify scanning results;
Patch v2 branch: https://github.com/kuqin12/edk2/tree/mm_communicate_check_v2
Cc: Jian J Wang <jian.j.wang@...>
Cc: Liming Gao <gaoliming@...>
Cc: Hao A Wu <hao.a.wu@...>
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Zhiguang Liu <zhiguang.liu@...>
Cc: Leif Lindholm <leif@...>
Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Bret Barkelew <Bret.Barkelew@...>
Cc: Michael Kubacki <michael.kubacki@...>
Kun Qin (6):
   MdeModulePkg: VariableSmmRuntimeDxe: Fix Variable Policy Message
     Length
   MdePkg: MmCommunication2: Update MM communicate2 function description
   ArmPkg: MmCommunicationDxe: MM communicate function argument
     attributes
   ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**`
     checks
   ArmPkg: MmCommunicationDxe: Update MM communicate `CommSize` check
   ArmPkg: MmCommunicationDxe: Update MM communicate `MessageLength`
     check
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c               | 46 ++++++++++++--------
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c | 10 ++---
  MdePkg/Include/Protocol/MmCommunication2.h                        | 13 +++---
  3 files changed, 41 insertions(+), 28 deletions(-)

Kun Qin

#85495

Hi MdeModulePkg and ArmPkg maintainers,

It has been another week since this v2 patch series has been sent out for review. Could you please take a look and provide feedback? Any input is appreciated.

Regards,
Kun

Kun Qin

#85784

Hi ArmPkg maintainers,

It has been almost a month since this v2 patch series has been sent out for review. Could you please take a look and provide feedback? Thanks in advance.

Regards,
Kun

Rebecca Cran

#85786

[+Leif, Ard]

Kun,

There's often so much mailing list traffic that you need to CC the maintainers for them to see your emails.

--

Rebecca Cran

Show quoted text

On 1/18/22 11:40, Kun Qin wrote:

Hi ArmPkg maintainers,

It has been almost a month since this v2 patch series has been sent out for review. Could you please take a look and provide feedback? Thanks in advance.

Regards,
Kun

Kun Qin

#85787

I thought the reply on website will retain the original CC list. But I was wrong about that.

Thanks for the reminder, Rebecca.

Regards,
Kun

Show quoted text

On 01/18/2022 14:04, Rebecca Cran wrote:
[+Leif, Ard]
Kun,
There's often so much mailing list traffic that you need to CC the maintainers for them to see your emails.
-- 
Rebecca Cran
On 1/18/22 11:40, Kun Qin wrote:
Hi ArmPkg maintainers,

It has been almost a month since this v2 patch series has been sent out for review. Could you please take a look and provide feedback? Thanks in advance.

Regards,
Kun

Sami Mujawar

#85808

Hi Kun,

I will review this patch series shortly.

Regards,

Sami Mujawar

﻿On 18/01/2022, 22:07, "devel@edk2.groups.io on behalf of Kun Qin via groups.io" <devel@edk2.groups.io on behalf of kuqin12@...> wrote:

    I thought the reply on website will retain the original CC list. But I 
    was wrong about that.

    Thanks for the reminder, Rebecca.

    Regards,
    Kun

Show quoted text

On 01/18/2022 14:04, Rebecca Cran wrote:
    > [+Leif, Ard]
    > 
    > 
    > Kun,
    > 
    > 
    > There's often so much mailing list traffic that you need to CC the 
    > maintainers for them to see your emails.
    > 
    > 
    > -- 
    > 
    > Rebecca Cran
    > 
    > 
    > On 1/18/22 11:40, Kun Qin wrote:
    >> Hi ArmPkg maintainers,
    >>
    >> It has been almost a month since this v2 patch series has been sent 
    >> out for review. Could you please take a look and provide feedback? 
    >> Thanks in advance.
    >>
    >> Regards,
    >> Kun
    >>

Sami Mujawar

#85810

Hi Kun,

Thank you for this patch series.

These changes look good to me. For this series

Reviewed-by: Sami Mujawar <sami.mujawar@...>

Regards,

Sami Mujawar

Show quoted text

On 21/12/2021 01:33 AM, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751

This patch series is a follow up of previous submission:
https://edk2.groups.io/g/devel/message/84140

v2 patches mainly focus on feedback for commits submitted in v1 patches:
a. Splitted the original ArmPkg patch into 4 separate patches;
b. Updated patches according to Uncrustify scanning results;

Patch v2 branch: https://github.com/kuqin12/edk2/tree/mm_communicate_check_v2

Cc: Jian J Wang <jian.j.wang@...>
Cc: Liming Gao <gaoliming@...>
Cc: Hao A Wu <hao.a.wu@...>
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Zhiguang Liu <zhiguang.liu@...>
Cc: Leif Lindholm <leif@...>
Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Bret Barkelew <Bret.Barkelew@...>
Cc: Michael Kubacki <michael.kubacki@...>

Kun Qin (6):
   MdeModulePkg: VariableSmmRuntimeDxe: Fix Variable Policy Message
     Length
   MdePkg: MmCommunication2: Update MM communicate2 function description
   ArmPkg: MmCommunicationDxe: MM communicate function argument
     attributes
   ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**`
     checks
   ArmPkg: MmCommunicationDxe: Update MM communicate `CommSize` check
   ArmPkg: MmCommunicationDxe: Update MM communicate `MessageLength`
     check

  ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c               | 46 ++++++++++++--------
  MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c | 10 ++---
  MdePkg/Include/Protocol/MmCommunication2.h                        | 13 +++---
  3 files changed, 41 insertions(+), 28 deletions(-)