[Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC files/errors


Michael D Kinney
 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749

Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.

Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyux.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
Cc: Sean Brogan <sean.brogan@...>
Cc: Bret Barkelew <Bret.Barkelew@...>
Cc: Liming Gao <gaoliming@...>
Cc: Michael Kubacki <michael.kubacki@...>
Signed-off-by: Michael D Kinney <michael.d.kinney@...>
---
CryptoPkg/CryptoPkg.ci.yaml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index 1448299073de..eeb388ae71c5 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -19,6 +19,9 @@
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
+ "8001", "IsLeap",
+ "8001", "OBJ_get0_data",
+ "8001", "OBJ_length"
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
@@ -26,14 +29,15 @@
# The unit testing folder is not to be checked
"Test/UnitTest",
# This has OpenSSL interfaces that aren't UEFI spec compliant
- "Library/BaseCryptLib/SysCall/UnitTestHostCrtWrapper.c",
+ "Library/BaseCryptLib/SysCall",
# This has OpenSSL interfaces that aren't UEFI spec compliant
"Library/OpensslLib/rand_pool.c",
# This has OpenSSL interfaces that aren't UEFI spec compliant
"Library/Include/CrtLibSupport.h",
# These directories contain auto-generated OpenSSL content
- "Library/OpensslLib/X64",
- "Library/OpensslLib/X64Gcc"
+ "Library/OpensslLib",
+ "Library/IntrinsicLib",
+ "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"
]
},
"CompilerPlugin": {
--
2.32.0.windows.1


Yao, Jiewen
 

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D
Kinney
Sent: Tuesday, November 23, 2021 1:21 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@...>; Wang, Jian J <jian.j.wang@...>;
Lu, XiaoyuX <xiaoyux.lu@...>; Jiang, Guomin <guomin.jiang@...>;
Sean Brogan <sean.brogan@...>; Bret Barkelew
<Bret.Barkelew@...>; Liming Gao <gaoliming@...>;
Michael Kubacki <michael.kubacki@...>
Subject: [edk2-devel] [Patch 04/12] CryptoPkg: Update YAML to ignore specific
ECC files/errors

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749

Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.

Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyux.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
Cc: Sean Brogan <sean.brogan@...>
Cc: Bret Barkelew <Bret.Barkelew@...>
Cc: Liming Gao <gaoliming@...>
Cc: Michael Kubacki <michael.kubacki@...>
Signed-off-by: Michael D Kinney <michael.d.kinney@...>
---
CryptoPkg/CryptoPkg.ci.yaml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index 1448299073de..eeb388ae71c5 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -19,6 +19,9 @@
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
+ "8001", "IsLeap",
+ "8001", "OBJ_get0_data",
+ "8001", "OBJ_length"
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
@@ -26,14 +29,15 @@
# The unit testing folder is not to be checked
"Test/UnitTest",
# This has OpenSSL interfaces that aren't UEFI spec compliant
- "Library/BaseCryptLib/SysCall/UnitTestHostCrtWrapper.c",
+ "Library/BaseCryptLib/SysCall",
# This has OpenSSL interfaces that aren't UEFI spec compliant
"Library/OpensslLib/rand_pool.c",
# This has OpenSSL interfaces that aren't UEFI spec compliant
"Library/Include/CrtLibSupport.h",
# These directories contain auto-generated OpenSSL content
- "Library/OpensslLib/X64",
- "Library/OpensslLib/X64Gcc"
+ "Library/OpensslLib",
+ "Library/IntrinsicLib",
+ "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"
]
},
"CompilerPlugin": {
--
2.32.0.windows.1





Wang, Jian J
 

Reviewed-by: Jian J Wang <jian.j.wang@...>

Regards,
Jian

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@...>
Sent: Wednesday, November 24, 2021 5:21 AM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@...>; Wang, Jian J <jian.j.wang@...>;
Lu, XiaoyuX <xiaoyux.lu@...>; Jiang, Guomin <guomin.jiang@...>;
Sean Brogan <sean.brogan@...>; Bret Barkelew
<Bret.Barkelew@...>; Liming Gao <gaoliming@...>;
Michael Kubacki <michael.kubacki@...>
Subject: [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC
files/errors

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749

Update package YAML files to ignore ECC errors that are
already present. These issues must be fixed in the future,
but should not block source code changes for these known
issues.

Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyux.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
Cc: Sean Brogan <sean.brogan@...>
Cc: Bret Barkelew <Bret.Barkelew@...>
Cc: Liming Gao <gaoliming@...>
Cc: Michael Kubacki <michael.kubacki@...>
Signed-off-by: Michael D Kinney <michael.d.kinney@...>
---
CryptoPkg/CryptoPkg.ci.yaml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index 1448299073de..eeb388ae71c5 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -19,6 +19,9 @@
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
+ "8001", "IsLeap",
+ "8001", "OBJ_get0_data",
+ "8001", "OBJ_length"
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
@@ -26,14 +29,15 @@
# The unit testing folder is not to be checked
"Test/UnitTest",
# This has OpenSSL interfaces that aren't UEFI spec compliant
- "Library/BaseCryptLib/SysCall/UnitTestHostCrtWrapper.c",
+ "Library/BaseCryptLib/SysCall",
# This has OpenSSL interfaces that aren't UEFI spec compliant
"Library/OpensslLib/rand_pool.c",
# This has OpenSSL interfaces that aren't UEFI spec compliant
"Library/Include/CrtLibSupport.h",
# These directories contain auto-generated OpenSSL content
- "Library/OpensslLib/X64",
- "Library/OpensslLib/X64Gcc"
+ "Library/OpensslLib",
+ "Library/IntrinsicLib",
+ "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"
]
},
"CompilerPlugin": {
--
2.32.0.windows.1