Adding HTTP boot IO timeout programmability from PcdHttpIoTimeout


Clark-williams, Zachary <zachary.clark-williams@...>
 

Hello,

 

Please review the attached filed EDK2 tracker for feature enablement of programmable timeout of the HTTP boot IO timer.

NetworkPkg-HttpBoot: Making the HTTP IO timeout value programmable with PCD.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3507

HTTP boot has a default set forced timeout value of 5 seconds for getting the recovery image from a remote source. This change allows the HTTP boot flow to get the IO timeout value from the PcdHttpIoTimeout. PcdHttpIoTimeout value is set in the OneClickRecovery driver from the value provided by CSME.

PcdHttpIoTimeout minimum value 0.5 seconds
PcdHttpIoTimeout maximum value 120 seconds
PcdHttpIoTimeout default value 5 seconds

 

Thank you,

Zack


Heng Luo
 

+ NetworkPkg Maitainer/Reviewer

Hi Zachary,

I notice you pushed the patch to https://github.com/tianocore/edk2/pull/1834

But according to “The developer process for the EDK II project" In  https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

Normally we send the patch by mail, I recommend you send the patch by mail too(use git send-email *.patch):

The developer process for the EDK II project

  1. Setup the EDK II tree if you do not have one
  2. Create and checkout a topic branch for new feature or bug fix

$ git checkout -b <new-dev-branch> origin/master

  1. Make changes in the working tree
  2. Break up working tree changes into independent commits that do not break git bisect
    • Commit-Partitioning
    • To stage all modifications: $ git add -u
    • To add new files: $ git add <path-to-new-file>
    • To have git prompt you to selectively stage changes: $ git add -p
  3. Follow the commit message template given below when writing commit messages
    • Commit-Message-Format
    • To commit staged changes: $ git commit
      • Add the -s parameter to automatically append your Signed-off-by tag to the commit message.
  4. Use the ‘PatchCheck.py’ script under ‘edk2\BaseTools\Scripts’ directory to verify the commits are correctly formatted
    • To check the latest changes: $ python BaseTools/Scripts/PatchCheck.py -<N>
      • For example, 2 changes would be: $ python BaseTools/Scripts/PatchCheck.py -2
    • It is strongly recommended that you run PatchCheck.py after each commit. You can then easily amend the commit to correct any issues.
  5. Get the latest changes from origin

$ git fetch origin

Note: This updates origin/master, but not your local master branch. (origin/master may have newer commits than master.)

  1. Rebase the topic branch onto master branch

$ git rebase origin/master

  1. Create patch (serial) to the edk2-devel mailing list
    • Clean out any old patches: $ rm *.patch
    • Generate new patch files: $ git format-patch -M --thread origin/master
      • Add the --cover-letter parameter for long patch series. (Be sure to edit the cover-letter.)
      • Add the --subject-prefix="PATCH v2" if you are sending out a second version of the patch series.
    • $ git send-email *.patch
  2. Modify local commits based on the review feedbacks and repeat steps 3 to 9
    • For the latest commit, you can use $ git commit --amend
    • For multiple commits use $ git rebase -i origin/master
    • Consult your git gurus on edk2-devel or irc channel if you have questions.

 

Thanks,

Heng

 

From: Clark-williams, Zachary <zachary.clark-williams@...>
Sent: Friday, July 23, 2021 11:15 AM
To: devel@edk2.groups.io
Cc: Goetz, Philippe C <philippe.c.goetz@...>; Nagar, Rupa <rupa.nagar@...>; Luo, Heng <heng.luo@...>; Zhuang, Qihua <qihua.zhuang@...>; Lu, James <james.lu@...>
Subject: Adding HTTP boot IO timeout programmability from PcdHttpIoTimeout

 

Hello,

 

Please review the attached filed EDK2 tracker for feature enablement of programmable timeout of the HTTP boot IO timer.

NetworkPkg-HttpBoot: Making the HTTP IO timeout value programmable with PCD.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3507

HTTP boot has a default set forced timeout value of 5 seconds for getting the recovery image from a remote source. This change allows the HTTP boot flow to get the IO timeout value from the PcdHttpIoTimeout. PcdHttpIoTimeout value is set in the OneClickRecovery driver from the value provided by CSME.

PcdHttpIoTimeout minimum value 0.5 seconds
PcdHttpIoTimeout maximum value 120 seconds
PcdHttpIoTimeout default value 5 seconds

 

Thank you,

Zack