[PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV


Zhiguang Liu
 

Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
---
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
1 file changed, 2 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayload=
Pkg.fdf
index 2d51fdbacb..041fed842c 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -34,6 +34,7 @@ FV =3D PLDFV
=0D
##########################################################################=
######=0D
[FV.PLDFV]=0D
+FvNameGuid =3D 96E75986-6FDD-491E-9FD5-35E21AC45B45=0D
BlockSize =3D $(FD_BLOCK_SIZE)=0D
FvAlignment =3D 16=0D
ERASE_POLARITY =3D 1=0D
@@ -62,6 +63,7 @@ FILE FV_IMAGE =3D 4E35FD93-9C72-4c15-8C4B-E77F1DB2D793 {
##########################################################################=
######=0D
=0D
[FV.DXEFV]=0D
+FvNameGuid =3D 8063C21A-8E58-4576-95CE-089E87975D23=0D
BlockSize =3D $(FD_BLOCK_SIZE)=0D
FvForceRebase =3D FALSE=0D
FvAlignment =3D 16=0D
--=20
2.30.0.windows.2


Zhiguang Liu
 

Add Maintainers.

Thanks
Zhiguang


From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Zhiguang Liu <zhiguang.liu@...>
Sent: Wednesday, July 14, 2021 14:24
To: devel@edk2.groups.io <devel@edk2.groups.io>
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV
 
Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
---
 UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index 2d51fdbacb..041fed842c 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -34,6 +34,7 @@ FV = PLDFV
 

 ################################################################################

 [FV.PLDFV]

+FvNameGuid         = 96E75986-6FDD-491E-9FD5-35E21AC45B45

 BlockSize          = $(FD_BLOCK_SIZE)

 FvAlignment        = 16

 ERASE_POLARITY     = 1

@@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-E77F1DB2D793 {
 ################################################################################

 

 [FV.DXEFV]

+FvNameGuid         = 8063C21A-8E58-4576-95CE-089E87975D23

 BlockSize          = $(FD_BLOCK_SIZE)

 FvForceRebase      = FALSE

 FvAlignment        = 16

--
2.30.0.windows.2



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
Mute This Topic: https://groups.io/mt/84196221/1779286
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [zhiguang.liu@...]
-=-=-=-=-=-=



Ni, Ray
 

Reviewed-by: Ray Ni <ray.ni@...>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhiguang Liu
Sent: Wednesday, July 14, 2021 2:25 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
---
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
1 file changed, 2 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index 2d51fdbacb..041fed842c 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -34,6 +34,7 @@ FV = PLDFV
################################################################################ [FV.PLDFV]+FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45 BlockSize = $(FD_BLOCK_SIZE) FvAlignment = 16 ERASE_POLARITY = 1@@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-E77F1DB2D793 {
################################################################################ [FV.DXEFV]+FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23 BlockSize = $(FD_BLOCK_SIZE) FvForceRebase = FALSE FvAlignment = 16--
2.30.0.windows.2



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
Mute This Topic: https://groups.io/mt/84196221/1712937
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@...] -=-=-=-=-=-=


Guo Dong
 

Signed-off-by: Guo Dong <guo.dong@...>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
Zhiguang Liu
Sent: Tuesday, July 13, 2021 11:25 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and
PLDFV

Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
---
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
1 file changed, 2 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
b/UefiPayloadPkg/UefiPayloadPkg.fdf
index 2d51fdbacb..041fed842c 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -34,6 +34,7 @@ FV = PLDFV



##########################################################
######################

[FV.PLDFV]

+FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45

BlockSize = $(FD_BLOCK_SIZE)

FvAlignment = 16

ERASE_POLARITY = 1

@@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-
E77F1DB2D793 {

##########################################################
######################



[FV.DXEFV]

+FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23

BlockSize = $(FD_BLOCK_SIZE)

FvForceRebase = FALSE

FvAlignment = 16

--
2.30.0.windows.2



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
Mute This Topic: https://groups.io/mt/84196221/1781375
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@...]
-=-=-=-=-=-=


King Sumo
 

Hi All,

This patch broke the coreboot payload loading. Tested with:
build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT

Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image:
"Not a usable UEFI firmware volume"

Trying to boot coreboot results in an exception and the following error message:
"Payload not loaded"

Probably it broke the interface.

commit 4bac086e8e007c7143e33f87bb96238326d1d6ba
Author: Zhiguang Liu <zhiguang.liu@...>
Date:   Wed Jul 14 14:24:45 2021 +0800

    UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

    Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
    Reviewed-by: Ray Ni <ray.ni@...>
    Reviewed-by: Guo Dong <guo.dong@...>


Kind regards,
Sumo

On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@...> wrote:

Signed-off-by: Guo Dong <guo.dong@...>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Tuesday, July 13, 2021 11:25 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and
> PLDFV
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index 2d51fdbacb..041fed842c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -34,6 +34,7 @@ FV = PLDFV
>
>
>
> ##########################################################
> ######################
>
>  [FV.PLDFV]
>
> +FvNameGuid         = 96E75986-6FDD-491E-9FD5-35E21AC45B45
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvAlignment        = 16
>
>  ERASE_POLARITY     = 1
>
> @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-
> E77F1DB2D793 {
>
> ##########################################################
> ######################
>
>
>
>  [FV.DXEFV]
>
> +FvNameGuid         = 8063C21A-8E58-4576-95CE-089E87975D23
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvForceRebase      = FALSE
>
>  FvAlignment        = 16
>
> --
> 2.30.0.windows.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
> Mute This Topic: https://groups.io/mt/84196221/1781375
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@...]
> -=-=-=-=-=-=
>







Ni, Ray
 

It seems like the coreboot cannot support FV that contains GUID in its header.

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of King Sumo
Sent: Tuesday, August 24, 2021 1:02 AM
To: devel@edk2.groups.io; Dong, Guo <guo.dong@...>
Cc: Liu, Zhiguang <zhiguang.liu@...>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

 

Hi All,

 

This patch broke the coreboot payload loading. Tested with:

build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT


Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image:

"Not a usable UEFI firmware volume"

 

Trying to boot coreboot results in an exception and the following error message:

"Payload not loaded"


Probably it broke the interface.

 

commit 4bac086e8e007c7143e33f87bb96238326d1d6ba
Author: Zhiguang Liu <zhiguang.liu@...>
Date:   Wed Jul 14 14:24:45 2021 +0800

    UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

    Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
    Reviewed-by: Ray Ni <ray.ni@...>
    Reviewed-by: Guo Dong <guo.dong@...>

 

 

Kind regards,

Sumo

 

On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@...> wrote:


Signed-off-by: Guo Dong <guo.dong@...>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Tuesday, July 13, 2021 11:25 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and
> PLDFV
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index 2d51fdbacb..041fed842c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -34,6 +34,7 @@ FV = PLDFV
>
>
>
> ##########################################################
> ######################
>
>  [FV.PLDFV]
>
> +FvNameGuid         = 96E75986-6FDD-491E-9FD5-35E21AC45B45
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvAlignment        = 16
>
>  ERASE_POLARITY     = 1
>
> @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-
> E77F1DB2D793 {
>
> ##########################################################
> ######################
>
>
>
>  [FV.DXEFV]
>
> +FvNameGuid         = 8063C21A-8E58-4576-95CE-089E87975D23
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvForceRebase      = FALSE
>
>  FvAlignment        = 16
>
> --
> 2.30.0.windows.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
> Mute This Topic: https://groups.io/mt/84196221/1781375
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@...]
> -=-=-=-=-=-=
>






King Sumo
 

I have filed a bug report:
https://bugzilla.tianocore.org/show_bug.cgi?id=3585


Guo Dong
 

 

Hi Zhiguang,

This patch just uses an actual FV GUID to replace the dummy FV GUID (all zero FV GUID) and no FV layout change, right?

If so, this change should not impact the coreboot FV parse to find the FV entrypoint.

https://github.com/coreboot/coreboot/blob/master/util/cbfstool/cbfs-mkpayload.c

 

Thanks,

Guo

 

From: Ni, Ray <ray.ni@...>
Sent: Tuesday, August 24, 2021 4:45 AM
To: devel@edk2.groups.io; kingsumos@...; Dong, Guo <guo.dong@...>
Cc: Liu, Zhiguang <zhiguang.liu@...>; Tan, Dun <dun.tan@...>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

 

It seems like the coreboot cannot support FV that contains GUID in its header.

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of King Sumo
Sent: Tuesday, August 24, 2021 1:02 AM
To: devel@edk2.groups.io; Dong, Guo <guo.dong@...>
Cc: Liu, Zhiguang <zhiguang.liu@...>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

 

Hi All,

 

This patch broke the coreboot payload loading. Tested with:

build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT


Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image:

"Not a usable UEFI firmware volume"

 

Trying to boot coreboot results in an exception and the following error message:

"Payload not loaded"


Probably it broke the interface.

 

commit 4bac086e8e007c7143e33f87bb96238326d1d6ba
Author: Zhiguang Liu <zhiguang.liu@...>
Date:   Wed Jul 14 14:24:45 2021 +0800

    UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

    Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
    Reviewed-by: Ray Ni <ray.ni@...>
    Reviewed-by: Guo Dong <guo.dong@...>

 

 

Kind regards,

Sumo

 

On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@...> wrote:


Signed-off-by: Guo Dong <guo.dong@...>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Tuesday, July 13, 2021 11:25 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and
> PLDFV
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index 2d51fdbacb..041fed842c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -34,6 +34,7 @@ FV = PLDFV
>
>
>
> ##########################################################
> ######################
>
>  [FV.PLDFV]
>
> +FvNameGuid         = 96E75986-6FDD-491E-9FD5-35E21AC45B45
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvAlignment        = 16
>
>  ERASE_POLARITY     = 1
>
> @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-
> E77F1DB2D793 {
>
> ##########################################################
> ######################
>
>
>
>  [FV.DXEFV]
>
> +FvNameGuid         = 8063C21A-8E58-4576-95CE-089E87975D23
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvForceRebase      = FALSE
>
>  FvAlignment        = 16
>
> --
> 2.30.0.windows.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
> Mute This Topic: https://groups.io/mt/84196221/1781375
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@...]
> -=-=-=-=-=-=
>





Ni, Ray
 

Dun will investigate this issue. There might be some issue in coreboot implementation that doesn’t handle the existence of EFI_FIRMWARE_VOLUME_EXT_HEADER.

 

From: Dong, Guo <guo.dong@...>
Sent: Wednesday, August 25, 2021 2:53 AM
To: Ni, Ray <ray.ni@...>; devel@edk2.groups.io; kingsumos@...
Cc: Liu, Zhiguang <zhiguang.liu@...>; Tan, Dun <dun.tan@...>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

 

 

Hi Zhiguang,

This patch just uses an actual FV GUID to replace the dummy FV GUID (all zero FV GUID) and no FV layout change, right?

If so, this change should not impact the coreboot FV parse to find the FV entrypoint.

https://github.com/coreboot/coreboot/blob/master/util/cbfstool/cbfs-mkpayload.c

 

Thanks,

Guo

 

From: Ni, Ray <ray.ni@...>
Sent: Tuesday, August 24, 2021 4:45 AM
To: devel@edk2.groups.io; kingsumos@...; Dong, Guo <guo.dong@...>
Cc: Liu, Zhiguang <zhiguang.liu@...>; Tan, Dun <dun.tan@...>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

 

It seems like the coreboot cannot support FV that contains GUID in its header.

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of King Sumo
Sent: Tuesday, August 24, 2021 1:02 AM
To: devel@edk2.groups.io; Dong, Guo <guo.dong@...>
Cc: Liu, Zhiguang <zhiguang.liu@...>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

 

Hi All,

 

This patch broke the coreboot payload loading. Tested with:

build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT


Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image:

"Not a usable UEFI firmware volume"

 

Trying to boot coreboot results in an exception and the following error message:

"Payload not loaded"


Probably it broke the interface.

 

commit 4bac086e8e007c7143e33f87bb96238326d1d6ba
Author: Zhiguang Liu <zhiguang.liu@...>
Date:   Wed Jul 14 14:24:45 2021 +0800

    UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

    Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
    Reviewed-by: Ray Ni <ray.ni@...>
    Reviewed-by: Guo Dong <guo.dong@...>

 

 

Kind regards,

Sumo

 

On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@...> wrote:


Signed-off-by: Guo Dong <guo.dong@...>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Tuesday, July 13, 2021 11:25 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and
> PLDFV
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index 2d51fdbacb..041fed842c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -34,6 +34,7 @@ FV = PLDFV
>
>
>
> ##########################################################
> ######################
>
>  [FV.PLDFV]
>
> +FvNameGuid         = 96E75986-6FDD-491E-9FD5-35E21AC45B45
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvAlignment        = 16
>
>  ERASE_POLARITY     = 1
>
> @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-
> E77F1DB2D793 {
>
> ##########################################################
> ######################
>
>
>
>  [FV.DXEFV]
>
> +FvNameGuid         = 8063C21A-8E58-4576-95CE-089E87975D23
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvForceRebase      = FALSE
>
>  FvAlignment        = 16
>
> --
> 2.30.0.windows.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
> Mute This Topic: https://groups.io/mt/84196221/1781375
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@...]
> -=-=-=-=-=-=
>




duntan
 

Hi all,

 

I have push the commit to fix this issue to coreboot.org. Here is the link.

https://review.coreboot.org/c/coreboot/+/57296

This issue is caused because the coreboot implementation doesn’t handle the existence of EFI_FIRMWARE_VOLUME_EXT_HEADER, resulting in address of UefiPayloadEntry to be found incorrectly when parsing Fv.

Can you please help to review and merge this commit?

 

Thanks,

Dun

From: Ni, Ray <ray.ni@...>
Sent: Wednesday, August 25, 2021 8:28 AM
To: Dong, Guo <guo.dong@...>; devel@edk2.groups.io; kingsumos@...
Cc: Liu, Zhiguang <zhiguang.liu@...>; Tan, Dun <dun.tan@...>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

 

Dun will investigate this issue. There might be some issue in coreboot implementation that doesn’t handle the existence of EFI_FIRMWARE_VOLUME_EXT_HEADER.

 

From: Dong, Guo <guo.dong@...>
Sent: Wednesday, August 25, 2021 2:53 AM
To: Ni, Ray <ray.ni@...>; devel@edk2.groups.io; kingsumos@...
Cc: Liu, Zhiguang <zhiguang.liu@...>; Tan, Dun <dun.tan@...>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

 

 

Hi Zhiguang,

This patch just uses an actual FV GUID to replace the dummy FV GUID (all zero FV GUID) and no FV layout change, right?

If so, this change should not impact the coreboot FV parse to find the FV entrypoint.

https://github.com/coreboot/coreboot/blob/master/util/cbfstool/cbfs-mkpayload.c

 

Thanks,

Guo

 

From: Ni, Ray <ray.ni@...>
Sent: Tuesday, August 24, 2021 4:45 AM
To: devel@edk2.groups.io; kingsumos@...; Dong, Guo <guo.dong@...>
Cc: Liu, Zhiguang <zhiguang.liu@...>; Tan, Dun <dun.tan@...>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

 

It seems like the coreboot cannot support FV that contains GUID in its header.

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of King Sumo
Sent: Tuesday, August 24, 2021 1:02 AM
To: devel@edk2.groups.io; Dong, Guo <guo.dong@...>
Cc: Liu, Zhiguang <zhiguang.liu@...>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

 

Hi All,

 

This patch broke the coreboot payload loading. Tested with:

build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT


Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image:

"Not a usable UEFI firmware volume"

 

Trying to boot coreboot results in an exception and the following error message:

"Payload not loaded"


Probably it broke the interface.

 

commit 4bac086e8e007c7143e33f87bb96238326d1d6ba
Author: Zhiguang Liu <zhiguang.liu@...>
Date:   Wed Jul 14 14:24:45 2021 +0800

    UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

    Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
    Reviewed-by: Ray Ni <ray.ni@...>
    Reviewed-by: Guo Dong <guo.dong@...>

 

 

Kind regards,

Sumo

 

On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@...> wrote:


Signed-off-by: Guo Dong <guo.dong@...>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang Liu
> Sent: Tuesday, July 13, 2021 11:25 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and
> PLDFV
>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index 2d51fdbacb..041fed842c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -34,6 +34,7 @@ FV = PLDFV
>
>
>
> ##########################################################
> ######################
>
>  [FV.PLDFV]
>
> +FvNameGuid         = 96E75986-6FDD-491E-9FD5-35E21AC45B45
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvAlignment        = 16
>
>  ERASE_POLARITY     = 1
>
> @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-
> E77F1DB2D793 {
>
> ##########################################################
> ######################
>
>
>
>  [FV.DXEFV]
>
> +FvNameGuid         = 8063C21A-8E58-4576-95CE-089E87975D23
>
>  BlockSize          = $(FD_BLOCK_SIZE)
>
>  FvForceRebase      = FALSE
>
>  FvAlignment        = 16
>
> --
> 2.30.0.windows.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
> Mute This Topic: https://groups.io/mt/84196221/1781375
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@...]
> -=-=-=-=-=-=
>