[PATCH RESEND v1 0/2] ArmVirtPkg: Enable PCIe support for Kvmtool


Sami Mujawar
 

Pushed as d9a7612f8d1d..4dda0f7ab44a.

Regards,

Sami Mujawar

On 22/06/2021, 17:49, "devel@edk2.groups.io on behalf of Sami Mujawar via groups.io" <devel@edk2.groups.io on behalf of sami.mujawar=arm.com@groups.io> wrote:

Hi Laszlo,

On 22/06/2021, 12:01, "devel@edk2.groups.io on behalf of Laszlo Ersek via groups.io" <devel@edk2.groups.io on behalf of lersek=redhat.com@groups.io> wrote:

On 06/21/21 15:43, Alexandru Elisei wrote:
> Hi Pierre,
>
> On 6/15/21 4:21 PM, PierreGondois via groups.io wrote:
>> From: Pierre Gondois <Pierre.Gondois@arm.com>
>>
>> PCIe support has been added to the Kvmtool virtual machine
>> manager. Therefore, add a PciHostBridgeUtilityLib and enable
>> PCIe support for Kvmtool firmware.
>>
>> The patches were re-send as the devel@edk2.groups.io was not included.
>>
>> The patches can be seen at: https://github.com/PierreARM/edk2/tree/1413_Enable_ArmVirt_Pci_v1
>> The results of the CI can be seen at: https://github.com/tianocore/edk2/pull/1718
>
> Tested the patches with the latest version of the kvmtool PCI Express support [1],
> and everything worked as expected. A summary of the tests that I ran can be found
> at [1]. So you can add for the entire series:
>
> Tested-by: Alexandru Elisei <alexandru.elisei@arm.com>
>
> One thing of note is that applying patch #2 of this series on top of 11b1c1d4b98b
> ("SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter")
> failed.

If there is a conflict that needs to be resolved, then Pierre, can you
please repost?

Otherwise: Sami, can you please merge the series with Ard's and Alex's tags?

[SAMI] I will merge this series shortly.

Regards,

Sami Mujawar

Thanks!
Laszlo


> However, building from your repo went fine, and the binary that I used for
> testing was built from your repo.
>
> [1] https://lore.kernel.org/kvm/20210621092128.11313-1-alexandru.elisei@arm.com/
>
> Thanks,
>
> Alex
>
>>
>> Sami Mujawar (2):
>> ArmVirtPkg: Add PCIe host bridge utility lib for ArmVirtPkg
>> ArmVirtPkg: Enable PCIe support for Kvmtool
>>
>> ArmVirtPkg/ArmVirtKvmTool.dsc | 35 ++-
>> ArmVirtPkg/ArmVirtKvmTool.fdf | 11 +-
>> .../ArmVirtPciHostBridgeUtilityLib.c | 219 ++++++++++++++++++
>> .../ArmVirtPciHostBridgeUtilityLib.inf | 39 ++++
>> 4 files changed, 301 insertions(+), 3 deletions(-)
>> create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.c
>> create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf
>>
>
>
>
>
>


Sami Mujawar
 

Hi Laszlo,


On 22/06/2021, 12:01, "devel@edk2.groups.io on behalf of Laszlo Ersek via groups.io" <devel@edk2.groups.io on behalf of lersek=redhat.com@groups.io> wrote:

On 06/21/21 15:43, Alexandru Elisei wrote:
> Hi Pierre,
>
> On 6/15/21 4:21 PM, PierreGondois via groups.io wrote:
>> From: Pierre Gondois <Pierre.Gondois@arm.com>
>>
>> PCIe support has been added to the Kvmtool virtual machine
>> manager. Therefore, add a PciHostBridgeUtilityLib and enable
>> PCIe support for Kvmtool firmware.
>>
>> The patches were re-send as the devel@edk2.groups.io was not included.
>>
>> The patches can be seen at: https://github.com/PierreARM/edk2/tree/1413_Enable_ArmVirt_Pci_v1
>> The results of the CI can be seen at: https://github.com/tianocore/edk2/pull/1718
>
> Tested the patches with the latest version of the kvmtool PCI Express support [1],
> and everything worked as expected. A summary of the tests that I ran can be found
> at [1]. So you can add for the entire series:
>
> Tested-by: Alexandru Elisei <alexandru.elisei@arm.com>
>
> One thing of note is that applying patch #2 of this series on top of 11b1c1d4b98b
> ("SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter")
> failed.

If there is a conflict that needs to be resolved, then Pierre, can you
please repost?

Otherwise: Sami, can you please merge the series with Ard's and Alex's tags?

[SAMI] I will merge this series shortly.

Regards,

Sami Mujawar

Thanks!
Laszlo


> However, building from your repo went fine, and the binary that I used for
> testing was built from your repo.
>
> [1] https://lore.kernel.org/kvm/20210621092128.11313-1-alexandru.elisei@arm.com/
>
> Thanks,
>
> Alex
>
>>
>> Sami Mujawar (2):
>> ArmVirtPkg: Add PCIe host bridge utility lib for ArmVirtPkg
>> ArmVirtPkg: Enable PCIe support for Kvmtool
>>
>> ArmVirtPkg/ArmVirtKvmTool.dsc | 35 ++-
>> ArmVirtPkg/ArmVirtKvmTool.fdf | 11 +-
>> .../ArmVirtPciHostBridgeUtilityLib.c | 219 ++++++++++++++++++
>> .../ArmVirtPciHostBridgeUtilityLib.inf | 39 ++++
>> 4 files changed, 301 insertions(+), 3 deletions(-)
>> create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.c
>> create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf
>>
>
>
>
>
>


Laszlo Ersek
 

On 06/21/21 15:43, Alexandru Elisei wrote:
Hi Pierre,

On 6/15/21 4:21 PM, PierreGondois via groups.io wrote:
From: Pierre Gondois <Pierre.Gondois@arm.com>

PCIe support has been added to the Kvmtool virtual machine
manager. Therefore, add a PciHostBridgeUtilityLib and enable
PCIe support for Kvmtool firmware.

The patches were re-send as the devel@edk2.groups.io was not included.

The patches can be seen at: https://github.com/PierreARM/edk2/tree/1413_Enable_ArmVirt_Pci_v1
The results of the CI can be seen at: https://github.com/tianocore/edk2/pull/1718
Tested the patches with the latest version of the kvmtool PCI Express support [1],
and everything worked as expected. A summary of the tests that I ran can be found
at [1]. So you can add for the entire series:

Tested-by: Alexandru Elisei <alexandru.elisei@arm.com>

One thing of note is that applying patch #2 of this series on top of 11b1c1d4b98b
("SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter")
failed.
If there is a conflict that needs to be resolved, then Pierre, can you
please repost?

Otherwise: Sami, can you please merge the series with Ard's and Alex's tags?

Thanks!
Laszlo


However, building from your repo went fine, and the binary that I used for
testing was built from your repo.

[1] https://lore.kernel.org/kvm/20210621092128.11313-1-alexandru.elisei@arm.com/

Thanks,

Alex


Sami Mujawar (2):
ArmVirtPkg: Add PCIe host bridge utility lib for ArmVirtPkg
ArmVirtPkg: Enable PCIe support for Kvmtool

ArmVirtPkg/ArmVirtKvmTool.dsc | 35 ++-
ArmVirtPkg/ArmVirtKvmTool.fdf | 11 +-
.../ArmVirtPciHostBridgeUtilityLib.c | 219 ++++++++++++++++++
.../ArmVirtPciHostBridgeUtilityLib.inf | 39 ++++
4 files changed, 301 insertions(+), 3 deletions(-)
create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.c
create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf




Alexandru Elisei
 

Hi Pierre,

On 6/15/21 4:21 PM, PierreGondois via groups.io wrote:
From: Pierre Gondois <Pierre.Gondois@arm.com>

PCIe support has been added to the Kvmtool virtual machine
manager. Therefore, add a PciHostBridgeUtilityLib and enable
PCIe support for Kvmtool firmware.

The patches were re-send as the devel@edk2.groups.io was not included.

The patches can be seen at: https://github.com/PierreARM/edk2/tree/1413_Enable_ArmVirt_Pci_v1
The results of the CI can be seen at: https://github.com/tianocore/edk2/pull/1718
Tested the patches with the latest version of the kvmtool PCI Express support [1],
and everything worked as expected. A summary of the tests that I ran can be found
at [1]. So you can add for the entire series:

Tested-by: Alexandru Elisei <alexandru.elisei@arm.com>

One thing of note is that applying patch #2 of this series on top of 11b1c1d4b98b
("SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter")
failed. However, building from your repo went fine, and the binary that I used for
testing was built from your repo.

[1] https://lore.kernel.org/kvm/20210621092128.11313-1-alexandru.elisei@arm.com/

Thanks,

Alex


Sami Mujawar (2):
ArmVirtPkg: Add PCIe host bridge utility lib for ArmVirtPkg
ArmVirtPkg: Enable PCIe support for Kvmtool

ArmVirtPkg/ArmVirtKvmTool.dsc | 35 ++-
ArmVirtPkg/ArmVirtKvmTool.fdf | 11 +-
.../ArmVirtPciHostBridgeUtilityLib.c | 219 ++++++++++++++++++
.../ArmVirtPciHostBridgeUtilityLib.inf | 39 ++++
4 files changed, 301 insertions(+), 3 deletions(-)
create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.c
create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf


Ard Biesheuvel
 

On Tue, 15 Jun 2021 at 17:21, <Pierre.Gondois@arm.com> wrote:

From: Pierre Gondois <Pierre.Gondois@arm.com>

PCIe support has been added to the Kvmtool virtual machine
manager. Therefore, add a PciHostBridgeUtilityLib and enable
PCIe support for Kvmtool firmware.

The patches were re-send as the devel@edk2.groups.io was not included.

The patches can be seen at: https://github.com/PierreARM/edk2/tree/1413_Enable_ArmVirt_Pci_v1
The results of the CI can be seen at: https://github.com/tianocore/edk2/pull/1718

Sami Mujawar (2):
ArmVirtPkg: Add PCIe host bridge utility lib for ArmVirtPkg
ArmVirtPkg: Enable PCIe support for Kvmtool
For the series,

Acked-by: Ard Biesheuvel <ardb@kernel.org>

ArmVirtPkg/ArmVirtKvmTool.dsc | 35 ++-
ArmVirtPkg/ArmVirtKvmTool.fdf | 11 +-
.../ArmVirtPciHostBridgeUtilityLib.c | 219 ++++++++++++++++++
.../ArmVirtPciHostBridgeUtilityLib.inf | 39 ++++
4 files changed, 301 insertions(+), 3 deletions(-)
create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.c
create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf

--
2.17.1


PierreGondois
 

From: Pierre Gondois <Pierre.Gondois@arm.com>

PCIe support has been added to the Kvmtool virtual machine
manager. Therefore, add a PciHostBridgeUtilityLib and enable
PCIe support for Kvmtool firmware.

The patches were re-send as the devel@edk2.groups.io was not included.

The patches can be seen at: https://github.com/PierreARM/edk2/tree/1413_Enable_ArmVirt_Pci_v1
The results of the CI can be seen at: https://github.com/tianocore/edk2/pull/1718

Sami Mujawar (2):
ArmVirtPkg: Add PCIe host bridge utility lib for ArmVirtPkg
ArmVirtPkg: Enable PCIe support for Kvmtool

ArmVirtPkg/ArmVirtKvmTool.dsc | 35 ++-
ArmVirtPkg/ArmVirtKvmTool.fdf | 11 +-
.../ArmVirtPciHostBridgeUtilityLib.c | 219 ++++++++++++++++++
.../ArmVirtPciHostBridgeUtilityLib.inf | 39 ++++
4 files changed, 301 insertions(+), 3 deletions(-)
create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.c
create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf

--
2.17.1