回复: [PATCH v3 0/2] MdePkg,SecurityPkg: Add support to RngDxe and BaseRngLib for AARCH64 RNDR


Ard Biesheuvel
 

On Tue, 11 May 2021 at 05:03, gaoliming <gaoliming@byosoft.com.cn> wrote:

Thanks for your update. This version patches are good to me.

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Merged as #1633

Thanks all,

-----邮件原件-----
发件人: Rebecca Cran <rebecca@nuviainc.com>
发送时间: 2021年5月11日 5:53
收件人: devel@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Jian J
Wang <jian.j.wang@intel.com>; Michael D Kinney
<michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
Zhiguang Liu <zhiguang.liu@intel.com>; Ard Biesheuvel
<ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>
抄送: Rebecca Cran <rebecca@nuviainc.com>
主题: [PATCH v3 0/2] MdePkg,SecurityPkg: Add support to RngDxe and
BaseRngLib for AARCH64 RNDR

Update MdePkg BaseRngLib and SecurityPkg RngDxe to add support for
the AARCH64 RNDR instruction.

Changes from v2 to v3:

o Fixed the default value of
gEfiSecurityPkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm
to be an empty GUID.
o Removed RNDRRS since it wasn't being used.
o Fixed the commit message to remove mention of BaseLib.

Rebecca Cran (2):
MdePkg/BaseRngLib: Add support for ARMv8.5 RNG instructions
SecurityPkg: Add support for RngDxe on AARCH64

MdePkg/MdePkg.dec
| 9 +-
SecurityPkg/SecurityPkg.dec |
2 +
MdePkg/MdePkg.dsc
| 4 +-
SecurityPkg/SecurityPkg.dsc |
11 +-
MdePkg/Library/BaseRngLib/BaseRngLib.inf |
23 ++-
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf |
24 ++-
MdePkg/Library/BaseRngLib/AArch64/ArmRng.h |
43 +++++
MdePkg/Library/BaseRngLib/BaseRngLibInternals.h |
78 +++++++++
SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/AesCore.h |
0
SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/RdRand.h |
17 --
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h |
117 ++++++++++++++
MdePkg/Library/BaseRngLib/AArch64/Rndr.c |
139 ++++++++++++++++
MdePkg/Library/BaseRngLib/BaseRng.c |
87 +++++-----
MdePkg/Library/BaseRngLib/Rand/RdRand.c |
131 +++++++++++++++
SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c |
127 +++++++++++++++
SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/AesCore.c |
0
SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/RdRand.c |
45 +-----
SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c |
146 +++++++++++++++++
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c |
170 ++++++++------------
MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.S |
31 ++++
MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.asm |
30 ++++
MdePkg/Library/BaseRngLib/AArch64/ArmRng.S |
37 +++++
MdePkg/Library/BaseRngLib/AArch64/ArmRng.asm |
39 +++++
MdePkg/Library/BaseRngLib/BaseRngLib.uni |
6 +-
24 files changed, 1086 insertions(+), 230 deletions(-)
create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.h
create mode 100644 MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
Rand}/AesCore.h (100%)
rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
Rand}/RdRand.h (72%)
create mode 100644
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h
create mode 100644 MdePkg/Library/BaseRngLib/AArch64/Rndr.c
create mode 100644 MdePkg/Library/BaseRngLib/Rand/RdRand.c
create mode 100644
SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c
rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
Rand}/AesCore.c (100%)
rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
Rand}/RdRand.c (71%)
create mode 100644
SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c
create mode 100644
MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.S
create mode 100644
MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.asm
create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.S
create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.asm

--
2.26.2







gaoliming
 

Thanks for your update. This version patches are good to me.

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

-----邮件原件-----
发件人: Rebecca Cran <rebecca@nuviainc.com>
发送时间: 2021年5月11日 5:53
收件人: devel@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Jian J
Wang <jian.j.wang@intel.com>; Michael D Kinney
<michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
Zhiguang Liu <zhiguang.liu@intel.com>; Ard Biesheuvel
<ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>
抄送: Rebecca Cran <rebecca@nuviainc.com>
主题: [PATCH v3 0/2] MdePkg,SecurityPkg: Add support to RngDxe and
BaseRngLib for AARCH64 RNDR

Update MdePkg BaseRngLib and SecurityPkg RngDxe to add support for
the AARCH64 RNDR instruction.

Changes from v2 to v3:

o Fixed the default value of
gEfiSecurityPkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm
to be an empty GUID.
o Removed RNDRRS since it wasn't being used.
o Fixed the commit message to remove mention of BaseLib.

Rebecca Cran (2):
MdePkg/BaseRngLib: Add support for ARMv8.5 RNG instructions
SecurityPkg: Add support for RngDxe on AARCH64

MdePkg/MdePkg.dec
| 9 +-
SecurityPkg/SecurityPkg.dec |
2 +
MdePkg/MdePkg.dsc
| 4 +-
SecurityPkg/SecurityPkg.dsc |
11 +-
MdePkg/Library/BaseRngLib/BaseRngLib.inf |
23 ++-
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf |
24 ++-
MdePkg/Library/BaseRngLib/AArch64/ArmRng.h |
43 +++++
MdePkg/Library/BaseRngLib/BaseRngLibInternals.h |
78 +++++++++
SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/AesCore.h |
0
SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/RdRand.h |
17 --
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h |
117 ++++++++++++++
MdePkg/Library/BaseRngLib/AArch64/Rndr.c |
139 ++++++++++++++++
MdePkg/Library/BaseRngLib/BaseRng.c |
87 +++++-----
MdePkg/Library/BaseRngLib/Rand/RdRand.c |
131 +++++++++++++++
SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c |
127 +++++++++++++++
SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/AesCore.c |
0
SecurityPkg/RandomNumberGenerator/RngDxe/{ => Rand}/RdRand.c |
45 +-----
SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c |
146 +++++++++++++++++
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.c |
170 ++++++++------------
MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.S |
31 ++++
MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.asm |
30 ++++
MdePkg/Library/BaseRngLib/AArch64/ArmRng.S |
37 +++++
MdePkg/Library/BaseRngLib/AArch64/ArmRng.asm |
39 +++++
MdePkg/Library/BaseRngLib/BaseRngLib.uni |
6 +-
24 files changed, 1086 insertions(+), 230 deletions(-)
create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.h
create mode 100644 MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
Rand}/AesCore.h (100%)
rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
Rand}/RdRand.h (72%)
create mode 100644
SecurityPkg/RandomNumberGenerator/RngDxe/RngDxeInternals.h
create mode 100644 MdePkg/Library/BaseRngLib/AArch64/Rndr.c
create mode 100644 MdePkg/Library/BaseRngLib/Rand/RdRand.c
create mode 100644
SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c
rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
Rand}/AesCore.c (100%)
rename SecurityPkg/RandomNumberGenerator/RngDxe/{ =>
Rand}/RdRand.c (71%)
create mode 100644
SecurityPkg/RandomNumberGenerator/RngDxe/Rand/RngDxe.c
create mode 100644
MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.S
create mode 100644
MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.asm
create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.S
create mode 100644 MdePkg/Library/BaseRngLib/AArch64/ArmRng.asm

--
2.26.2