[edk2-platforms][PATCH V3 00/14] Platform/Sgi: Add PPTT table for Neoverse Reference Design platforms


Pranav Madhu
 

Changes since V2:
- Introduced CPU container object into DSDT
- Addressed comments from Sami

Changes since V1:
- Rebase the patches on top of latest master branch
- Addressed comments from Pierre

Processor Properties Topology Table (PPTT) describes the topological
structure of processors, and their shared resources such as caches.
This patch series adds PPTT table for Arm's Neoverse Reference Design
platforms.

The first patch in this series adds helper macros for PPTT table, and
the subsequent patches in this series adds PPTT table for Neoverse
Reference Design platforms which is mandatory as per Arm SystemReady SR
specification.

Link to github branch with the patches in this series -
https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rd_pptt

Pranav Madhu (14):
Platform/Sgi: Helper macros for PPTT Table
Platform/Sgi: Add CPU container for SGI-575
Platform/Sgi: ACPI PPTT table for SGI-575 platform
Platform/Sgi: Add CPU container for RD-N1-Edge
Platform/Sgi: ACPI PPTT table for RD-N1-Edge platform
Platform/Sgi: Add DSDT ACPI table for RD-N1-Edge dual-chip platform
Platform/Sgi: ACPI PPTT table for RD-N1-Edge dual-chip
Platform/Sgi: ACPI PPTT table for RD-E1-Edge platform
Platform/Sgi: Add CPU container for RD-V1 platform
Platform/Sgi: ACPI PPTT Table for RD-V1 platform
Platform/Sgi: Add CPU container for RD-V1 quad-chip platform
Platform/Sgi: ACPI PPTT Table for RD-V1 quad-chip platform
Platform/Sgi: Add CPU container for RD-N2 platform
Platform/Sgi: ACPI PPTT table for RD-N2 platform

.../SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf | 3 +-
.../SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf | 3 +-
.../AcpiTables/RdN1EdgeX2AcpiTables.inf | 3 +-
.../ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 3 +-
.../ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf | 3 +-
.../SgiPkg/AcpiTables/RdV1McAcpiTables.inf | 1 +
.../SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 3 +-
Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 170 ++++++++++++
.../ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc | 252 ++++++++++++++++++
.../ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl | 88 +++---
.../ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc | 186 +++++++++++++
.../ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl | 136 ++++++++++
.../SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc | 207 ++++++++++++++
Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl | 176 ++++++++----
Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc | 175 ++++++++++++
Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl | 176 ++++++++----
Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc | 175 ++++++++++++
.../ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 177 ++++++++----
.../ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc | 184 +++++++++++++
.../ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 99 +++----
.../ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc | 172 ++++++++++++
21 files changed, 2156 insertions(+), 236 deletions(-)
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc

--=20
2.17.1


Sami Mujawar
 

Hi Pranav,

Comparing with the V2 series, I see that updates to the following files or corresponding patches are missing in this series.

- RdV1Mc/Pptt.aslc
- RdN2/Pptt.aslc

Is this intentional?

Regards,

Sami Mujawar

On 10/05/2021 09:06 PM, Pranav Madhu wrote:
Changes since V2:
- Introduced CPU container object into DSDT
- Addressed comments from Sami

Changes since V1:
- Rebase the patches on top of latest master branch
- Addressed comments from Pierre

Processor Properties Topology Table (PPTT) describes the topological
structure of processors, and their shared resources such as caches.
This patch series adds PPTT table for Arm's Neoverse Reference Design
platforms.

The first patch in this series adds helper macros for PPTT table, and
the subsequent patches in this series adds PPTT table for Neoverse
Reference Design platforms which is mandatory as per Arm SystemReady SR
specification.

Link to github branch with the patches in this series -
https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rd_pptt

Pranav Madhu (14):
Platform/Sgi: Helper macros for PPTT Table
Platform/Sgi: Add CPU container for SGI-575
Platform/Sgi: ACPI PPTT table for SGI-575 platform
Platform/Sgi: Add CPU container for RD-N1-Edge
Platform/Sgi: ACPI PPTT table for RD-N1-Edge platform
Platform/Sgi: Add DSDT ACPI table for RD-N1-Edge dual-chip platform
Platform/Sgi: ACPI PPTT table for RD-N1-Edge dual-chip
Platform/Sgi: ACPI PPTT table for RD-E1-Edge platform
Platform/Sgi: Add CPU container for RD-V1 platform
Platform/Sgi: ACPI PPTT Table for RD-V1 platform
Platform/Sgi: Add CPU container for RD-V1 quad-chip platform
Platform/Sgi: ACPI PPTT Table for RD-V1 quad-chip platform
Platform/Sgi: Add CPU container for RD-N2 platform
Platform/Sgi: ACPI PPTT table for RD-N2 platform

.../SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf | 3 +-
.../SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf | 3 +-
.../AcpiTables/RdN1EdgeX2AcpiTables.inf | 3 +-
.../ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 3 +-
.../ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf | 3 +-
.../SgiPkg/AcpiTables/RdV1McAcpiTables.inf | 1 +
.../SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 3 +-
Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 170 ++++++++++++
.../ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc | 252 ++++++++++++++++++
.../ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl | 88 +++---
.../ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc | 186 +++++++++++++
.../ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl | 136 ++++++++++
.../SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc | 207 ++++++++++++++
Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl | 176 ++++++++----
Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc | 175 ++++++++++++
Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl | 176 ++++++++----
Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc | 175 ++++++++++++
.../ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 177 ++++++++----
.../ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc | 184 +++++++++++++
.../ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 99 +++----
.../ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc | 172 ++++++++++++
21 files changed, 2156 insertions(+), 236 deletions(-)
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc


Pranav Madhu
 

Hi Sami,

Please find my comments inline:


Hi Pranav,

Comparing with the V2 series, I see that updates to the following files or
corresponding patches are missing in this series.

- RdV1Mc/Pptt.aslc
- RdN2/Pptt.aslc

Is this intentional?
No
RdN2: https://edk2.groups.io/g/devel/message/74924
RdV1Mc: https://edk2.groups.io/g/devel/message/74922


Regards,

Sami Mujawar

On 10/05/2021 09:06 PM, Pranav Madhu wrote:
Changes since V2:
- Introduced CPU container object into DSDT
- Addressed comments from Sami
<...>

Regards,
Pranav.


Sami Mujawar
 

Pushed as 67988fb53dbc..8549b1739183 with minor edits to doxygen comment style.

Thanks.

Regards,

Sami Mujawar

On 10/05/2021 09:06 PM, Pranav Madhu wrote:
Changes since V2:
- Introduced CPU container object into DSDT
- Addressed comments from Sami

Changes since V1:
- Rebase the patches on top of latest master branch
- Addressed comments from Pierre

Processor Properties Topology Table (PPTT) describes the topological
structure of processors, and their shared resources such as caches.
This patch series adds PPTT table for Arm's Neoverse Reference Design
platforms.

The first patch in this series adds helper macros for PPTT table, and
the subsequent patches in this series adds PPTT table for Neoverse
Reference Design platforms which is mandatory as per Arm SystemReady SR
specification.

Link to github branch with the patches in this series -
https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rd_pptt

Pranav Madhu (14):
Platform/Sgi: Helper macros for PPTT Table
Platform/Sgi: Add CPU container for SGI-575
Platform/Sgi: ACPI PPTT table for SGI-575 platform
Platform/Sgi: Add CPU container for RD-N1-Edge
Platform/Sgi: ACPI PPTT table for RD-N1-Edge platform
Platform/Sgi: Add DSDT ACPI table for RD-N1-Edge dual-chip platform
Platform/Sgi: ACPI PPTT table for RD-N1-Edge dual-chip
Platform/Sgi: ACPI PPTT table for RD-E1-Edge platform
Platform/Sgi: Add CPU container for RD-V1 platform
Platform/Sgi: ACPI PPTT Table for RD-V1 platform
Platform/Sgi: Add CPU container for RD-V1 quad-chip platform
Platform/Sgi: ACPI PPTT Table for RD-V1 quad-chip platform
Platform/Sgi: Add CPU container for RD-N2 platform
Platform/Sgi: ACPI PPTT table for RD-N2 platform

.../SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf | 3 +-
.../SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf | 3 +-
.../AcpiTables/RdN1EdgeX2AcpiTables.inf | 3 +-
.../ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 3 +-
.../ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf | 3 +-
.../SgiPkg/AcpiTables/RdV1McAcpiTables.inf | 1 +
.../SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 3 +-
Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 170 ++++++++++++
.../ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc | 252 ++++++++++++++++++
.../ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl | 88 +++---
.../ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc | 186 +++++++++++++
.../ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl | 136 ++++++++++
.../SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc | 207 ++++++++++++++
Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl | 176 ++++++++----
Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc | 175 ++++++++++++
Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl | 176 ++++++++----
Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc | 175 ++++++++++++
.../ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 177 ++++++++----
.../ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc | 184 +++++++++++++
.../ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 99 +++----
.../ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc | 172 ++++++++++++
21 files changed, 2156 insertions(+), 236 deletions(-)
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc