Date
1 - 2 of 2
[Patch v4 0/2] MdeModulePkg/Variable/RuntimeDxe: Restore Variable Lock Protocol behavior
|
Michael D Kinney
New in V4
========== * Fix spelling in unit tests * Call ValidateSetVariable() with DataSize=0, Attributes=0 New in V3 ========== * Split into 2 patches. One for code change. Second for unit tests. * Remove duplicate code and use ValidateSetVariable() to detect if a variable is already locked. https://bugzilla.tianocore.org/show_bug.cgi?id=3111 The VariableLock shim currently fails if called twice because the underlying Variable Policy engine returns an error if a policy is set on an existing variable. This breaks existing code which expect it to silently pass if a variable is locked multiple times (because it should "be locked"). Refactor the shim to confirm that the variable is indeed locked and then change the error to EFI_SUCCESS and generate a DEBUG_ERROR message so the duplicate lock can be reported in a debug log and removed. Add host based unit tests for the multiple lock case using Variable Lock Protocol, Variable Policy Protocol, and mixes of Variable Lock Protocol and Variable Policy Protocol. Cc: Michael D Kinney <michael.d.kinney@...> Cc: Hao A Wu <hao.a.wu@...> Cc: Liming Gao <gaoliming@...> Signed-off-by: Bret Barkelew <Bret.Barkelew@...> Bret Barkelew (1): MdeModulePkg/Variable/RuntimeDxe: Restore Variable Lock Protocol behavior Michael D Kinney (1): MdeModulePkg/Variable/RuntimeDxe: Add Variable Lock Protocol Unit Tests MdeModulePkg/Test/MdeModulePkgHostTest.dsc | 11 + .../VariableLockRequestToLockUnitTest.c | 565 ++++++++++++++++++ .../VariableLockRequestToLockUnitTest.inf | 36 ++ .../RuntimeDxe/VariableLockRequestToLock.c | 95 +-- 4 files changed, 671 insertions(+), 36 deletions(-) create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/RuntimeDxeUnitTest/VariableLockRequestToLockUnitTest.c create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/RuntimeDxeUnitTest/VariableLockRequestToLockUnitTest.inf -- 2.29.2.windows.2 |
|
|
|
Wu, Hao A
For the series:
toggle quoted message
Show quoted text
Reviewed-by: Hao A Wu <hao.a.wu@...> Best Regards, Hao Wu -----Original Message----- |
|
|