[RFC] Request for the new package "RedfishPkg" under edk2 repo


Abner Chang
 

Add [RFC] to the subject, add Ray and Mike to the loop.

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, September 8, 2020 12:06 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>
Subject: RE: Request for the new package "RedfishPkg" under edk2 repo

 

This is the RFC for the new package "RedfishPkg" introduced to edk2 repo, I thought mailing system will add [RFC] prefix to the subject. Sorry for the inconvenience.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Tuesday, September 8, 2020 11:48 AM
To: rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; devel@edk2.groups.io
Subject: [edk2-devel] Request for the new package "RedfishPkg" under edk2 repo

 

Hi everyone,

Given that we are going to contribute code of UEFI Redfish edk2 solution, a new package “RedfishPkg” under edk2 repo is necessary for accommodating the UEFI Redfish driver stacks, that includes

-          EFI Redfish Host Interface DXE Driver

-          EFI Refish Credential DXE Driver

-          EFI REST EX UEFI Driver for Redfish service

-          EFI Redfish Discover UEFI Driver

-          EFI Redfish Discover Protocol

-          EFI Redfish Config UEFI Driver

-          EFI BIOS Config To Redfish Dxe Driver

-          EFI REST JSON Structure DXE Driver

-          EFI Source Coding DXE Driver

-          EFI BIOS Resource Provision Generation Protocol

-          EFI BIOS Resource Provision Transport Layer Protocol

 

The architecture have been discussing in TianoCore Design meeting and the corresponding BZ were created as well.

The code we will start to contribute includes

-          Contribute to edk2 repo for those drivers already have the corresponding definitions in UEFI spec.

-          Contribute code to edk2-staging/UEFI _Redfish for those drivers do not have the corresponding definitions in UEFI spec. This is for the evaluation and require ECR to USWG if community agree with having this driver for Redfish edk2 solution.

 

Please refer to below link for the details, https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

 

Thanks

Abner


Abner Chang
 

Seems no one has comment on this topic. Let’s just go through the code review process.

Thanks

 

Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Wednesday, September 9, 2020 11:02 AM
To: devel@edk2.groups.io; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Michael D Kinney <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Add [RFC] to the subject, add Ray and Mike to the loop.

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, September 8, 2020 12:06 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>
Subject: RE: Request for the new package "RedfishPkg" under edk2 repo

 

This is the RFC for the new package "RedfishPkg" introduced to edk2 repo, I thought mailing system will add [RFC] prefix to the subject. Sorry for the inconvenience.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Tuesday, September 8, 2020 11:48 AM
To: rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; devel@edk2.groups.io
Subject: [edk2-devel] Request for the new package "RedfishPkg" under edk2 repo

 

Hi everyone,

Given that we are going to contribute code of UEFI Redfish edk2 solution, a new package “RedfishPkg” under edk2 repo is necessary for accommodating the UEFI Redfish driver stacks, that includes

-          EFI Redfish Host Interface DXE Driver

-          EFI Refish Credential DXE Driver

-          EFI REST EX UEFI Driver for Redfish service

-          EFI Redfish Discover UEFI Driver

-          EFI Redfish Discover Protocol

-          EFI Redfish Config UEFI Driver

-          EFI BIOS Config To Redfish Dxe Driver

-          EFI REST JSON Structure DXE Driver

-          EFI Source Coding DXE Driver

-          EFI BIOS Resource Provision Generation Protocol

-          EFI BIOS Resource Provision Transport Layer Protocol

 

The architecture have been discussing in TianoCore Design meeting and the corresponding BZ were created as well.

The code we will start to contribute includes

-          Contribute to edk2 repo for those drivers already have the corresponding definitions in UEFI spec.

-          Contribute code to edk2-staging/UEFI _Redfish for those drivers do not have the corresponding definitions in UEFI spec. This is for the evaluation and require ECR to USWG if community agree with having this driver for Redfish edk2 solution.

 

Please refer to below link for the details, https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

 

Thanks

Abner


Bret Barkelew
 

I think code review works. I’m primarily interested in seeing how much code falls under the “edk2” vs “edk2-staging” repos.

 

- Bret

 

From: Abner Chang via groups.io
Sent: Monday, September 14, 2020 8:12 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist); rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Kinney, Michael D
Subject: [EXTERNAL] Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Seems no one has comment on this topic. Let’s just go through the code review process.

Thanks

 

Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Wednesday, September 9, 2020 11:02 AM
To: devel@edk2.groups.io; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Michael D Kinney <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Add [RFC] to the subject, add Ray and Mike to the loop.

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, September 8, 2020 12:06 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>
Subject: RE: Request for the new package "RedfishPkg" under edk2 repo

 

This is the RFC for the new package "RedfishPkg" introduced to edk2 repo, I thought mailing system will add [RFC] prefix to the subject. Sorry for the inconvenience.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Tuesday, September 8, 2020 11:48 AM
To: rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; devel@edk2.groups.io
Subject: [edk2-devel] Request for the new package "RedfishPkg" under edk2 repo

 

Hi everyone,

Given that we are going to contribute code of UEFI Redfish edk2 solution, a new package “RedfishPkg” under edk2 repo is necessary for accommodating the UEFI Redfish driver stacks, that includes

  • EFI Redfish Host Interface DXE Driver
  • EFI Refish Credential DXE Driver
  • EFI REST EX UEFI Driver for Redfish service
  • EFI Redfish Discover UEFI Driver
  • EFI Redfish Discover Protocol
  • EFI Redfish Config UEFI Driver
  • EFI BIOS Config To Redfish Dxe Driver
  • EFI REST JSON Structure DXE Driver
  • EFI Source Coding DXE Driver
  • EFI BIOS Resource Provision Generation Protocol
  • EFI BIOS Resource Provision Transport Layer Protocol

 

The architecture have been discussing in TianoCore Design meeting and the corresponding BZ were created as well.

The code we will start to contribute includes

  • Contribute to edk2 repo for those drivers already have the corresponding definitions in UEFI spec.
  • Contribute code to edk2-staging/UEFI _Redfish for those drivers do not have the corresponding definitions in UEFI spec. This is for the evaluation and require ECR to USWG if community agree with having this driver for Redfish edk2 solution.

 

Please refer to below link for the details, https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

 

Thanks

Abner

 


Abner Chang
 

Not many drivers fall in edk2 repo so far, those are drivers with the corresponding definitions in UEFI spec.

-          EFI REST EX UEFI Driver for Redfish service

-          EFI Redfish Discover UEFI Driver

-          EFI REST JSON Structure DXE Driver

 

All others have to go through code first policy, will be in edk2-staging repo.

 

-Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Tuesday, September 15, 2020 11:19 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Kinney, Michael D <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

I think code review works. I’m primarily interested in seeing how much code falls under the “edk2” vs “edk2-staging” repos.

 

- Bret

 

From: Abner Chang via groups.io
Sent: Monday, September 14, 2020 8:12 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist); rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Kinney, Michael D
Subject: [EXTERNAL] Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Seems no one has comment on this topic. Let’s just go through the code review process.

Thanks

 

Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Wednesday, September 9, 2020 11:02 AM
To: devel@edk2.groups.io; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Michael D Kinney <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Add [RFC] to the subject, add Ray and Mike to the loop.

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, September 8, 2020 12:06 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>
Subject: RE: Request for the new package "RedfishPkg" under edk2 repo

 

This is the RFC for the new package "RedfishPkg" introduced to edk2 repo, I thought mailing system will add [RFC] prefix to the subject. Sorry for the inconvenience.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Tuesday, September 8, 2020 11:48 AM
To: rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; devel@edk2.groups.io
Subject: [edk2-devel] Request for the new package "RedfishPkg" under edk2 repo

 

Hi everyone,

Given that we are going to contribute code of UEFI Redfish edk2 solution, a new package “RedfishPkg” under edk2 repo is necessary for accommodating the UEFI Redfish driver stacks, that includes

-          EFI Redfish Host Interface DXE Driver

-          EFI Refish Credential DXE Driver

-          EFI REST EX UEFI Driver for Redfish service

-          EFI Redfish Discover UEFI Driver

-          EFI Redfish Discover Protocol

-          EFI Redfish Config UEFI Driver

-          EFI BIOS Config To Redfish Dxe Driver

-          EFI REST JSON Structure DXE Driver

-          EFI Source Coding DXE Driver

-          EFI BIOS Resource Provision Generation Protocol

-          EFI BIOS Resource Provision Transport Layer Protocol

 

The architecture have been discussing in TianoCore Design meeting and the corresponding BZ were created as well.

The code we will start to contribute includes

-          Contribute to edk2 repo for those drivers already have the corresponding definitions in UEFI spec.

-          Contribute code to edk2-staging/UEFI _Redfish for those drivers do not have the corresponding definitions in UEFI spec. This is for the evaluation and require ECR to USWG if community agree with having this driver for Redfish edk2 solution.

 

Please refer to below link for the details, https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

 

Thanks

Abner

 


Bret Barkelew
 

JSON Structure would probably be worth discussing. I know that there are other places I’ve seen JSON used and it may end up that we want common business logic (similar to using Oniguruma for regex). Do you parse/format JSON in that one?

 

- Bret

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Monday, September 14, 2020 8:33 PM
To: devel@edk2.groups.io; Bret Barkelew; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Kinney, Michael D
Subject: [EXTERNAL] RE: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Not many drivers fall in edk2 repo so far, those are drivers with the corresponding definitions in UEFI spec.

  • EFI REST EX UEFI Driver for Redfish service
  • EFI Redfish Discover UEFI Driver
  • EFI REST JSON Structure DXE Driver

 

All others have to go through code first policy, will be in edk2-staging repo.

 

-Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Tuesday, September 15, 2020 11:19 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Kinney, Michael D <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

I think code review works. I’m primarily interested in seeing how much code falls under the “edk2” vs “edk2-staging” repos.

 

- Bret

 

From: Abner Chang via groups.io
Sent: Monday, September 14, 2020 8:12 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist); rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Kinney, Michael D
Subject: [EXTERNAL] Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Seems no one has comment on this topic. Let’s just go through the code review process.

Thanks

 

Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Wednesday, September 9, 2020 11:02 AM
To: devel@edk2.groups.io; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Michael D Kinney <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Add [RFC] to the subject, add Ray and Mike to the loop.

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, September 8, 2020 12:06 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>
Subject: RE: Request for the new package "RedfishPkg" under edk2 repo

 

This is the RFC for the new package "RedfishPkg" introduced to edk2 repo, I thought mailing system will add [RFC] prefix to the subject. Sorry for the inconvenience.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Tuesday, September 8, 2020 11:48 AM
To: rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; devel@edk2.groups.io
Subject: [edk2-devel] Request for the new package "RedfishPkg" under edk2 repo

 

Hi everyone,

Given that we are going to contribute code of UEFI Redfish edk2 solution, a new package “RedfishPkg” under edk2 repo is necessary for accommodating the UEFI Redfish driver stacks, that includes

  • EFI Redfish Host Interface DXE Driver
  • EFI Refish Credential DXE Driver
  • EFI REST EX UEFI Driver for Redfish service
  • EFI Redfish Discover UEFI Driver
  • EFI Redfish Discover Protocol
  • EFI Redfish Config UEFI Driver
  • EFI BIOS Config To Redfish Dxe Driver
  • EFI REST JSON Structure DXE Driver
  • EFI Source Coding DXE Driver
  • EFI BIOS Resource Provision Generation Protocol
  • EFI BIOS Resource Provision Transport Layer Protocol

 

The architecture have been discussing in TianoCore Design meeting and the corresponding BZ were created as well.

The code we will start to contribute includes

  • Contribute to edk2 repo for those drivers already have the corresponding definitions in UEFI spec.
  • Contribute code to edk2-staging/UEFI _Redfish for those drivers do not have the corresponding definitions in UEFI spec. This is for the evaluation and require ECR to USWG if community agree with having this driver for Redfish edk2 solution.

 

Please refer to below link for the details, https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

 

Thanks

Abner

 

 


Abner Chang
 

No, EFI REST JSON Structure DXE Driver (UEF spec section 29.7.3) is a centralized manager to manage “EFI Redfish JSON resource to C structure Converter libraries/drivers”  for converting Redfish resource in the specific schema from JSON format to the C structure or vice versa.

EFI REST JSON Structure DXE Driver itself doesn’t use JSON library, however “EFI Redfish JSON resource to C structure Converter libraries/drivers” do use open source jansson library to parse JSON payload. Furthermore, “EFI Redfish JSON resource to C structure Converter libraries/drivers” are generated by tool based on the published Redfish schemas. https://github.com/DMTF/Redfish-Schema-C-Struct-Generator

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Tuesday, September 15, 2020 11:41 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; devel@edk2.groups.io; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Kinney, Michael D <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

JSON Structure would probably be worth discussing. I know that there are other places I’ve seen JSON used and it may end up that we want common business logic (similar to using Oniguruma for regex). Do you parse/format JSON in that one?

 

- Bret

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Monday, September 14, 2020 8:33 PM
To: devel@edk2.groups.io; Bret Barkelew; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Kinney, Michael D
Subject: [EXTERNAL] RE: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Not many drivers fall in edk2 repo so far, those are drivers with the corresponding definitions in UEFI spec.

-          EFI REST EX UEFI Driver for Redfish service

-          EFI Redfish Discover UEFI Driver

-          EFI REST JSON Structure DXE Driver

 

All others have to go through code first policy, will be in edk2-staging repo.

 

-Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Tuesday, September 15, 2020 11:19 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Kinney, Michael D <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

I think code review works. I’m primarily interested in seeing how much code falls under the “edk2” vs “edk2-staging” repos.

 

- Bret

 

From: Abner Chang via groups.io
Sent: Monday, September 14, 2020 8:12 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist); rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Kinney, Michael D
Subject: [EXTERNAL] Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Seems no one has comment on this topic. Let’s just go through the code review process.

Thanks

 

Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Wednesday, September 9, 2020 11:02 AM
To: devel@edk2.groups.io; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Michael D Kinney <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Add [RFC] to the subject, add Ray and Mike to the loop.

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, September 8, 2020 12:06 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>
Subject: RE: Request for the new package "RedfishPkg" under edk2 repo

 

This is the RFC for the new package "RedfishPkg" introduced to edk2 repo, I thought mailing system will add [RFC] prefix to the subject. Sorry for the inconvenience.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Tuesday, September 8, 2020 11:48 AM
To: rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; devel@edk2.groups.io
Subject: [edk2-devel] Request for the new package "RedfishPkg" under edk2 repo

 

Hi everyone,

Given that we are going to contribute code of UEFI Redfish edk2 solution, a new package “RedfishPkg” under edk2 repo is necessary for accommodating the UEFI Redfish driver stacks, that includes

-          EFI Redfish Host Interface DXE Driver

-          EFI Refish Credential DXE Driver

-          EFI REST EX UEFI Driver for Redfish service

-          EFI Redfish Discover UEFI Driver

-          EFI Redfish Discover Protocol

-          EFI Redfish Config UEFI Driver

-          EFI BIOS Config To Redfish Dxe Driver

-          EFI REST JSON Structure DXE Driver

-          EFI Source Coding DXE Driver

-          EFI BIOS Resource Provision Generation Protocol

-          EFI BIOS Resource Provision Transport Layer Protocol

 

The architecture have been discussing in TianoCore Design meeting and the corresponding BZ were created as well.

The code we will start to contribute includes

-          Contribute to edk2 repo for those drivers already have the corresponding definitions in UEFI spec.

-          Contribute code to edk2-staging/UEFI _Redfish for those drivers do not have the corresponding definitions in UEFI spec. This is for the evaluation and require ECR to USWG if community agree with having this driver for Redfish edk2 solution.

 

Please refer to below link for the details, https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

 

Thanks

Abner

 

 


Bret Barkelew
 

That link didn’t work for me.

 

- Bret

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Monday, September 14, 2020 8:59 PM
To: devel@edk2.groups.io; Bret Barkelew; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Kinney, Michael D
Subject: [EXTERNAL] RE: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

No, EFI REST JSON Structure DXE Driver (UEF spec section 29.7.3) is a centralized manager to manage “EFI Redfish JSON resource to C structure Converter libraries/drivers”  for converting Redfish resource in the specific schema from JSON format to the C structure or vice versa.

EFI REST JSON Structure DXE Driver itself doesn’t use JSON library, however “EFI Redfish JSON resource to C structure Converter libraries/drivers” do use open source jansson library to parse JSON payload. Furthermore, “EFI Redfish JSON resource to C structure Converter libraries/drivers” are generated by tool based on the published Redfish schemas. https://github.com/DMTF/Redfish-Schema-C-Struct-Generator

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Tuesday, September 15, 2020 11:41 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; devel@edk2.groups.io; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Kinney, Michael D <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

JSON Structure would probably be worth discussing. I know that there are other places I’ve seen JSON used and it may end up that we want common business logic (similar to using Oniguruma for regex). Do you parse/format JSON in that one?

 

- Bret

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Monday, September 14, 2020 8:33 PM
To: devel@edk2.groups.io; Bret Barkelew; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Kinney, Michael D
Subject: [EXTERNAL] RE: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Not many drivers fall in edk2 repo so far, those are drivers with the corresponding definitions in UEFI spec.

  • EFI REST EX UEFI Driver for Redfish service
  • EFI Redfish Discover UEFI Driver
  • EFI REST JSON Structure DXE Driver

 

All others have to go through code first policy, will be in edk2-staging repo.

 

-Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Tuesday, September 15, 2020 11:19 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Kinney, Michael D <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

I think code review works. I’m primarily interested in seeing how much code falls under the “edk2” vs “edk2-staging” repos.

 

- Bret

 

From: Abner Chang via groups.io
Sent: Monday, September 14, 2020 8:12 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist); rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Kinney, Michael D
Subject: [EXTERNAL] Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Seems no one has comment on this topic. Let’s just go through the code review process.

Thanks

 

Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Wednesday, September 9, 2020 11:02 AM
To: devel@edk2.groups.io; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Michael D Kinney <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Add [RFC] to the subject, add Ray and Mike to the loop.

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, September 8, 2020 12:06 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>
Subject: RE: Request for the new package "RedfishPkg" under edk2 repo

 

This is the RFC for the new package "RedfishPkg" introduced to edk2 repo, I thought mailing system will add [RFC] prefix to the subject. Sorry for the inconvenience.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Tuesday, September 8, 2020 11:48 AM
To: rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; devel@edk2.groups.io
Subject: [edk2-devel] Request for the new package "RedfishPkg" under edk2 repo

 

Hi everyone,

Given that we are going to contribute code of UEFI Redfish edk2 solution, a new package “RedfishPkg” under edk2 repo is necessary for accommodating the UEFI Redfish driver stacks, that includes

  • EFI Redfish Host Interface DXE Driver
  • EFI Refish Credential DXE Driver
  • EFI REST EX UEFI Driver for Redfish service
  • EFI Redfish Discover UEFI Driver
  • EFI Redfish Discover Protocol
  • EFI Redfish Config UEFI Driver
  • EFI BIOS Config To Redfish Dxe Driver
  • EFI REST JSON Structure DXE Driver
  • EFI Source Coding DXE Driver
  • EFI BIOS Resource Provision Generation Protocol
  • EFI BIOS Resource Provision Transport Layer Protocol

 

The architecture have been discussing in TianoCore Design meeting and the corresponding BZ were created as well.

The code we will start to contribute includes

  • Contribute to edk2 repo for those drivers already have the corresponding definitions in UEFI spec.
  • Contribute code to edk2-staging/UEFI _Redfish for those drivers do not have the corresponding definitions in UEFI spec. This is for the evaluation and require ECR to USWG if community agree with having this driver for Redfish edk2 solution.

 

Please refer to below link for the details, https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

 

Thanks

Abner

 

 

 


Felix Polyudov
 

Abner,

 

Are there RedFish dependencies in the REST EX Driver from your package?

If not, perhaps it should be in the NetworkPkg, not in the RedFishPkg.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Monday, September 14, 2020 11:12 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist); rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Michael D Kinney
Subject: [EXTERNAL] Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Seems no one has comment on this topic. Let’s just go through the code review process.

Thanks

 

Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Wednesday, September 9, 2020 11:02 AM
To: devel@edk2.groups.io; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Michael D Kinney <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Add [RFC] to the subject, add Ray and Mike to the loop.

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, September 8, 2020 12:06 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>
Subject: RE: Request for the new package "RedfishPkg" under edk2 repo

 

This is the RFC for the new package "RedfishPkg" introduced to edk2 repo, I thought mailing system will add [RFC] prefix to the subject. Sorry for the inconvenience.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Tuesday, September 8, 2020 11:48 AM
To: rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; devel@edk2.groups.io
Subject: [edk2-devel] Request for the new package "RedfishPkg" under edk2 repo

 

Hi everyone,

Given that we are going to contribute code of UEFI Redfish edk2 solution, a new package “RedfishPkg” under edk2 repo is necessary for accommodating the UEFI Redfish driver stacks, that includes

-          EFI Redfish Host Interface DXE Driver

-          EFI Refish Credential DXE Driver

-          EFI REST EX UEFI Driver for Redfish service

-          EFI Redfish Discover UEFI Driver

-          EFI Redfish Discover Protocol

-          EFI Redfish Config UEFI Driver

-          EFI BIOS Config To Redfish Dxe Driver

-          EFI REST JSON Structure DXE Driver

-          EFI Source Coding DXE Driver

-          EFI BIOS Resource Provision Generation Protocol

-          EFI BIOS Resource Provision Transport Layer Protocol

 

The architecture have been discussing in TianoCore Design meeting and the corresponding BZ were created as well.

The code we will start to contribute includes

-          Contribute to edk2 repo for those drivers already have the corresponding definitions in UEFI spec.

-          Contribute code to edk2-staging/UEFI _Redfish for those drivers do not have the corresponding definitions in UEFI spec. This is for the evaluation and require ECR to USWG if community agree with having this driver for Redfish edk2 solution.

 

Please refer to below link for the details, https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

 

Thanks

Abner

P Please consider the environment before printing this email

The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


Abner Chang
 

Hi Felix,

Yes, Redfish (EFI Redfish Discover Protocol) relies on the EFI REST EX protocol instance which provides EFI_REST_EX_SERVICE_REDFISH type service as defined in UEFI spec 29.7.2.2 GetService().

The REST EX Driver we will contribute is the REST EX Redfish instance, so that is the reason we put REST EX driver in RedfishPkg.

This makes sense to you?

 

Regards,

Abner

 

 

//*******************************************************

// EFI_REST_EX_SERVICE_TYPE

//*******************************************************

typedef enum {

EFI_REST_EX_SERVICE_UNSPECIFIC = 1,

   EFI_REST_EX_SERVICE_REDFISH,

   EFI_REST_EX_SERVICE_ODATA,

   EFI_REST_EX_SERVICE_VENDOR_SPECIFIC = 0xff,

   EFI_REST_EX_SERVICE_TYPE_MAX

} EFI_REST_EX_SERVICE_TYPE;

 

 

From: Felix Polyudov [mailto:Felixp@...]
Sent: Thursday, September 17, 2020 7:25 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Michael D Kinney <michael.d.kinney@...>; Igor Kulchytskyy <igork@...>
Subject: RE: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Abner,

 

Are there RedFish dependencies in the REST EX Driver from your package?

If not, perhaps it should be in the NetworkPkg, not in the RedFishPkg.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Monday, September 14, 2020 11:12 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist); rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Chen, Aaron; siyuan.fu@...; Wang, Fan; Wu, Jiaxin; Ni, Ray; Michael D Kinney
Subject: [EXTERNAL] Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Seems no one has comment on this topic. Let’s just go through the code review process.

Thanks

 

Abner

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Wednesday, September 9, 2020 11:02 AM
To: devel@edk2.groups.io; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; Ni, Ray <ray.ni@...>; Michael D Kinney <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Request for the new package "RedfishPkg" under edk2 repo

 

Add [RFC] to the subject, add Ray and Mike to the loop.

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, September 8, 2020 12:06 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>
Subject: RE: Request for the new package "RedfishPkg" under edk2 repo

 

This is the RFC for the new package "RedfishPkg" introduced to edk2 repo, I thought mailing system will add [RFC] prefix to the subject. Sorry for the inconvenience.

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Abner Chang
Sent: Tuesday, September 8, 2020 11:48 AM
To: rfc@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; Chen, Aaron <aaron.chen@...>; siyuan.fu@...; Wang, Fan <fan.wang@...>; Wu, Jiaxin <jiaxin.wu@...>; devel@edk2.groups.io
Subject: [edk2-devel] Request for the new package "RedfishPkg" under edk2 repo

 

Hi everyone,

Given that we are going to contribute code of UEFI Redfish edk2 solution, a new package “RedfishPkg” under edk2 repo is necessary for accommodating the UEFI Redfish driver stacks, that includes

-          EFI Redfish Host Interface DXE Driver

-          EFI Refish Credential DXE Driver

-          EFI REST EX UEFI Driver for Redfish service

-          EFI Redfish Discover UEFI Driver

-          EFI Redfish Discover Protocol

-          EFI Redfish Config UEFI Driver

-          EFI BIOS Config To Redfish Dxe Driver

-          EFI REST JSON Structure DXE Driver

-          EFI Source Coding DXE Driver

-          EFI BIOS Resource Provision Generation Protocol

-          EFI BIOS Resource Provision Transport Layer Protocol

 

The architecture have been discussing in TianoCore Design meeting and the corresponding BZ were created as well.

The code we will start to contribute includes

-          Contribute to edk2 repo for those drivers already have the corresponding definitions in UEFI spec.

-          Contribute code to edk2-staging/UEFI _Redfish for those drivers do not have the corresponding definitions in UEFI spec. This is for the evaluation and require ECR to USWG if community agree with having this driver for Redfish edk2 solution.

 

Please refer to below link for the details, https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

 

Thanks

Abner

P Please consider the environment before printing this email

The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.