Hi Liming,

On 08/24/20 03:49, gaoliming wrote:

Hi, all

Based on the discussion https://edk2.groups.io/g/devel/message/64493,
we make the conclusion to defer one week for edk2-stable202008 to
include the important patch for RiscV. Soft Feature Freeze (SFF) will
start from today (2020-08-24). Below is new edk2-stable202008 tag
planning proposed schedule
<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning>.
If you have any comments, please raise it.


Date (00:00:00 UTC-8) Description
2020-06-03 Beginning of development
2020-08-07 Feature Planning Freeze
2020-08-24 Soft Feature Freeze
2020-08-28 Hard Feature Freeze
2020-09-04 Release

Because SFF date is changed, if the patches passed code review before
SFF date (2020-08-24), the patches can still be merged for this stable
tag. Here is the patch list those passed code review before new SFF
date. For below features, I will let the feature owner decides whether
to merge it for this stable tag.

As of this writing:

- Mon Aug 24 12:59:59 UTC 2020

we've entered the (new) Soft Feature Freeze. (The SFF date is 2020-08-24
00:00:00 UTC-8; in UTC, that's Mon Aug 24 08:00:00 UTC 2020 -- about
five hours ago.)

So:

Feature List:

https://edk2.groups.io/g/devel/message/63767
[PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp

I'm going to merge this soon (with Leif's review).

https://edk2.groups.io/g/devel/message/64363
[PATCH v5 0/3] UefiPayloadPkg: Runtime MMCONF

The UefiPayloadPkg patches in the series (#1, #3) have not received
reviews. We have to delay this until after the stable tag.

https://edk2.groups.io/g/devel/message/64354
[PATCH v4 0/8] Need add a FSP binary measurement

The SecurityPkg patches have not been approved yet, and Bret and Jiewen
are still testing / discussing (as far as I understand):
<https://edk2.groups.io/g/devel/message/64526>. Material for the next
tag.


On the other hand, I'm going to push two patches that had been reviewed
just before we entered the *delayed* SFF:

https://edk2.groups.io/g/devel/message/64345
[PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix

https://edk2.groups.io/g/devel/message/62561
[PATCH] OvmfPkg/SmmControl2Dxe: negotiate ICH9_LPC_SMI_F_CPU_HOTPLUG

Bug List:

https://edk2.groups.io/g/devel/message/50406
[PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h

Liming, can you please merge this patch? For some reason I can't see it
in my local archives! (Only responses to it.)

https://edk2.groups.io/g/devel/message/64507
[PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable

I'm going to merge this soon.

https://edk2.groups.io/g/devel/message/64539
[PATCH] Maintainers.txt: Update Liming mail address

I'll merge this one as well.

https://edk2.groups.io/g/devel/message/64529
[PATCH] .pytool/EccCheck: Disable Ecc error code 10014 for open CI

Already merged as commit d4e0b9607c9a.

https://edk2.groups.io/g/devel/message/61938
[PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

I'll merge it.

Thanks!
Laszlo

To clarify below:
I just notice this one week delay. It impacts us.

https://edk2.groups.io/g/devel/message/64354
[PATCH v4 0/8] Need add a FSP binary measurement

The SecurityPkg patches have not been approved yet, and Bret and Jiewen
are still testing / discussing (as far as I understand):
<https://edk2.groups.io/g/devel/message/64526>. Material for the next
tag.

[Jiewen] I think the security pkg is already approved by me and Jian (SecurityPkg maintainer)
Bret also provides feedback that it looks good.

I request to check in to stable202008, if possible.


Thank you
Yao Jiewen

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
Sent: Monday, August 24, 2020 9:38 PM
To: gaoliming <gaoliming@...>; 'Leif Lindholm'
<leif@...>; afish@...; Kinney, Michael D
<michael.d.kinney@...>; Guptha, Soumya K
<soumya.k.guptha@...>
Cc: devel@edk2.groups.io; announce@edk2.groups.io; 'Chang, Abner (HPS
SW/FW Technologist)' <abner.chang@...>; Zhang, Qi1
<qi1.zhang@...>; marcello.bauer@...
Subject: Re: [edk2-devel] Soft Feature Freeze start date delays to 2020-08-24 for
edk2-stable202008

Hi Liming,

On 08/24/20 03:49, gaoliming wrote:

Hi, all

Based on the discussion https://edk2.groups.io/g/devel/message/64493,
we make the conclusion to defer one week for edk2-stable202008 to
include the important patch for RiscV. Soft Feature Freeze (SFF) will
start from today (2020-08-24). Below is new edk2-stable202008 tag
planning proposed schedule
<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-

Planning>.

If you have any comments, please raise it.


Date (00:00:00 UTC-8) Description
2020-06-03 Beginning of development
2020-08-07 Feature Planning Freeze
2020-08-24 Soft Feature Freeze
2020-08-28 Hard Feature Freeze
2020-09-04 Release

Because SFF date is changed, if the patches passed code review before
SFF date (2020-08-24), the patches can still be merged for this stable
tag. Here is the patch list those passed code review before new SFF
date. For below features, I will let the feature owner decides whether
to merge it for this stable tag.

As of this writing:

- Mon Aug 24 12:59:59 UTC 2020

we've entered the (new) Soft Feature Freeze. (The SFF date is 2020-08-24
00:00:00 UTC-8; in UTC, that's Mon Aug 24 08:00:00 UTC 2020 -- about
five hours ago.)

So:

Feature List:

https://edk2.groups.io/g/devel/message/63767
[PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp

I'm going to merge this soon (with Leif's review).

https://edk2.groups.io/g/devel/message/64363
[PATCH v5 0/3] UefiPayloadPkg: Runtime MMCONF

The UefiPayloadPkg patches in the series (#1, #3) have not received
reviews. We have to delay this until after the stable tag.

https://edk2.groups.io/g/devel/message/64354
[PATCH v4 0/8] Need add a FSP binary measurement

The SecurityPkg patches have not been approved yet, and Bret and Jiewen
are still testing / discussing (as far as I understand):
<https://edk2.groups.io/g/devel/message/64526>. Material for the next
tag.


On the other hand, I'm going to push two patches that had been reviewed
just before we entered the *delayed* SFF:

https://edk2.groups.io/g/devel/message/64345
[PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix

https://edk2.groups.io/g/devel/message/62561
[PATCH] OvmfPkg/SmmControl2Dxe: negotiate
ICH9_LPC_SMI_F_CPU_HOTPLUG

Bug List:

https://edk2.groups.io/g/devel/message/50406
[PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in

SmBios.h

Liming, can you please merge this patch? For some reason I can't see it
in my local archives! (Only responses to it.)

https://edk2.groups.io/g/devel/message/64507
[PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement

variable

I'm going to merge this soon.

https://edk2.groups.io/g/devel/message/64539
[PATCH] Maintainers.txt: Update Liming mail address

I'll merge this one as well.

https://edk2.groups.io/g/devel/message/64529
[PATCH] .pytool/EccCheck: Disable Ecc error code 10014 for open CI

Already merged as commit d4e0b9607c9a.

https://edk2.groups.io/g/devel/message/61938
[PATCH v2 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in

FileHandleReadLine()

I'll merge it.

Thanks!
Laszlo

Hi Jiewen,

On 08/26/20 03:19, Yao, Jiewen wrote:

To clarify below:
I just notice this one week delay. It impacts us.

https://edk2.groups.io/g/devel/message/64354
[PATCH v4 0/8] Need add a FSP binary measurement

The SecurityPkg patches have not been approved yet, and Bret and
Jiewen are still testing / discussing (as far as I understand):
<https://edk2.groups.io/g/devel/message/64526>. Material for the next
tag.

[Jiewen] I think the security pkg is already approved by me and Jian
(SecurityPkg maintainer) Bret also provides feedback that it looks
good.

The series in question has three SecurityPkg patches:

[PATCH v4 1/8] SecurityPkg/TcgEventLogRecordLib: add new lib for firmware measurement
[PATCH v4 5/8] SecurityPkg/dsc: add FvEventLogRecordLib
[PATCH v4 7/8] SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY

As I'm writing this, *none* of the listed patches have any kind of
Reviewed-by or Acked-by, either included in the patches themselves, or
posted in response to them.

I request to check in to stable202008, if possible.

We can do that only if (a) we extend the SFF deadline again, and (b)
each of the SecurityPkg patches receives at least an Acked-by from one
of the SecurityPkg maintainers, until the new deadline.

I'm certainly not against the idea. I don't mind if the release slips
some more; it's OK to say that we're not ready to release yet. The point
is, as long as we're doing more work for completing the release, we
should prolong the stabilization period as well (opportunity for people
to test).

Thanks,
Laszlo

HI Laszlo
I checked the history.

Jiewen replied " [PATCH v3 0/8] Need add a FSP binary measurement" with review-by on V3 patch series in August 15, with comment to rename FvEventLogRecordLib to TcgEventLogRecordLib.
Qi sent v4 series in August 17, with only naming change from FvEventLogRecordLib to TcgEventLogRecordLib.
Jian replied "[PATCH v3 0/8] Need add a FSP binary measurement" with reviewed-by on V3 patch series in August 18.

So I treat this patch series is qualified to check in (since V4 adopted my comment). But please let me know if there is any misunderstanding.


When I am about to merge, I am told that we are in SFF and I cannot check in.
According to the plan, I will check in after August 28, which is end of August. It is still OK for me.
2020-08-14 Soft Feature Freeze
2020-08-21 Hard Feature Freeze
2020-08-28 Release

But now, if we need delay one week, then the final release data will be September. If I cannot check in now, I will have to check in at September.
That is why I said, it impacts me, because of this one week delay.

Thank you
Yao Jiewen

On 08/26/20 12:16, Yao, Jiewen wrote:

HI Laszlo
I checked the history.

Jiewen replied " [PATCH v3 0/8] Need add a FSP binary measurement" with review-by on V3 patch series in August 15, with comment to rename FvEventLogRecordLib to TcgEventLogRecordLib.

You are correct:

https://edk2.groups.io/g/devel/message/64299

I have two comments on this.

First, because you authored the IntelFsp2WrapperPkg patches in the
series, you cannot R-b them (you cannot R-b your own patches, even if
they are resent by someone else). However, that's not necessary: the
IntelFsp2WrapperPkg is maintained by Chasel Chiu, and Chasel did review
those patches, under v4, in the end.

Second, the v4 submitter, Qi Zhang, should have picked up your R-b from
under v3, and included them in the v4 posting. (Assuming the v3->v4
changes were exactly as you requested, under v3.)

Qi sent v4 series in August 17, with only naming change from FvEventLogRecordLib to TcgEventLogRecordLib.

OK. In this case, Qi should have posted the v4 SecurityPkg patches with
your R-b *already* present.

Jian replied "[PATCH v3 0/8] Need add a FSP binary measurement" with reviewed-by on V3 patch series in August 18.

That's correct too:

https://edk2.groups.io/g/devel/message/64342

This means that Qi should have sent v4 with Jian's R-b on *every* patch.

So I treat this patch series is qualified to check in (since V4 adopted my comment). But please let me know if there is any misunderstanding.

No, you are entirely correct. I was misled because v4 was not posted
correctly, with regard to the feedback tags given under v3.

So, what remains to do now is this: until the HFF (2020-08-28) we can,
and should, merge v4 of the series. As follows:

- apply Jian's R-b from under v3 to every patch in the series

- apply your R-b from under v3 to the patches you did *not* author (that
is, apply the tag to the SecurityPkg patches, plus to
"IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib")

- apply Chasel Chiu's R-b from under v4 to the IntelFsp2WrapperPkg patches.

This will make the series fully reviewed, and mergeable.

Note that Chasel requested a copyright year update when pushing, here:
<https://edk2.groups.io/g/devel/message/64382>. Given that Chasel
(maintainer/reviewer), Jiewen (original author) and Qi (poster) all work
for Intel, and the (C) notice in question is Intel's, I think that *any*
maintainer can satisfy Chasel's request, when merging the series.

So, I think I'll go ahead and merge v4. Thank you for the v3 pointers.

When I am about to merge, I am told that we are in SFF and I cannot check in.
According to the plan, I will check in after August 28, which is end of August. It is still OK for me.
2020-08-14 Soft Feature Freeze
2020-08-21 Hard Feature Freeze
2020-08-28 Release

But now, if we need delay one week, then the final release data will be September. If I cannot check in now, I will have to check in at September.
That is why I said, it impacts me, because of this one week delay.

I'm going to merge the series for you, given the amount of work needed
for collecting the feedback tags.

Thanks!
Laszlo

Thank you very much, Laszlo and Liming!

Thank you
Yao Jiewen