Date
1 - 6 of 6
[PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg
|
Sami Mujawar
The TianoCore EDKII project has introduced a Core CI infrastructure
using TianoCore EDKII Tools PIP modules. The v2 patch series at https://edk2.groups.io/g/devel/message/63259 adds support for building DynamicTablesPkg using the EKDII Core CI. Splitting the v2 patch series into 2 separate series. This v4 series contains the patches for enabling Core CI for DynamicTablesPkg in .pytools and .azurepipelines i.e. the last two patches from the v2 series. The v3 series containing the patches for DynamicTablesPkg has already been merged in edk2 master at: - https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d848c7716adefe - https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00e185069667d Ref (v3 series): https://edk2.groups.io/g/devel/topic/patch_v3_0_2_add_edkii_ci/76052351 There is no code change other than splitting the v2 series. The changes for this v4 series can be seen at: https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v4 Sami Mujawar (2): .pytool: CI Settings to support DynamicTablesPkg .azurepipelines: Add DynamicTablesPkg to CI matrix .azurepipelines/templates/pr-gate-build-job.yml | 3 ++- .pytool/CISettings.py | 2 ++ .pytool/Readme.md | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' |
|
|
|
Sami Mujawar
Hi All,
toggle quoted message
Show quoted text
Is there anything else needed before this patch series can be merged? If possible, we would like this feature enabled in the edk2-stable202008. Regards, Sami Mujawar -----Original Message-----
From: Sami Mujawar <sami.mujawar@...> Sent: 07 August 2020 06:30 PM To: devel@edk2.groups.io Cc: Sami Mujawar <Sami.Mujawar@...>; Alexei Fedorov <Alexei.Fedorov@...>; sean.brogan@...; liming.gao@...; michael.d.kinney@...; Bret.Barkelew@...; Ard Biesheuvel <Ard.Biesheuvel@...>; Matteo Carlini <Matteo.Carlini@...>; Laura Moretta <Laura.Moretta@...>; nd <nd@...> Subject: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules. The v2 patch series at https://edk2.groups.io/g/devel/message/63259 adds support for building DynamicTablesPkg using the EKDII Core CI. Splitting the v2 patch series into 2 separate series. This v4 series contains the patches for enabling Core CI for DynamicTablesPkg in .pytools and .azurepipelines i.e. the last two patches from the v2 series. The v3 series containing the patches for DynamicTablesPkg has already been merged in edk2 master at: - https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d848c7716adefe - https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00e185069667d Ref (v3 series): https://edk2.groups.io/g/devel/topic/patch_v3_0_2_add_edkii_ci/76052351 There is no code change other than splitting the v2 series. The changes for this v4 series can be seen at: https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v4 Sami Mujawar (2): .pytool: CI Settings to support DynamicTablesPkg .azurepipelines: Add DynamicTablesPkg to CI matrix .azurepipelines/templates/pr-gate-build-job.yml | 3 ++- .pytool/CISettings.py | 2 ++ .pytool/Readme.md | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' |
|
|
|
Liming Gao
Sami:
toggle quoted message
Show quoted text
I think this change is OK. And, Shenglei and Alexei gave reviewed-by before soft feature freeze. Mike, Leif, Andrew and Laszlo: Have you any comments to merge this patch to edk2-stable202008 stable tag. Thanks Liming -----Original Message-----
From: Sami Mujawar <Sami.Mujawar@...> Sent: 2020年8月14日 21:24 To: Gao, Liming <liming.gao@...>; devel@edk2.groups.io; Bret.Barkelew@...; sean.brogan@...; Kinney, Michael D <michael.d.kinney@...> Cc: Alexei Fedorov <Alexei.Fedorov@...>; Sami Mujawar <Sami.Mujawar@...>; Ard Biesheuvel <Ard.Biesheuvel@...>; Matteo Carlini <Matteo.Carlini@...>; Ben Adderson <Ben.Adderson@...>; nd <nd@...> Subject: RE: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg Hi All, Is there anything else needed before this patch series can be merged? If possible, we would like this feature enabled in the edk2-stable202008. Regards, Sami Mujawar -----Original Message----- From: Sami Mujawar <sami.mujawar@...> Sent: 07 August 2020 06:30 PM To: devel@edk2.groups.io Cc: Sami Mujawar <Sami.Mujawar@...>; Alexei Fedorov <Alexei.Fedorov@...>; sean.brogan@...; liming.gao@...; michael.d.kinney@...; Bret.Barkelew@...; Ard Biesheuvel <Ard.Biesheuvel@...>; Matteo Carlini <Matteo.Carlini@...>; Laura Moretta <Laura.Moretta@...>; nd <nd@...> Subject: [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules. The v2 patch series at https://edk2.groups.io/g/devel/message/63259 adds support for building DynamicTablesPkg using the EKDII Core CI. Splitting the v2 patch series into 2 separate series. This v4 series contains the patches for enabling Core CI for DynamicTablesPkg in .pytools and .azurepipelines i.e. the last two patches from the v2 series. The v3 series containing the patches for DynamicTablesPkg has already been merged in edk2 master at: - https://github.com/tianocore/edk2/commit/2d0c42fdf2cf1855b0a042ef82d848c7716adefe - https://github.com/tianocore/edk2/commit/e3f8605a23ebe9c54ae2b17819d00e185069667d Ref (v3 series): https://edk2.groups.io/g/devel/topic/patch_v3_0_2_add_edkii_ci/76052351 There is no code change other than splitting the v2 series. The changes for this v4 series can be seen at: https://github.com/samimujawar/edk2/tree/839_dynamictablespkg_ci_v4 Sami Mujawar (2): .pytool: CI Settings to support DynamicTablesPkg .azurepipelines: Add DynamicTablesPkg to CI matrix .azurepipelines/templates/pr-gate-build-job.yml | 3 ++- .pytool/CISettings.py | 2 ++ .pytool/Readme.md | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' |
|
|
|
Laszlo Ersek
On 08/17/20 08:37, Gao, Liming wrote:
Sami:I'm OK with merging this series now. Thanks Laszlo -----Original Message----- |
|
|
|
Leif Lindholm
No objections from me.
toggle quoted message
Show quoted text
On Mon, Aug 17, 2020 at 06:37:02 +0000, Gao, Liming wrote:
Sami: |
|
|
|
Liming Gao
Merged a048af3c9073e4b8108e6cf920bbb35574059639..5a6d764e1d073d28e8f398289ccb5592bf9a72ba
toggle quoted message
Show quoted text
Thanks Liming -----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif Lindholm Sent: 2020年8月18日 19:34 To: Gao, Liming <liming.gao@...> Cc: Sami Mujawar <Sami.Mujawar@...>; devel@edk2.groups.io; Bret.Barkelew@...; sean.brogan@...; Kinney, Michael D <michael.d.kinney@...>; afish@...; Laszlo Ersek <lersek@...>; Alexei Fedorov <Alexei.Fedorov@...>; Ard Biesheuvel <Ard.Biesheuvel@...>; Matteo Carlini <Matteo.Carlini@...>; Ben Adderson <Ben.Adderson@...>; nd <nd@...> Subject: Re: [edk2-devel] [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg No objections from me. On Mon, Aug 17, 2020 at 06:37:02 +0000, Gao, Liming wrote: Sami: |
|
|