Date
1 - 5 of 5
[PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.
|
Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2788
DSC is incomplete according to the established CI policies. Fsp22SecCoreS.inf needs to be added to the Components section for completeness. Cc: Maurice Ma <maurice.ma@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Star Zeng <star.zeng@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- IntelFsp2Pkg/IntelFsp2Pkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dsc b/IntelFsp2Pkg/IntelFsp2Pkg.dsc index 02fe9cb188..9b5e38c5d9 100644 --- a/IntelFsp2Pkg/IntelFsp2Pkg.dsc +++ b/IntelFsp2Pkg/IntelFsp2Pkg.dsc @@ -1,7 +1,7 @@ ## @file # Provides driver and definitions to build fsp. # -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2014 - 2022, Intel Corporation. All rights reserved.<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -65,6 +65,7 @@ IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf + IntelFsp2Pkg/FspSecCore/Fsp22SecCoreS.inf IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf [PcdsFixedAtBuild.common] -- 2.13.3.windows.1
|
|
|
|
Sean
I think your copyright year is off. 2022?
toggle quoted messageShow quoted text
After you fix that Reviewed-by: Sean Brogan <sean.brogan@microsoft.com> Also since you are the package maintainer of this package what do you think about enabling Core CI? We do this already in Project Mu which is how this missing entry was identified. https://github.com/microsoft/mu_silicon_intel_tiano/blob/release/202002/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml Thanks Sean
On 6/9/2020 7:33 PM, Chiu, Chasel wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2788
|
|
|
|
Chiu, Chasel
Thanks Sean and I will correct the copyright typo.
toggle quoted messageShow quoted text
We will evaluate Core CI enabling.
-----Original Message-----
|
|
|
|
Please fix copyright year. With that change...
toggle quoted messageShow quoted text
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Chiu, Chasel <chasel.chiu@intel.com> Sent: Tuesday, June 9, 2020 7:33 PM To: devel@edk2.groups.io Cc: Ma, Maurice <maurice.ma@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com> Subject: [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2788 DSC is incomplete according to the established CI policies. Fsp22SecCoreS.inf needs to be added to the Components section for completeness. Cc: Maurice Ma <maurice.ma@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Star Zeng <star.zeng@intel.com> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com> --- IntelFsp2Pkg/IntelFsp2Pkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dsc b/IntelFsp2Pkg/IntelFsp2Pkg.dsc index 02fe9cb188..9b5e38c5d9 100644 --- a/IntelFsp2Pkg/IntelFsp2Pkg.dsc +++ b/IntelFsp2Pkg/IntelFsp2Pkg.dsc @@ -1,7 +1,7 @@ ## @file # Provides driver and definitions to build fsp. # -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2014 - 2022, Intel Corporation. All rights +reserved.<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -65,6 +65,7 @@ IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf + IntelFsp2Pkg/FspSecCore/Fsp22SecCoreS.inf IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf [PcdsFixedAtBuild.common] -- 2.13.3.windows.1
|
|
|
|
Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com> with the copyright year correction.
toggle quoted messageShow quoted text
-----Original Message-----
|
|
|