[PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Change PcdHashApiLibPolicy type to FixedAtBuild


Sukerkar, Amol N
 

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2511

This commit changes the PCD PcdHashApiLibPolicy to the type
PcdsFixedAtBuild so as to be able to optimize away the unused hashing
algorithms in HashApiLib instance used by a driver.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Amol N Sukerkar <amol.n.sukerkar@intel.com>
---

Notes:
v2
- Fixed closed parantheses in the commit message

CryptoPkg/CryptoPkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CryptoPkg/CryptoPkg.dec b/CryptoPkg/CryptoPkg.dec
index f185bcc82515..c23af7b87d25 100644
--- a/CryptoPkg/CryptoPkg.dec
+++ b/CryptoPkg/CryptoPkg.dec
@@ -69,7 +69,7 @@ [PcdsFixedAtBuild]
Pcd/PcdCryptoServiceFamilyEnable.h
}

-[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
+[PcdsFixedAtBuild]
## This PCD indicates the HASH algorithm to calculate hash of data
# Based on the value set, the required algorithm is chosen to calculate
# the hash of data.<BR>
--
2.16.2.windows.1


Michael D Kinney
 

Amol,

Comments included below.

Mike

-----Original Message-----
From: Sukerkar, Amol N <amol.n.sukerkar@intel.com>
Sent: Friday, February 14, 2020 10:06 AM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
<jian.j.wang@intel.com>; Agrawal, Sachin
<sachin.agrawal@intel.com>; Gao, Liming
<liming.gao@intel.com>
Subject: [PATCH v2 2/2] CryptoPkg/BaseHashApiLib:
Change PcdHashApiLibPolicy type to FixedAtBuild

Ref:
https://bugzilla.tianocore.org/show_bug.cgi?id=2511

This commit changes the PCD PcdHashApiLibPolicy to the
type
PcdsFixedAtBuild so as to be able to optimize away the
unused hashing
algorithms in HashApiLib instance used by a driver.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Amol N Sukerkar
<amol.n.sukerkar@intel.com>
---

Notes:
v2
- Fixed closed parantheses in the commit message

CryptoPkg/CryptoPkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CryptoPkg/CryptoPkg.dec
b/CryptoPkg/CryptoPkg.dec
index f185bcc82515..c23af7b87d25 100644
--- a/CryptoPkg/CryptoPkg.dec
+++ b/CryptoPkg/CryptoPkg.dec
@@ -69,7 +69,7 @@ [PcdsFixedAtBuild]
Pcd/PcdCryptoServiceFamilyEnable.h
}

-[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic,
PcdsDynamicEx]
+[PcdsFixedAtBuild]
This line can be removed. The PCD above is already in a
[PcdsFixedAtBuild] section.

## This PCD indicates the HASH algorithm to
calculate hash of data
# Based on the value set, the required algorithm is
chosen to calculate
# the hash of data.<BR>
--
2.16.2.windows.1