[edk2-platforms] [PATCH v2 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform


Vijayenthiran Subramaniam
 

Changes since v1:
- Fix typo which caused build error

This patch series adds support for RD-N1-Edge platform with multi-chip
capability. The first patch in this series is an improvement to SgiPkg to avoid
any usage of deprecated APIs. The second patch refactors the existing code to
use lookup table in order to identify the platform. The rest of the patch adds
multi-chip support for the RD-N1-Edge platform.

Vijayenthiran Subramaniam (5):
Platform/ARM/SgiPkg: Disable use of deprecated APIs
Platform/ARM/SgiPkg: Use lookup table to install ACPI table
Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor
Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform
Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform

Platform/ARM/SgiPkg/SgiPlatform.dec | 1 +
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 +
Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +
Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 +
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 59 ++++++
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 +
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 61 +++++-
Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 8 +
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 198 ++++++++++++++++++++
10 files changed, 333 insertions(+), 10 deletions(-)
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc

--
2.7.4


Leif Lindholm
 

On the whole, looks good.
If you can resubmit v3 versions of patches 2-3 only based on feedback,
that would suffice.

On a separate note:
Could someone in ARM take an action item to go and figure out who
should be default reviewer for the various ARM ltd platforms (virtual
or not), and submit a patch to Maintainers.txt adding some R:?

Best Regards,

Leif

On Wed, Feb 12, 2020 at 18:59:22 +0530, Vijayenthiran Subramaniam wrote:
Changes since v1:
- Fix typo which caused build error

This patch series adds support for RD-N1-Edge platform with multi-chip
capability. The first patch in this series is an improvement to SgiPkg to avoid
any usage of deprecated APIs. The second patch refactors the existing code to
use lookup table in order to identify the platform. The rest of the patch adds
multi-chip support for the RD-N1-Edge platform.

Vijayenthiran Subramaniam (5):
Platform/ARM/SgiPkg: Disable use of deprecated APIs
Platform/ARM/SgiPkg: Use lookup table to install ACPI table
Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor
Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform
Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform

Platform/ARM/SgiPkg/SgiPlatform.dec | 1 +
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 +
Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +
Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 +
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 59 ++++++
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 +
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 61 +++++-
Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 8 +
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 198 ++++++++++++++++++++
10 files changed, 333 insertions(+), 10 deletions(-)
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc

--
2.7.4


Vijayenthiran Subramaniam
 

Hi Leif,

On Thu, Feb 13, 2020 at 5:31 PM Leif Lindholm <leif@nuviainc.com> wrote:

On the whole, looks good.
If you can resubmit v3 versions of patches 2-3 only based on feedback,
that would suffice.
Thanks for reviewing. I have sent out v3 retaining R-b in all patch
except in patch 2. There's no change in patch 3 except i to Idx.


On a separate note:
Could someone in ARM take an action item to go and figure out who
should be default reviewer for the various ARM ltd platforms (virtual
or not), and submit a patch to Maintainers.txt adding some R:?

Best Regards,

Leif

On Wed, Feb 12, 2020 at 18:59:22 +0530, Vijayenthiran Subramaniam wrote:
Changes since v1:
- Fix typo which caused build error

This patch series adds support for RD-N1-Edge platform with multi-chip
capability. The first patch in this series is an improvement to SgiPkg to avoid
any usage of deprecated APIs. The second patch refactors the existing code to
use lookup table in order to identify the platform. The rest of the patch adds
multi-chip support for the RD-N1-Edge platform.

Vijayenthiran Subramaniam (5):
Platform/ARM/SgiPkg: Disable use of deprecated APIs
Platform/ARM/SgiPkg: Use lookup table to install ACPI table
Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor
Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform
Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform

Platform/ARM/SgiPkg/SgiPlatform.dec | 1 +
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 +
Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +
Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 +
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 59 ++++++
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 +
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 61 +++++-
Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 8 +
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 198 ++++++++++++++++++++
10 files changed, 333 insertions(+), 10 deletions(-)
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc

--
2.7.4
Regards,
Vijayenthiran