|
[PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.
Yes, you are right. Tested on the H/W, It clears the upper 32bits. 😊
|
Yes, you are right. Tested on the H/W, It clears the upper 32bits. 😊
|
By
Ashraf Ali S
· #101369
·
|
|
[PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.
Hi., Nope, it will not clear the upper 32bit right.
|
Hi., Nope, it will not clear the upper 32bit right.
|
By
Ashraf Ali S
· #101367
·
|
|
[PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.
Hi., Chasel RAX holds the FsptImageBaseAddress, the AND operation is performed to clear the upper 32bits of RAX registers. Don't we have to clear the upper 32bit of RAX registers?
|
Hi., Chasel RAX holds the FsptImageBaseAddress, the AND operation is performed to clear the upper 32bits of RAX registers. Don't we have to clear the upper 32bit of RAX registers?
|
By
Ashraf Ali S
· #101363
·
|
|
[PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning
Function defination should match with declaration. [-Wlto-type-mismatch] Cc: Chasel Chiu <chasel.chiu@...> Cc: Nate DeSimone <nathaniel.l.desimone@...> Cc: Sai Chaganty <rangasai.v.chagant
|
Function defination should match with declaration. [-Wlto-type-mismatch] Cc: Chasel Chiu <chasel.chiu@...> Cc: Nate DeSimone <nathaniel.l.desimone@...> Cc: Sai Chaganty <rangasai.v.chagant
|
By
Ashraf Ali S
· #100957
·
|
|
[edk2-platforms: PATCH v2] IntelSiliconPkg/SpiFvbServiceSmm: Rewrite VariableStore header.
Reviewed-by: S, Ashraf Ali <ashraf.ali.s@...>
|
Reviewed-by: S, Ashraf Ali <ashraf.ali.s@...>
|
By
Ashraf Ali S
· #99728
·
|
|
[edk2-platforms: PATCH] IntelSiliconPkg/SpiFvbServiceSmm: Rewrite VariableStore header.
Hi., Chasel If the NvStoreBuffer AllocateZeroPool failed then Status variable needs to updated. Can we have some meaning full debug message rather than just printing the GUID name. ExpectedBytesWritte
|
Hi., Chasel If the NvStoreBuffer AllocateZeroPool failed then Status variable needs to updated. Can we have some meaning full debug message rather than just printing the GUID name. ExpectedBytesWritte
|
By
Ashraf Ali S
· #99642
·
|
|
[PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
Reviewed-by: S, Ashraf Ali <ashraf.ali.s@...>
|
Reviewed-by: S, Ashraf Ali <ashraf.ali.s@...>
|
By
Ashraf Ali S
· #97922
·
|
|
[PATCH v2] FIX MinPlatformPkg PCIE Base typecasting error.
PCIE Base Address is 64bit PCD and the Mem Limit UINT64. so typecasting to 32bit is not needed. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4068 Signed-off-by: Ashraf Ali S <ashraf.ali.s@intel
|
PCIE Base Address is 64bit PCD and the Mem Limit UINT64. so typecasting to 32bit is not needed. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4068 Signed-off-by: Ashraf Ali S <ashraf.ali.s@intel
|
By
Ashraf Ali S
· #97755
·
|
|
[Patch] IntelSiliconPkg/IntelVTdDmarPei: Fix CLANG detected incorrect return
Reviewed-by: S, Ashraf Ali <ashraf.ali.s@...> Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.
|
Reviewed-by: S, Ashraf Ali <ashraf.ali.s@...> Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.
|
By
Ashraf Ali S
· #96426
·
|
|
[Patch edk2-platforms] IntelSiliconPkg/IntelVTdDxe: Fix CLANG detected incorrect return
Reviewed-by: S, Ashraf Ali <ashraf.ali.s@...> Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.
|
Reviewed-by: S, Ashraf Ali <ashraf.ali.s@...> Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.
|
By
Ashraf Ali S
· #96252
·
|
|
[PATCH v1] IntelFsp2Pkg: Adding FspHelperLib
Hi., Instead of Hardcoded FSP ImageBase as 0x1C in FspHelper.nasm, can we have struct from there we can get it. So that in future if the Header is changing assembly code will not get impacted. Regards
|
Hi., Instead of Hardcoded FSP ImageBase as 0x1C in FspHelper.nasm, can we have struct from there we can get it. So that in future if the Header is changing assembly code will not get impacted. Regards
|
By
Ashraf Ali S
· #96025
·
|
|
[edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header
Reviewed-by: Ashraf Ali S <ashraf.ali.s@...> Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.
|
Reviewed-by: Ashraf Ali S <ashraf.ali.s@...> Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.
|
By
Ashraf Ali S
· #94939
·
|
|
[PATCH] FIX MinPlatformPkg PCIE Base Addess avoid thunking operation.
thunking the PCIE base address will cause the distruption in the execution flow when the PCIE base address is 64bit bit. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4068 Signed-off-by: Ashraf
|
thunking the PCIE base address will cause the distruption in the execution flow when the PCIE base address is 64bit bit. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4068 Signed-off-by: Ashraf
|
By
Ashraf Ali S
· #93933
·
|
|
[PATCH] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments
Reviewed-by: Ashraf Ali S <ashraf.ali.s@... > Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.
|
Reviewed-by: Ashraf Ali S <ashraf.ali.s@... > Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.
|
By
Ashraf Ali S
· #92677
·
|
|
[PATCH V2] Maintainers.txt: Update reviewers for IntelSiliconPkg
Add Ashraf Ali S as IntelSiliconPkg reviewers Signed-off-by: Ashraf Ali S <ashraf.ali.s@...> Cc: Ray Ni <ray.ni@...> Cc: Rangasai V Chaganty <rangasai.v.chaganty@...> Cc: Isaac Oram
|
Add Ashraf Ali S as IntelSiliconPkg reviewers Signed-off-by: Ashraf Ali S <ashraf.ali.s@...> Cc: Ray Ni <ray.ni@...> Cc: Rangasai V Chaganty <rangasai.v.chaganty@...> Cc: Isaac Oram
|
By
Ashraf Ali S
· #92659
·
|
|
[PATCH] Maintainers.txt: Update reviewers for IntelSiliconPkg
Add Ashraf Ali S as IntelSiliconPkg reviewers Signed-off-by: Ashraf Ali S <ashraf.ali.s@...> Cc: Ray Ni <ray.ni@...> Cc: Rangasai V Chaganty <rangasai.v.chaganty@...> Cc: Isaac Oram
|
Add Ashraf Ali S as IntelSiliconPkg reviewers Signed-off-by: Ashraf Ali S <ashraf.ali.s@...> Cc: Ray Ni <ray.ni@...> Cc: Rangasai V Chaganty <rangasai.v.chaganty@...> Cc: Isaac Oram
|
By
Ashraf Ali S
· #92658
·
|
|
EDK2 build error:Unknown fatal error when processing []
Hi -p PLATFORMFILE, --platform=PLATFORMFILE Build the platform specified by the DSC file name argument, overriding target.txt's ACTIVE_PLATFORM definition. -a TARGETARCH, --arch=TARGETARCH ARCHS is on
|
Hi -p PLATFORMFILE, --platform=PLATFORMFILE Build the platform specified by the DSC file name argument, overriding target.txt's ACTIVE_PLATFORM definition. -a TARGETARCH, --arch=TARGETARCH ARCHS is on
|
By
Ashraf Ali S
· #92003
·
|
|
[PATCH v2 1/2] UefiPayloadPkg: Implement a new SerialPortLib instance
Hi, For the register offset doing the division operation of having a size UINTN in below code, I think we should use DivU64x32 function for Division operation right, correct me if I'm wrong. Regards,
|
Hi, For the register offset doing the division operation of having a size UINTN in below code, I think we should use DivU64x32 function for Division operation right, correct me if I'm wrong. Regards,
|
By
Ashraf Ali S
· #91546
·
|
|
[PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Support for X64 Build
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3833 Move FspDebug to the root of BaseFspDebugLibSerialPort since the current nasm support for both IA32 and X64 Build, remove IA32 from INF file. Cc
|
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3833 Move FspDebug to the root of BaseFspDebugLibSerialPort since the current nasm support for both IA32 and X64 Build, remove IA32 from INF file. Cc
|
By
Ashraf Ali S
· #86634
·
|
|
[PATCH] IntelFsp2Pkg: BaseFspSwitchStackLib Support for X64 Build
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3832 BaseFspSwitchStackLib Currently Support for IA32 build only, adding support for X64 build, fix typecasting issues for X64 build. 0xFFFF_FFFF wil
|
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3832 BaseFspSwitchStackLib Currently Support for IA32 build only, adding support for X64 build, fix typecasting issues for X64 build. 0xFFFF_FFFF wil
|
By
Ashraf Ali S
· #86633
·
|
