Sunny, Apologies for late response. (Not keeping well these days) Ok, PSB my remarks. #1. True, if an entity is independently getting build must be prefixed with Pkg. In my previous discussion with Le

Sunny, Thank you for reviewing my code. Here are my remarks. PSB

Sunny, thanks for your review and PSB my remarks.

This patch adds platform specific DSDT generator and Clk dsdt properties for LS1046AFRWY platform. Reviewed-by: Leif Lindholm <leif@...> Signed-off-by: Vikas Singh <vikas.singh@...

This patch enables the use of ConfigurationManager (CM) and its services to leverage the Dynamic ACPI support for NXP's LS1046aFrwy platform. Signed-off-by: Vikas Singh <vikas.singh@...>

This patch adds a generic method to get Silicon Version Register (SVR) on LS1046A SoC. This method will be generic for all platfroms based on LS1046A SoC, like - LS1046AFRWY, LS1046ARDB. Signed-off-by

This patch replaces the logic in ConfigurationManager to print platform name based on platform ID with a simple #define PLAT_SOC_NAME defined in platform headers. This also removes duplication of the

This patch series basically aims to extend the Dynamic ACPI framework towards NXP's LS1046AFRWY platform. In continuation to https://edk2.groups.io/g/devel/message/71709 The change set in the series i

Ok, I will add "Reviewed-by: Leif Lindholm <leif@...>" as part of the commit body.

Leif, Yes this patch will enable the usage of ConfigurationManager(CM) for LS1046aFrwy so that Dynamic ACPI table framework can be reused to generate the tables on this platform as well. And https://e

Leif, this patch adds a generic method to get the SVR details for LS1046A SoC. I will do the suggested changes in subject and body of the commit. I will share the updated V2 series shortly.

Leif, I will do the suggested changes in subject and body of the commit. Additionally, I will remove all the SVR_* duplicates from the platform headers. Will try to reuse the SVR_* definitions from th

This patch adds platform specific DSDT generator and Clk dsdt properties for LS1046AFRWY platform. Signed-off-by: Vikas Singh <vikas.singh@...> --- Platform/NXP/LS1046aFrwyPkg/AcpiTablesI

This patch set extends Configuration Manager (CM) and its services to leverage the Dynamic ACPI support for NXP's LS1046aFrwy platform. Refer-https://edk2.groups.io/g/devel/message/71710 Signed-off-by

This change set intend to add a generic method to get access to SoC's Silicon Version Register (SVR) and its handling for LS1046aFrwy platform. Signed-off-by: Vikas Singh <vikas.singh@...

Summary - 1.Configuration Manager(CM) is a common implementation and should not evaluate the SoC version using macro's However CM must directly consume SoC ver string from platfrom who is extending CM

This patch series basically aims to extend the Dynamic ACPI framework towards NXP's LS1046AFRWY platform. Refer- https://edk2.groups.io/g/devel/message/71709 The change set in the series is in below o

This patch adds platform specific DSDT generator and Clk dsdt properties for LS1046AFRWY platform. Signed-off-by: Vikas Singh <vikas.singh@...> --- .../AcpiTablesInclude/Dsdt/Clk.asl | 60

This patch set extends Configuration Manager (CM) and its services to leverage the Dynamic ACPI support for NXP's LS1046aFrwy platform. Refer-https://edk2.groups.io/g/devel/message/71710 Signed-off-by

This change set intend to add a generic method to get access to SoC's Silicon Version Register (SVR) and its handling for LS1046aFrwy platform. Signed-off-by: Vikas Singh <vikas.singh@...