The first use of the secret area was to hold the guest luks disk passphrase; this is used in the grub-inside-OVMF (AmdSev package), and there was no need to keep that page around for the guest kernel.

Hi Brijesh, (nit: I believe this UINT32 will appear in memory as the string "EDMA".) Not sure what's the official stance regarding a version field here. Maybe it's better to generate a new GUID whenev

[+cc: Tobin] Hi Brijesh, Would it make sense to always use EfiACPIMemoryNVS for the injected secret area, even for regular SEV (non-SNP)? -Dov

You're right; I'll fix. Thanks for pointing that out. I think I didn't see that in the code that builds the page tables for encrypted memory (which inspired most of this function), but maybe I missed

The comment at the top of this file (not visible in this diff) also mentions "SEV Launch Secret" which should be renamed to "Confidential Computing Secret". -Dov

(1) I'm not sure why the "3" is needed at the end of the function name. (2) The second argument is called 'Length' here and 'Pages' in the .c file. Which name is correct? If the semantics of the hyper