This crashes SEV guests. I presume because the call to IoMmuReleaseReservedSharedMem() is not bracketed by a check for TDX. I plan to add support for SEV, which would avoid the crash, not sure if you

Added the subject as somehow it didn't get set. The PCD for this is 64-bits, should this be 0xffffffffffff0000? Thanks, Tom

Just FYI, without the last half of this series, I believe that TDX will only be accepting 4GB of memory when using OvmfPkgX64.dsc (see OvmfPkg/Library/PlatformInitLib/IntelTdx.c), while SNP will be ac

Reviewed-by: Tom Lendacky <thomas.lendacky@...>

Since the above series was accepted into the EDK2 tree, can this series also be pulled in so that both TDX and SNP can support unaccepted memory in the same release? Thanks, Tom

Sorry I didn't pick up on this before, but any reason this isn't CcExitLibHandleVc() to match the other APIs or have the other APIs just be CcExit (since the "Lib" part seems a bit excessive)? (Same f

I get a build failure when building this patch: build.py... /root/kernels/ovmf-build-X64/OvmfPkg/OvmfPkgX64.dsc(...): error 4000: Instance of library class [CcExitLib] is not found in [/root/kernels/o

Ah, never mind... for some reason patch #7 didn't make it to my Inbox so I missed that. Thanks, Tom

Should you be deleting the VmgExitLibNull reference now? Or is this to handle issues with the edk2-platforms tree? If so, when will this be removed and VmgExitLibNull deleted? Thanks, Tom

Reviewed-by: Tom Lendacky <thomas.lendacky@...>

Isn't this supposed to be after disabling the timer? Thanks, Tom

Reviewed-by: Tom Lendacky <thomas.lendacky@...>

Just some formatting suggestions and one area of cleanup from previous version of the patch below. Assuming you take care of those: Reviewed-by: Tom Lendacky <thomas.lendacky@...> Create a generic

Sorry, I forgot to ask this earlier in the series, but is StartAddress guaranteed to be page-aligned and Size a multiple of 4KB? Should there be any asserts for those just in case? Also, can Size be 0

You'll need to split this patch into the MdeModulePkg changes and then the OvmfPkg changes. That will allow you to have the proper prefix on the subject line, too (sorry I didn't notice that last time

Shouldn't this have a v2 in the subject (same goes for patch 2/4)? I didn't see an answer as to why you couldn't use the MemEncryptSevSnpPreValidateSystemRam() function in OvmfPkg/Library/BaseMemEncry

No, if it works and is easier / more concise, then please keep it the way you have it. Thanks, Tom

This seems to be missing the creation of unaccepted memory under SEV-SNP. Is that going to be part of a separate patch (to update PlatformAddMemoryBaseSizeHob () and mark anything above 4GB as unaccep

Add STATIC this variable and the function below. Can't this instead just call MemEncryptSevSnpPreValidateSystemRam()? All phases have this function, so it would just be changing the version that is cu

Right, I've been able to boot with 512MB without issues. The address is 0x1000000 (16MB) and so that makes sense, nothing that can be done for that situation. Thanks, Tom