Hi Leif, Is it possible to provide your feedback for this patch, please? I can then look at merging this series. Regards, Sami Mujawar From: <devel@edk2.groups.io> on behalf of "Sami Mujawar via group

Hi Tiger, AcpiViewApp is an extension to the UEFI Shell debug command ‘acpiview’. I have not tired it on x86 as I have no means of testing this, but the application should work and dump raw table data

Hi Liming, I will look into this shortly. Regards, Sami Mujawar

Hi Omkar, I will pick this up for review this week. Regards, Sami Mujawar On 26/07/2021, 15:52, "Omkar Kulkarni" <Omkar.Kulkarni@...> wrote: Gentle reminder to review this patch series. Regards,

Hi Omkar, I will pick this up for review this week. Regards, Sami Mujawar On 26/07/2021, 15:52, "Omkar Kulkarni" <Omkar.Kulkarni@...> wrote: Gentle reminder to review this patch series. Regards,

Hi Philippe, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar On 21/07/2021, 09:19, "Philippe Mathieu-Daudé" <philmd@...> wrote: From: Philippe

Hi Ard, On 16/07/2021, 18:28, "Ard Biesheuvel" <ardb@...> wrote: ... or did you already merge the entire series? (My mailbox is overflowing a bit after 4 weeks of vacation :-)) [SAMI] I have m

Hi Pierre, Thank you for this patch. This fix looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Pierre, Thank you for this patch. This update looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Pushed as 8cb431b46a08..564a6a340892 Thanks. Regards, Sami Mujawar On 13/07/2021, 18:05, "Sami Mujawar" <sami.mujawar@...> wrote: Hi Joey, Thank you for this patch. This patch looks good to me. R

Hi Joey, Thank you for this patch. This patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Merged as 4c051c2c65a8..0e3b6bd0ee75 Thanks. Regards, Sami Mujawar On 07/07/2021, 02:43, "Jianyong Wu" <Jianyong.Wu@...> wrote: Hi Sami, Thanks for your rework on my patch. I tried the change and

Hi Jianyong, I should have caught this earlier in my review. However, if you agree, I will do the following changes before pushing the patch. 1. The subject line of the commit message does not confirm

Pushed as 086a3a3ce6c4..936e8dd57524 Thanks. Regards, Sami Mujawar

Hi Pranav, This patch series looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Grzegorz, Thank you for this patch. For: Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc Reviewed by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Jianyong, You should be able to remove the TPM dependency by keeping only the else part of TPM2_ENABLE and TPM2_CONFIG_ENABLE in both the DSC and FDF files. Also, can you fix the path to ArmVirtPci

Hi Jianyong, Thank you for this patch. This patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar [SAMI] Is TPM2 supported on CloudHypervisor? If not, would it be good to remove these options. Otherwise it may confuse

Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar [SAMI]Please add description of value returned by this function. [/SAMI] [SAMI] Define each local variable separately o