Hi Min, Jiewen, I believe this patch would need updating based on the changes done to patch 1/3 to make the measurment protocol architecture neutral. Other than that the code changes in this patch loo

Hi Min, Jiewen, Thank you for this patch. I think this patch would need updating based on the changes done to patch 1/3. Other than that I have some general feedback marked inline as [SAMI]. Regards,

Hi Min, Jiewen, Thank you for this patch. I think the protocol definition can be made architecturally neutral with a few modifications marked inline as [SAMI]. I am fine with renaming the protocol to

Hi Jiewen, I will start providing the feedback for this series starting today. I may need some help to understand the sequence of the various patch series that enable this feature and would be gratefu

Hi Jiewen, We don't have publicly available documentation to share in this area, however we strongly prefer an architecture agnostic solution, and my initial suggestions takes us in that direction. I

Hi Leif, Please find my response inline marked [SAMI]. Regards, Sami Mujawar [SAMI] I will start reviewing this patch set. [SAMI] I can start helping with the review of the patches to start with, and

Hi Rebecca, I will review this next week. Regard Sami Mujawar

Hi Min, Thank you for this patch. I think it would greatly help if the EFI_TD_PROTOCOL is changed to something more architecture neutral. As I understand, this patch series is removing the dependency

Merged as 30400318a278..769e63999ff5 Thanks. Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the inte

Merged as 5ece2ad36caa..30400318a278 Thanks. Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the inte

Hi Pierre, This patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may al

Hi Pierre, I think this v2 patch has introduced an issue (which was not there in v1), see my comment marked inline as [SAMI]. With that fixed, Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards,

Hi Pierre, Thank you for adding documentation for the steps for generating a Method. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may al

Hi Pierre, This patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may al

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may al

Hi Pierre, There is a minor typo in the commit message that I will fix when pushing the patch. Otherwise, this patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mu

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may al