Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Merged as 953438e4665c..2500ce101178 Thanks. Regards, Sami Mujawar

Hi Jeff, Thank you for the updated patch series. I have made some minor changes: 1. Move DynamicTablesPkg/Include/Library/AmlCpcInfo.h to DynamicTablesPkg/Include/AmlCpcInfo.h to stop edk2 CI from com

Merged as e55f0527dde4..727e458d6387 Thanks, Regards, Sami Mujawar

Merged as a8e8c43a0ef2..953438e4665c Thanks. Regards, Sami Mujawar

Hi Ard, Leif, This patch series and the corresponding edk2 series at https://edk2.groups.io/g/devel/message/93926 looks good to me and I have tested these with SbsaQemu as well. I already have a pull

Hi Nhi, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Nhi, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Nhi, Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 15/09/2022, 19:23, "Nhi Pham" <nhi@...> wrote: Thanks Leif. I will fix as your suggestion. -Nhi [S

Apologies for the delay. Merged as f4679715a40d..8d8bb28d2c4b Regards, Sami Mujawar

Merged as 45297e6c9bd1..8c92a9508e16 Thanks. Regards, Sami Mujawar

Hi Jeff, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Jeff, Please find my inputs inline marked [SAMI]. Regards, Sami Mujawar [SAMI] Move this function to DynamicTablesPkg\Library\Common\AmlLib\CodeGen\AmlCodeGen.c [SAMI] The number of parameters to t

Hi Jeff, Please find my feedback inline marked [SAMI]. Most of my suggestions are with respect to reducing the number of parameters in the AmlCreateCpcNod(). Regards, Sami Mujawar [SAMI] Include <Libr

Hi Jeff, Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar [SAMI] I think the number of parameters to AmlCreateCpcNode () can be reduced if we pass the CPC information using a struct

Hi Jeff, Apologies for the delay in providing feedback. I was half way through your patch series when you sent the v3. For this patch please fine my feedbakc inline marked [SAMI]. I believe some of th

Hi Abner, Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 13/09/2022, 04:00, "Chang, Abner" <Abner.Chang@...> wrote: [AMD Official Use Only - General] One question in below

Hi Rebecca, Your changes for Morello appear to be fine. However, I am not so sure about SgiPkg and why only one core is described. Maybe Thomas can provide more insight. Regards, Sami Mujawar

Hi All, [SAMI] Please read 'Test strings' as 'Text strings'. I will fix this with any other feedback in v2. Regards, Sami Mujawar

Hi Girish, Thank you for this patch and for the effort for bringing forward dynamic SMBIOS generation. Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar [SAMI] I think we may need a