Thanks Qin. A quick question: May I know what test you have run for this change? Also, I think this patch only protect the MM memory, but not OS memory. Is that expected? Will you consider adding OS m

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Sounds good. Thank you!

I am not familiar with AArch64. So I will let ARM people comment it. For X86, I think it is security hole, if we do not fill mMmMemLibInternalMmramRanges. A partial fix with known security vulnerabili

May I know where is the code to fill below? EFI_MMRAM_DESCRIPTOR *mMmMemLibInternalMmramRanges; UINTN mMmMemLibInternalMmramCount;

Since below code is using (UINTN)MmramRangeCount, MmInitializeMemoryServices ((UINTN)MmramRangeCount, (VOID *)(UINTN)MmramRanges); I recommend to UINTN for MmramRangeCount, and use (UINTN) cast.

Can we merge the common part between X64 and AArch64 into one Common.c?

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

I see. Yes, I think it is good idea to separate them in other patches. Thank you very much to confirm that.

Hi Thanks to add the StandaloneMM support. Would you please share the information on how you test the patch series? For every feature you touched (such as TPM), have you validated both traditional MM

Thank you James. I think you are on the right way. We will think about the feature in TDVF and do development in edk2-staging tree at first. The API change looks good to me. I don’t think you need cha

Series: Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Maybe you can upload the content to https://edk2.groups.io/g/devel/files/Designs, where we hold the design review ppt, etc. I assume we want to discuss below two APIs implementation, right? 1) RngLib

I see your point. I will let the patch submitter make final decision on which way they want to go. Thank you Yao Jiewen

Good catch Bret. Currently, ArmPlatformPkg.dec is in StandaloneMmCoreEntryPoint.inf. But I don’t find any real dependency. ArmSvcLib is in ArmPkg.dec. Hi Sami Is that possible that we just remove ArmP

Acked-by: Jiewen Yao <Jiewen.yao@...>