|
[PATCH] MdeModulePkg/TerminalDxe [BUG]: Terminal fifo buffer overflow.
Add Hao and Jian, who have the permission to merge the patch. CI result: https://github.com/tianocore/edk2/pull/1358 Thanks, Zhichao
|
Add Hao and Jian, who have the permission to merge the patch. CI result: https://github.com/tianocore/edk2/pull/1358 Thanks, Zhichao
|
By
Gao, Zhichao
· #70393
·
|
|
[PATCH] MdeModulePkg/TerminalDxe [BUG]: Terminal fifo buffer overflow.
There is no need to add [BUG] in the title. I would remove it when I create the PR. If you want to have a record for this bug, you can edit a Bugzilla and add the link in the commit message. Beside of
|
There is no need to add [BUG] in the title. I would remove it when I create the PR. If you want to have a record for this bug, you can edit a Bugzilla and add the link in the commit message. Beside of
|
By
Gao, Zhichao
· #70275
·
|
|
[PATCH] MdeModulePkg/TerminalDxe: Fix terminal fifo bufferoverflow with UINT8 type
Hi, Now I understood. It is a bug fix. But the commit message is not clear. typedef struct { UINT8 Head; UINT8 Tail; UINT8 Data[RAW_FIFO_MAX_NUMBER + 1]; } RAW_DATA_FIFO; RAW_FIFO_MAX_NUMBER is 256. t
|
Hi, Now I understood. It is a bug fix. But the commit message is not clear. typedef struct { UINT8 Head; UINT8 Tail; UINT8 Data[RAW_FIFO_MAX_NUMBER + 1]; } RAW_DATA_FIFO; RAW_FIFO_MAX_NUMBER is 256. t
|
By
Gao, Zhichao
· #70267
·
|
|
[PATCH] MdeModulePkg/TerminalDxe: Fix terminal fifo buffer overflow with UINT8 type
Hi, Sorry, I don't understand the patch. UINT8 type would have the value limitation. But why does it affect the buffer size? Did you observed the overflow with the original value? If yes, can you shar
|
Hi, Sorry, I don't understand the patch. UINT8 type would have the value limitation. But why does it affect the buffer size? Did you observed the overflow with the original value? If yes, can you shar
|
By
Gao, Zhichao
· #70206
·
|
|
[PATCH 1/1] Rename SmBios.h to Smbios.h in MdePkg/Include
This is a incompatible change and it requires the platforms to change related usage as well. Thanks, Zhichao
|
This is a incompatible change and it requires the platforms to change related usage as well. Thanks, Zhichao
|
By
Gao, Zhichao
· #70192
·
|
|
[PATCH 6/8] ShellPkg/ShellProtocol: sort files by FullName in RemoveDupInFileList()
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #70183
·
|
|
[PATCH 5/8] ShellPkg/Ls: sort output by FileName in non-SFO mode
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #70182
·
|
|
[PATCH 4/8] ShellPkg/ShellCommandLib: add ShellSortFileList()
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #70181
·
|
|
[PATCH 1/8] ShellPkg/Comp: add file buffering
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #70094
·
|
|
[PATCH v2-resend 0/2] Add AEST parser support to Acpiview
On my side, no. I would create a PR later. Thanks, Zhichao
|
On my side, no. I would create a PR later. Thanks, Zhichao
|
By
Gao, Zhichao
· #70008
·
|
|
[PATCH 1/1] ShellPkg: Remove bogus "Bits" text from some smbiosview strings.
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #69511
·
|
|
[EFI Shell PATCH v2 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols
Reviewed-by: Zhichao Gao <zhichao.gao@...> Please make sure #1 pass the review and it should be merged along with #1. Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Please make sure #1 pass the review and it should be merged along with #1. Thanks, Zhichao
|
By
Gao, Zhichao
· #69470
·
|
|
[PATCH v2-resend 0/2] Add AEST parser support to Acpiview
For #1 and #2, Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
For #1 and #2, Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #69469
·
|
|
[edk2-platform][PATCH v2 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY
Hi Ray, Do you have other concerns about this change? Thanks, Zhichao
|
Hi Ray, Do you have other concerns about this change? Thanks, Zhichao
|
By
Gao, Zhichao
· #69459
·
|
|
[edk2-platform][PATCH v2 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #69436
·
|
|
[PATCH v2-resend 1/2] ShellPkg/AcpiView: PCCT Parser
Apologize for the mistake. I would add the RB to the patches on your branch https://github.com/samimujawar/edk2/commits/840_pcct_parser_v2. Thanks, Zhichao
|
Apologize for the mistake. I would add the RB to the patches on your branch https://github.com/samimujawar/edk2/commits/840_pcct_parser_v2. Thanks, Zhichao
|
By
Gao, Zhichao
· #68654
·
|
|
[PATCH v2-resend 2/2] ShellPkg/AcpiView: PCCT Parser
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #68641
·
|
|
[PATCH v2-resend 1/2] ShellPkg/AcpiView: PCCT Parser
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #68640
·
|
|
[PATCH v1 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY
My consideration is the impact of make StdErr and StdCon same foreground and background. I don't think they should be the same. But it actually affects the DebugLib and other terminal operation's outp
|
My consideration is the impact of make StdErr and StdCon same foreground and background. I don't think they should be the same. But it actually affects the DebugLib and other terminal operation's outp
|
By
Gao, Zhichao
· #68408
·
|
|
[PATCH v1 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY
Normal DebugLib usually outputs string debug message only. It would show at the serial device with it current attributes. ErrOut and ConOut would change the attribute. That is why the color changes. A
|
Normal DebugLib usually outputs string debug message only. It would show at the serial device with it current attributes. ErrOut and ConOut would change the attribute. That is why the color changes. A
|
By
Gao, Zhichao
· #68325
·
|
