|
[PATCH v2 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.
OK. I am not familiar with PCD, it is new usage for me. And now I got to know the reason. But seems the behavior would be different base on the initialization on DSC file. Whatever, this patch is OK t
|
OK. I am not familiar with PCD, it is new usage for me. And now I got to know the reason. But seems the behavior would be different base on the initialization on DSC file. Whatever, this patch is OK t
|
By
Gao, Zhichao
· #78005
·
|
|
[edk2-platforms PATCH v2 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.
See below comments.
By
Gao, Zhichao
· #77589
·
|
|
[PATCH v2 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.
See below comments.
By
Gao, Zhichao
· #77588
·
|
|
[PATCH v2 4/8] ShellPkg: Acpiview: IORT parser update for IORT Rev E.b spec
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #77166
·
|
|
[PATCH v2 3/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #77165
·
|
|
[PATCH v2 2/8] MdePkg: IORT header update for IORT Rev E.b spec
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #77164
·
|
|
[PATCH v1 1/1] MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy
Add Liming to review as it is a change related to variable. Thanks, Zhichao
|
Add Liming to review as it is a change related to variable. Thanks, Zhichao
|
By
Gao, Zhichao
· #76242
·
|
|
[PATCH v2 1/3] ShellPkg/HttpDynamicCommand: Fix possible uninitialized use
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #75302
·
|
|
[PATCH 1/1] ShellPkg: Fix typo
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #74787
·
|
|
[PATCH v1 1/4] ShellPkg: Rename Address Size to Access size
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #74238
·
|
|
[PATCH 1/1] ShellPkg: Fix smbiosview system enclosure type table
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #73707
·
|
|
[EXTERNAL] [edk2-devel] [PATCH 1/1] MdeModulePkg/BmpSupportLib: Allow BMP with extra data
The patch would let the BMP file that with a bunch of data pass the check, no matter the data is valid or not. Do we have other docs to descript which data is allowed and valid? Correct the Cc mail ad
|
The patch would let the BMP file that with a bunch of data pass the check, no matter the data is valid or not. Do we have other docs to descript which data is allowed and valid? Correct the Cc mail ad
|
By
Gao, Zhichao
· #73515
·
|
|
[patch V4 21/29] ShellPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #73509
·
|
|
[PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols
You can push with the correction and add my R-B. No need to send V5 if there is no more comment for your patch set. Thanks, Zhichao
|
You can push with the correction and add my R-B. No need to send V5 if there is no more comment for your patch set. Thanks, Zhichao
|
By
Gao, Zhichao
· #73303
·
|
|
[PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols
First, thanks Liming's catch. Abner, The patch has been updated, you should remove my R-B for the V4 version. Otherwise the reviewers/maintainers may treated it as reviewed one. And please add the one
|
First, thanks Liming's catch. Abner, The patch has been updated, you should remove my R-B for the V4 version. Otherwise the reviewers/maintainers may treated it as reviewed one. And please add the one
|
By
Gao, Zhichao
· #73264
·
|
|
[PATCH v4] ShellPkg/Pci: Add valid check for PCI extended config space parser
Hi Ian/Vincent, It is better to add the reviewers/maintainers in the CC list. And also add the one who already give the comment. You can do this with 'git send-email -cc xxx.com' or add Cc: Name <emai
|
Hi Ian/Vincent, It is better to add the reviewers/maintainers in the CC list. And also add the one who already give the comment. You can do this with 'git send-email -cc xxx.com' or add Cc: Name <emai
|
By
Gao, Zhichao
· #73038
·
|
|
[PATCH] ShellPkg/Library: Fix bug in Pci.c
Hi Ian/Vincent, Sorry, I just notice the NextCapabilityOffset starts from base address of the PCI config space. So the comment I give in previous patch is incorrect. And refer the PCIe spec, its valid
|
Hi Ian/Vincent, Sorry, I just notice the NextCapabilityOffset starts from base address of the PCI config space. So the comment I give in previous patch is incorrect. And refer the PCIe spec, its valid
|
By
Gao, Zhichao
· #72944
·
|
|
[patch 20/28] ShellPkg: Consume RegisterFilterLibNull instance
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
Reviewed-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao
|
By
Gao, Zhichao
· #72859
·
|
|
[PATCH] ShellPkg/Library: Error handle while CapabilityId is 0xFFFF
Hi Ian/Vincent, It is a bug fix for parsing PCI extended config space. But there is one more place can be enhanced. if (ExtHdr->NextCapabilityOffset != 0) { You can see the above condition to check ne
|
Hi Ian/Vincent, It is a bug fix for parsing PCI extended config space. But there is one more place can be enhanced. if (ExtHdr->NextCapabilityOffset != 0) { You can see the above condition to check ne
|
By
Gao, Zhichao
· #72858
·
|
|
[PATCH V5] ShellPkg: add more items for smbiosview -t 3 .
I am OK with the patch. But the patch is using incorrect “Line ending”: python ./BaseTools/Scripts/PatchCheck.py -1 Checking git commit: HEAD ShellPkg: add more items for smbiosview -t 3 . The commit
|
I am OK with the patch. But the patch is using incorrect “Line ending”: python ./BaseTools/Scripts/PatchCheck.py -1 Checking git commit: HEAD ShellPkg: add more items for smbiosview -t 3 . The commit
|
By
Gao, Zhichao
· #72378
·
|
