|
[PATCH v5 19/19] SecurityPkg: Add references to new *.inf files
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #96542
·
|
|
[PATCH v5 18/19] SecurityPkg: Add Protected Variable Services
Judah, Several format issues. See inline comments starting with "[JianJW]". With them addressed, Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Judah, Several format issues. See inline comments starting with "[JianJW]". With them addressed, Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #96541
·
|
|
[PATCH v5 17/19] SecurityPkg: Add EncryptionVariable lib with AES
Judah, Just some typos found. See inline comments below starting with "[JianJW]". With them addressed, Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Judah, Just some typos found. See inline comments below starting with "[JianJW]". With them addressed, Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #96540
·
|
|
[PATCH v5 15/19] SecurityPkg: Add null encryption variable libs
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #96539
·
|
|
[PATCH v5 11/19] SecurityPkg: Add new KeyService types and defines
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #96538
·
|
|
[PATCH v5 09/19] MdeModulePkg: Reference Null ProtectedVariableLib
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #96537
·
|
|
[PATCH v5 08/19] MdeModulePkg: Add support for Protected Variables
So please ignore similar comments for other patches. For this patch, Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
So please ignore similar comments for other patches. For this patch, Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #96536
·
|
|
[PATCH v5 06/19] MdeModulePkg: Add Null ProtectedVariable Library
Judah, Just some typos. See inline comments starting with "[JianJW]". With them addressed, Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Judah, Just some typos. See inline comments starting with "[JianJW]". With them addressed, Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #96535
·
|
|
[PATCH v5 04/19] MdeModulePkg: Add new include files
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #96534
·
|
|
[PATCH v5 08/19] MdeModulePkg: Add support for Protected Variables
Thanks for sharing the info. It looks that my coding style knowledge needs refresh. Regards, Jian
|
Thanks for sharing the info. It looks that my coding style knowledge needs refresh. Regards, Jian
|
By
Wang, Jian J
· #96533
·
|
|
[PATCH v5 08/19] MdeModulePkg: Add support for Protected Variables
Hi Judah, Just one comment: For all header files, no need to remove the opening '_' of include guard macro. Protected variable code are now in different folder than original variable driver. They won'
|
Hi Judah, Just one comment: For all header files, no need to remove the opening '_' of include guard macro. Protected variable code are now in different folder than original variable driver. They won'
|
By
Wang, Jian J
· #96342
·
|
|
[PATCH v5 07/19] MdeModulePkg: Add new Variable functionality
One more comment: For all header files, no need to remove the opening '_' of include guard macro. Protected variable code are now in different folder than original variable driver. They won't referenc
|
One more comment: For all header files, no need to remove the opening '_' of include guard macro. Protected variable code are now in different folder than original variable driver. They won't referenc
|
By
Wang, Jian J
· #96341
·
|
|
[PATCH v5 07/19] MdeModulePkg: Add new Variable functionality
Hi Judah, See my comments (starting with [JianJW]) inline below.
|
Hi Judah, See my comments (starting with [JianJW]) inline below.
|
By
Wang, Jian J
· #96338
·
|
|
[PATCH v4 07/28] MdeModulePkg: Add new Variable functionality
Sorry, please ignore this one. I should reply the one from v5. Regards, Jian
|
Sorry, please ignore this one. I should reply the one from v5. Regards, Jian
|
By
Wang, Jian J
· #96337
·
|
|
[PATCH v4 07/28] MdeModulePkg: Add new Variable functionality
Hi Judah, See my comments (starting with [JianJW]) inline below. Regards, Jian
|
Hi Judah, See my comments (starting with [JianJW]) inline below. Regards, Jian
|
By
Wang, Jian J
· #96334
·
|
|
[Patch 1/1] CryptoPkg/Test: Simplify BaseCryptLib host based unit tests
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #95826
·
|
|
[PATCH v4 19/28] SecurityPkg: Add references to new *.inf files
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #92608
·
|
|
[PATCH v4 18/28] SecurityPkg: Add Protected Variable Services
Judah, Just one minor issue. In ProtectedVariableInternal.h, following prototype is never implemented. ProtectedVariableLibGetNextInternal The logic in this patch is very complicated. It's hard to fin
|
Judah, Just one minor issue. In ProtectedVariableInternal.h, following prototype is never implemented. ProtectedVariableLibGetNextInternal The logic in this patch is very complicated. It's hard to fin
|
By
Wang, Jian J
· #92607
·
|
|
[PATCH v4 17/28] SecurityPkg: Add EncryptionVariable lib with AES
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian
|
By
Wang, Jian J
· #92606
·
|
|
[PATCH v4 16/28] SecurityPkg: Add VariableKey library function
Judah, This lib depends on a PPI. Then it cannot be a BASE lib. Please add module type restriction like example below. + LIBRARY_CLASS = VariableKeyLib => + LIBRARY_CLASS = VariableKeyLib|PEIM With th
|
Judah, This lib depends on a PPI. Then it cannot be a BASE lib. Please add module type restriction like example below. + LIBRARY_CLASS = VariableKeyLib => + LIBRARY_CLASS = VariableKeyLib|PEIM With th
|
By
Wang, Jian J
· #92605
·
|
