Move the logic that stores starting PCI attributes and sets the EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This

Move the logic that stores starting PCI attributes and sets the EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This

Move the logic that stores starting PCI attributes and sets the EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This

Wait no. I just cannot read code, ignore that last bit. I'll prepare a patch.

Also, doesn't this code: if (!EFI_ERROR (Status)) { Supports &= (UINT64)EFI_PCI_DEVICE_ENABLE; Status = PciIo->Attributes ( PciIo, EfiPciIoAttributeOperationEnable, Supports, NULL ); } *strip* the PCI

Okay, I was wondering. My thought was that we probably want to re-enable bus mastering on reset so I kept that bit of code in the original location.

Move the logic that sets EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE Pci attribute to DriverBindingStart() before the memory that backs the DMA engine is allocated. This ensures that the DMA-backing memor

Brilliant idea, I'll do this!

Specify the Serial port Global System Interrupt in the SbsaQemu platform to be 33 (1 + 32). Cc: Leif Lindholm <leif@...> Cc: Ard Biesheuvel <ard.biesheuvel@...> Cc: Tanmay Jagdale <tanmay

The UART specified in the SPCR table needs a GSI assigned to it. The EDK2 will not use it because it does not use interrupts, but it is necessary for OS boot. Parametrize the value of the GSI assigned

Fix the PCD numbering for PcdPciExpressBarLimit to be sequential. Cc: Leif Lindholm <leif@...> Cc: Ard Biesheuvel <ard.biesheuvel@...> Cc: Tanmay Jagdale <tanmay.jagdale@...> Signe

The serial port global system interrupt is descibed in various ACPI tables. The library that generates these for the SbsaQemu platform hardcodes the value for the GSI. This pachset generalises the pro

The ACPI Tables providing library AcpiTables.inf uses a lot of information that is available in the form of PCDs for differnt platforms. This patch replaces hardcoded values describing the PCIe, AHCI,

The ACPI tables require not only the base and the size of various PCIe memory windows, but also the limit defined as Limit = Base + Size - 1 Given that ASL does not permit basic constant arithmetics w

It is useful to have the PCDs of same type to be numbered close together and thus a gap should be left between PCDs of different types. Cc: Leif Lindholm <leif@...> Cc: Ard Biesheuvel <ard.bi

The AcpiTable.inf library provides basic ACPI tables for the SbsaQemu platform. This platform aims to be the standard SBSA compliant platform. This patchset generalises the AcpiTables library using th

Hi Sami, Could you possibly have a look at my dynamic tables patches I submitted last week? Cheers, Tom

Replace macro-generated accessor functions in DynamicTables generators with TableHelperLib helpers that are compatible with v1.1 revision of Configuration Manager Protocol. Cc: Sami Mujawar <Sami.Muja

Simplify the methods to use the other object getter methods. The methods no longer need CfgMgr context parameter, the getter helpers retrieve the singleton platform protocol. The CfgMgrGetInfo always

Add user friendly strings for CmObjectIds to TableHelperLib and add debug print invocations to common helper methods. Cc: Sami Mujawar <Sami.Mujawar@...> Cc: Alexei Fedorov <Alexei.Fedorov@...