|
[PATCH v3 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg
In QemuKernelLoaderFsDxeEntrypoint we use FetchBlob to read the content of the kernel/initrd/cmdline from the QEMU fw_cfg interface. Insert a call to VerifyBlob after fetching to allow BlobVerifierLib
In QemuKernelLoaderFsDxeEntrypoint we use FetchBlob to read the content of the kernel/initrd/cmdline from the QEMU fw_cfg interface. Insert a call to VerifyBlob after fetching to allow BlobVerifierLib
|
By
Dov Murik
· #77963
·
|
|
[PATCH v3 05/11] OvmfPkg: add BlobVerifierLibNull to DSC
This prepares the ground for calling VerifyBlob() in QemuKernelLoaderFsDxe. Cc: Ard Biesheuvel <ardb+tianocore@...> Cc: Jordan Justen <jordan.l.justen@...> Cc: Ashish Kalra <ashish.kalra@
This prepares the ground for calling VerifyBlob() in QemuKernelLoaderFsDxe. Cc: Ard Biesheuvel <ardb+tianocore@...> Cc: Jordan Justen <jordan.l.justen@...> Cc: Ashish Kalra <ashish.kalra@
|
By
Dov Murik
· #77962
·
|
|
[PATCH v3 11/11] OvmfPkg/AmdSev: Enforce hash verification of kernel blobs
In the AmdSevX64 build, use BlobVerifierLibSevHashes to enforce verification of hashes of the kernel/initrd/cmdline blobs fetched from firmware config. This allows for secure (measured) boot of SEV gu
In the AmdSevX64 build, use BlobVerifierLibSevHashes to enforce verification of hashes of the kernel/initrd/cmdline blobs fetched from firmware config. This allows for secure (measured) boot of SEV gu
|
By
Dov Murik
· #77961
·
|
|
[PATCH v3 10/11] OvmfPkg: add BlobVerifierLibSevHashes
Add an implementation for BlobVerifierLib that locates the SEV hashes table and verifies that the calculated hashes of the kernel, initrd, and cmdline blobs indeed match the expected hashes stated in
Add an implementation for BlobVerifierLib that locates the SEV hashes table and verifies that the calculated hashes of the kernel, initrd, and cmdline blobs indeed match the expected hashes stated in
|
By
Dov Murik
· #77960
·
|
|
[PATCH v3 09/11] OvmfPkg/AmdSev: reserve MEMFD space for for firmware config hashes
From: James Bottomley <jejb@...> Split the existing 4KB page reserved for SEV launch secrets into two parts: first 3KB for SEV launch secrets and last 1KB for firmware config hashes. The are
From: James Bottomley <jejb@...> Split the existing 4KB page reserved for SEV launch secrets into two parts: first 3KB for SEV launch secrets and last 1KB for firmware config hashes. The are
|
By
Dov Murik
· #77959
·
|
|
[PATCH v3 06/11] ArmVirtPkg: add BlobVerifierLibNull to DSC
This prepares the ground for calling VerifyBlob() in QemuKernelLoaderFsDxe. Cc: Ard Biesheuvel <ardb+tianocore@...> Cc: Leif Lindholm <leif@...> Cc: Sami Mujawar <sami.mujawar@...>
This prepares the ground for calling VerifyBlob() in QemuKernelLoaderFsDxe. Cc: Ard Biesheuvel <ardb+tianocore@...> Cc: Leif Lindholm <leif@...> Cc: Sami Mujawar <sami.mujawar@...>
|
By
Dov Murik
· #77958
·
|
|
[PATCH v3 04/11] OvmfPkg: add library class BlobVerifierLib with null implementation
BlobVerifierLib will be used to verify blobs fetching them from QEMU's firmware config (fw_cfg) in platforms that enable such verification. The null implementation BlobVerifierLibNull treats all blobs
BlobVerifierLib will be used to verify blobs fetching them from QEMU's firmware config (fw_cfg) in platforms that enable such verification. The null implementation BlobVerifierLibNull treats all blobs
|
By
Dov Murik
· #77957
·
|
|
[PATCH v3 01/11] OvmfPkg/AmdSev/SecretDxe: fix header comment to generic naming
From: James Bottomley <jejb@...> Commit 96201ae7bf97 ("OvmfPkg/AmdSev/SecretDxe: make secret location naming generic", 2020-12-15) replaced references to SEV with the generic term Confidenti
From: James Bottomley <jejb@...> Commit 96201ae7bf97 ("OvmfPkg/AmdSev/SecretDxe: make secret location naming generic", 2020-12-15) replaced references to SEV with the generic term Confidenti
|
By
Dov Murik
· #77956
·
|
|
[PATCH v3 00/11] Measured SEV boot with kernel/initrd/cmdline
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 Booting with SEV prevented the loading of kernel, initrd, and kernel command-line via QEMU fw_cfg interface because they arrive from the VMM whi
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 Booting with SEV prevented the loading of kernel, initrd, and kernel command-line via QEMU fw_cfg interface because they arrive from the VMM whi
|
By
Dov Murik
· #77955
·
|
|
[PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg
With this patch we'll have two identical files: OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c but there's another QemuKernel.c, which is *
With this patch we'll have two identical files: OvmfPkg/Library/PlatformBootManagerLib/QemuKernel.c OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c but there's another QemuKernel.c, which is *
|
By
Dov Murik
· #77951
·
|
|
[PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg
I think so. Be sure to include full logs as much as possible and details about the image you're trying to start; it seems to me that if the kernel starts and initrd is mounted etc then both QEMU and O
I think so. Be sure to include full logs as much as possible and details about the image you're trying to start; it seems to me that if the kernel starts and initrd is mounted etc then both QEMU and O
|
By
Dov Murik
· #77945
·
|
|
[PATCH] UefiCpuPkg VTF0 X64: Build page tables using 1-GByte Page Granularity
Adding Tom too - I think he modified the OVMF reset vector lately and might know. I'm not an expert, but I think that OVMF has its own reset vector in OvmfPkg/ResetVector, and therefore the changes in
Adding Tom too - I think he modified the OVMF reset vector lately and might know. I'm not an expert, but I think that OVMF has its own reset vector in OvmfPkg/ResetVector, and therefore the changes in
|
By
Dov Murik
· #77923
·
|
|
[PATCH v2 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg
You're right -- it can be extended. Currently that's not the plan; the Guest Owner should be able to verify the measurement, which, with this patch series, is a combination of the OVMF, kernel, initrd
You're right -- it can be extended. Currently that's not the plan; the Guest Owner should be able to verify the measurement, which, with this patch series, is a combination of the OVMF, kernel, initrd
|
By
Dov Murik
· #77921
·
|
|
[PATCH v2 10/11] OvmfPkg: add SevHashesBlobVerifierLib
Indeed. But is this BASE_NAME okay? Or should it be BlobVerifierLibSevHashes ? Detect overflows in the `for` loop below? If a (bad) Entry->Len is 0xffff, then adding it to Len will overflow the UINT16
Indeed. But is this BASE_NAME okay? Or should it be BlobVerifierLibSevHashes ? Detect overflows in the `for` loop below? If a (bad) Entry->Len is 0xffff, then adding it to Len will overflow the UINT16
|
By
Dov Murik
· #77920
·
|
|
[PATCH v2 08/11] OvmfPkg/AmdSev/SecretPei: build hob for full page
Yes, that's much better. Thanks for introducing me to this macro. -Dov
Yes, that's much better. Thanks for introducing me to this macro. -Dov
|
By
Dov Murik
· #77919
·
|
|
[PATCH v2 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg
It's a sad winking face... I'll fix. Thanks, -Dov
It's a sad winking face... I'll fix. Thanks, -Dov
|
By
Dov Murik
· #77918
·
|
|
[PATCH v2 04/11] OvmfPkg: add library class BlobVerifierLib with null implementation
Thanks, I'll change that. You're right; I'll rename. Probably not; I'll remove. OK. You're right. I'll add it. Thanks, -Dov
Thanks, I'll change that. You're right; I'll rename. Probably not; I'll remove. OK. You're right. I'll add it. Thanks, -Dov
|
By
Dov Murik
· #77917
·
|
|
[PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg
You're right; I'll write it clearer. I guess it's possible by extracting the file into its own library? I'll need to take a deeper look. -Dov
You're right; I'll write it clearer. I guess it's possible by extracting the file into its own library? I'll need to take a deeper look. -Dov
|
By
Dov Murik
· #77916
·
|
|
[PATCH v2 00/11] Measured SEV boot with kernel/initrd/cmdline
Oh I missed a few. I'll fix. Thanks.
Oh I missed a few. I'll fix. Thanks.
|
By
Dov Murik
· #77915
·
|
|
[PATCH v2 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg
Can you please try with edk2 commit d1fc3d7ef3cb - just before we did some changes around this QEMU-interop code in OVMF? Thanks, Dov
Can you please try with edk2 commit d1fc3d7ef3cb - just before we did some changes around this QEMU-interop code in OVMF? Thanks, Dov
|
By
Dov Murik
· #77914
·
|