Reviewed-by: Ray Ni <ray.ni@...>

I think we need to define a new chunk hob type for solution proposed by Gerd. I will leave that to PIWG (PI spec working group) for discussion. In this topic, I prefer to solve the problem in the CPU

Sure. Jiaxin, please. Gerd, the benefit is to have a better modular design (separate PEIM instead of extending existing SmmCpuFeaturesLib), NOT "close-source" module. I don't have the power to argue w

Gerd, Can you please explain a bit more on the chunk idea? Brian, Page allocation is not preferred in this SMM case because the pointer in HOB entry points to another memory. StandaloneMmIpl has to mi

Gerd, I saw Zhiguang and you had some conversation in V1 mail thread. Was below question answered in that conversation? Any concern if I merge the patch? Thanks, Ray

Replacing today's duplicated page table manipulation logic with PageTableLib is in the todo list (as I said earlier creating a page table library was in the todo list). The bug is critical and needs t

Gerd, In another mail with title "MdePkg: Remove Itanium leftover data structure", we are discussing the HOB EFI_SEC_PLATFORM_INFORMATION_RECORD2 that helps share the BIST information with CpuDxe driv

Gerd, I think comments from patch #1 explains: # The default SMBASE for the x86 processor is 0x30000. When SMI happens, CPU + runs the SMI handler at SMBASE+0x8000. Also, the SMM save state area is wi

I had the same thought. New version is consistent with the logic below.

+ Gerd.

Reviewed-by: Ray Ni <ray.ni@...>

Donald, Old code might reference existing Reserved field in the structure definition. So, to avoid old code assigning value to different bits if using same field name but for different bits position,

Abner, I guess you found this logic is useful in AMD flow. Let's keep the current change as is and you could refactor the code later to present a full picture how AMD flow is like. Thanks, Ray

Do we support the case when the HOB is produced in normal boot but is not in S3 boot? To keep code flow simple and not to support unnecessary configuration combinations, I prefer no. Then, since mSmmR

Reviewed-by: Ray Ni ray.ni@...

The Two headers can be removed.

It seems the patch set is not based on the edk2 master branch. Can you confirm?