Thanks. I've sent out a v2 patch series "BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support". Marvin pointed out that the RVD support is probably also dead and should be r

@Reviewers: In case there are concerns regarding remaining users - to me, it appears the old RVD code has been broken for a very long time anyway: https://github.com/mhaeuser/edk2/commit/fc7b6713ec877

Since RvdPeCoffExtraActionLib has been deleted, remove lines referencing it and the RealView Debugger from ArmVirtPkg.dsc.inc. Signed-off-by: Rebecca Cran <rebecca@...> --- ArmVirtPkg/ArmVirt.ds

The RealView Debugger is related to RVCT, which is no longer supported. Given that, remove RvdPeCoffExtraActionLib and code from RvdPeCoffExtraActionLib which prints lines for use with the RealView De

With the removal of RVCT support and the related Bin/CYGWIN_NT-5.1-i686 and Darwin-i386 directories, remove a leftover reference to CYGWIN_NT-5.1-i686 from Scripts/PatchCheck.py. Signed-off-by: Rebecc

The Bin/CYGWIN_NT-5.1-i686 and Bin/Darwin-i386 directories contained files needed for RVCT support. Since EDK2 no longer supports RVCT, delete those directories. Signed-off-by: Rebecca Cran <rebecca@b

Personal PR: https://github.com/tianocore/edk2/pull/3958 Changes from v1 to v2: Removed reference to CYGWIN_NT-5.1-i686 from Scripts/PatchCheck.py Removed RealView Debugger support and references. Reb

No need, I just couldn't see what changed here :) No trailing space = good.

Thanks, I corrected this in the referenced repository fork. Will be included in v4.

Seems code formatter just removed trailing space. If you want so, I can drop this change in v4.

Acked-by: Tom Lendacky <thomas.lendacky@...>

I don't think there's a strong functional reason, but it adheres to the principle of not touching malformed data if at all possible. Not sure it needs to be part of this particular commit, but why not

Reviewed-by: Marvin Häuser <mhaeuser@...>

This code makes me wish for an in-place conversion lib, there really is no reason for dynamic allocation here... Reviewed-by: Marvin Häuser <mhaeuser@...>

Sidenote: please don't use this comment style, I know it's prevalent in EDK2 and EDK2 platforms but Ext4Pkg just does: // Comment Also, why are you bringing this null-termination down here?

Reviewed-by: Marvin Häuser <mhaeuser@...>

+1, the actual issue comes from using the wrong feature mask and not the != 0. If we get a v4, please update, else I can rewrite it myself. Reviewed-by: Pedro Falcato <pedro.falcato@...>

Reviewed-by: Pedro Falcato <pedro.falcato@...>

Embarrassing... Reviewed-by: Pedro Falcato <pedro.falcato@...>

Reviewed-by: Pedro Falcato <pedro.falcato@...>