|
[PATCH 1/1] BaseTools: Delete Bin/{CYGWIN_NT-5.1-i686,Darwin-i386} directories
Thanks. I've sent out a v2 patch series "BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support". Marvin pointed out that the RVD support is probably also dead and should be r
Thanks. I've sent out a v2 patch series "BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support". Marvin pointed out that the RVD support is probably also dead and should be r
|
By
Rebecca Cran
· #99188
·
|
|
[PATCH v2 4/4] ArmVirtPkg: Remove RealView Debugger lines from ArmVirtPkg.dsc.inc
@Reviewers: In case there are concerns regarding remaining users - to me, it appears the old RVD code has been broken for a very long time anyway: https://github.com/mhaeuser/edk2/commit/fc7b6713ec877
@Reviewers: In case there are concerns regarding remaining users - to me, it appears the old RVD code has been broken for a very long time anyway: https://github.com/mhaeuser/edk2/commit/fc7b6713ec877
|
By
Marvin Häuser
· #99187
·
|
|
[PATCH v2 4/4] ArmVirtPkg: Remove RealView Debugger lines from ArmVirtPkg.dsc.inc
Since RvdPeCoffExtraActionLib has been deleted, remove lines referencing it and the RealView Debugger from ArmVirtPkg.dsc.inc. Signed-off-by: Rebecca Cran <rebecca@...> --- ArmVirtPkg/ArmVirt.ds
Since RvdPeCoffExtraActionLib has been deleted, remove lines referencing it and the RealView Debugger from ArmVirtPkg.dsc.inc. Signed-off-by: Rebecca Cran <rebecca@...> --- ArmVirtPkg/ArmVirt.ds
|
By
Rebecca Cran
· #99186
·
|
|
[PATCH v2 3/4] ArmPkg: Remove RealView Debugger support
The RealView Debugger is related to RVCT, which is no longer supported. Given that, remove RvdPeCoffExtraActionLib and code from RvdPeCoffExtraActionLib which prints lines for use with the RealView De
The RealView Debugger is related to RVCT, which is no longer supported. Given that, remove RvdPeCoffExtraActionLib and code from RvdPeCoffExtraActionLib which prints lines for use with the RealView De
|
By
Rebecca Cran
· #99185
·
|
|
[PATCH v2 2/4] BaseTools: Remove CYGWIN_NT-5.1-i686 ref from Scripts/PatchCheck.py
With the removal of RVCT support and the related Bin/CYGWIN_NT-5.1-i686 and Darwin-i386 directories, remove a leftover reference to CYGWIN_NT-5.1-i686 from Scripts/PatchCheck.py. Signed-off-by: Rebecc
With the removal of RVCT support and the related Bin/CYGWIN_NT-5.1-i686 and Darwin-i386 directories, remove a leftover reference to CYGWIN_NT-5.1-i686 from Scripts/PatchCheck.py. Signed-off-by: Rebecc
|
By
Rebecca Cran
· #99184
·
|
|
[PATCH v2 1/4] BaseTools: Delete Bin/{CYGWIN_NT-5.1-i686,Darwin-i386} directories
The Bin/CYGWIN_NT-5.1-i686 and Bin/Darwin-i386 directories contained files needed for RVCT support. Since EDK2 no longer supports RVCT, delete those directories. Signed-off-by: Rebecca Cran <rebecca@b
The Bin/CYGWIN_NT-5.1-i686 and Bin/Darwin-i386 directories contained files needed for RVCT support. Since EDK2 no longer supports RVCT, delete those directories. Signed-off-by: Rebecca Cran <rebecca@b
|
By
Rebecca Cran
· #99183
·
|
|
[PATCH v2 0/4] BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support
Personal PR: https://github.com/tianocore/edk2/pull/3958 Changes from v1 to v2: Removed reference to CYGWIN_NT-5.1-i686 from Scripts/PatchCheck.py Removed RealView Debugger support and references. Reb
Personal PR: https://github.com/tianocore/edk2/pull/3958 Changes from v1 to v2: Removed reference to CYGWIN_NT-5.1-i686 from Scripts/PatchCheck.py Removed RealView Debugger support and references. Reb
|
By
Rebecca Cran
· #99182
·
|
|
[edk2-platforms][PATCH v3 06/11] Ext4Pkg: Corrects integer overflow check logic in DiskUtil
No need, I just couldn't see what changed here :) No trailing space = good.
No need, I just couldn't see what changed here :) No trailing space = good.
|
By
Pedro Falcato
· #99181
·
|
|
[edk2-platforms][PATCH v3 05/11] Ext4Pkg: Fix shift out of bounds in Ext4OpenSuperblock
Thanks, I corrected this in the referenced repository fork. Will be included in v4.
Thanks, I corrected this in the referenced repository fork. Will be included in v4.
|
By
Savva Mitrofanov
· #99180
·
|
|
[edk2-platforms][PATCH v3 06/11] Ext4Pkg: Corrects integer overflow check logic in DiskUtil
Seems code formatter just removed trailing space. If you want so, I can drop this change in v4.
Seems code formatter just removed trailing space. If you want so, I can drop this change in v4.
|
By
Savva Mitrofanov
· #99179
·
|
|
[PATCH v2] OvmfPkg: Create additional PML1 entries for large SEV-SNP VMs
Acked-by: Tom Lendacky <thomas.lendacky@...>
Acked-by: Tom Lendacky <thomas.lendacky@...>
|
By
Lendacky, Thomas
· #99178
·
|
|
[edk2-platforms][PATCH v3 10/11] Ext4Pkg: Fixes build on MSVC
I don't think there's a strong functional reason, but it adheres to the principle of not touching malformed data if at all possible. Not sure it needs to be part of this particular commit, but why not
I don't think there's a strong functional reason, but it adheres to the principle of not touching malformed data if at all possible. Not sure it needs to be part of this particular commit, but why not
|
By
Marvin Häuser
· #99177
·
|
|
[edk2-platforms][PATCH v3 09/11] Ext4Pkg: Add missing exit Status in Ext4OpenDirent
Reviewed-by: Marvin Häuser <mhaeuser@...>
Reviewed-by: Marvin Häuser <mhaeuser@...>
|
By
Marvin Häuser
· #99176
·
|
|
[edk2-platforms][PATCH v3 08/11] Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName
This code makes me wish for an in-place conversion lib, there really is no reason for dynamic allocation here... Reviewed-by: Marvin Häuser <mhaeuser@...>
This code makes me wish for an in-place conversion lib, there really is no reason for dynamic allocation here... Reviewed-by: Marvin Häuser <mhaeuser@...>
|
By
Marvin Häuser
· #99175
·
|
|
[edk2-platforms][PATCH v3 10/11] Ext4Pkg: Fixes build on MSVC
Sidenote: please don't use this comment style, I know it's prevalent in EDK2 and EDK2 platforms but Ext4Pkg just does: // Comment Also, why are you bringing this null-termination down here?
Sidenote: please don't use this comment style, I know it's prevalent in EDK2 and EDK2 platforms but Ext4Pkg just does: // Comment Also, why are you bringing this null-termination down here?
|
By
Pedro Falcato
· #99174
·
|
|
[edk2-platforms][PATCH v3 07/11] Ext4Pkg: Check that source file is directory in Ext4OpenInternal
Reviewed-by: Marvin Häuser <mhaeuser@...>
Reviewed-by: Marvin Häuser <mhaeuser@...>
|
By
Marvin Häuser
· #99173
·
|
|
[edk2-platforms][PATCH v3 02/11] Ext4Pkg: Fix incorrect checksum metadata feature check
+1, the actual issue comes from using the wrong feature mask and not the != 0. If we get a v4, please update, else I can rewrite it myself. Reviewed-by: Pedro Falcato <pedro.falcato@...>
+1, the actual issue comes from using the wrong feature mask and not the != 0. If we get a v4, please update, else I can rewrite it myself. Reviewed-by: Pedro Falcato <pedro.falcato@...>
|
By
Pedro Falcato
· #99172
·
|
|
[edk2-platforms][PATCH v3 09/11] Ext4Pkg: Add missing exit Status in Ext4OpenDirent
Reviewed-by: Pedro Falcato <pedro.falcato@...>
Reviewed-by: Pedro Falcato <pedro.falcato@...>
|
By
Pedro Falcato
· #99171
·
|
|
[edk2-platforms][PATCH v3 08/11] Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName
Embarrassing... Reviewed-by: Pedro Falcato <pedro.falcato@...>
Embarrassing... Reviewed-by: Pedro Falcato <pedro.falcato@...>
|
By
Pedro Falcato
· #99170
·
|
|
[edk2-platforms][PATCH v3 07/11] Ext4Pkg: Check that source file is directory in Ext4OpenInternal
Reviewed-by: Pedro Falcato <pedro.falcato@...>
Reviewed-by: Pedro Falcato <pedro.falcato@...>
|
By
Pedro Falcato
· #99169
·
|