Acked-by: Liming Gao <gaoliming@...> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Li, Zhihao > 发送时间: 2022年4月25日 16:47 > 收件人: devel@edk2.groups.io > 抄送: Michael D K

Acked-by: Liming Gao <gaoliming@...> > -----邮件原件----- > 发件人: Ard Biesheuvel <ardb@...> > 发送时间: 2022年4月26日 4:49 > 收件人: edk2-devel-groups-io <devel@edk2.groups.io>; Gerd Hoffmann > <kr

Reviewed-by: Liming Gao <gaoliming@...> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Hsu, Roger > 发送时间: 2022年4月22日 14:55 > 收件人: devel@edk2.groups.io > 抄送: Michael

Reviewed-by: Liming Gao <gaoliming@...> > -----邮件原件----- > 发件人: Chao Li <lichao@...> > 发送时间: 2022年4月22日 15:44 > 收件人: devel@edk2.groups.io > 抄送: sean.brogan@...; Bret.Barke

Zhihao: To be compatible, you can also add the default SmmCpuRendezvousLib library instance (SmmCpuRendezvousLibNull) into MdeLibs.dsc.inc. Then, this change is compatible. Thanks Liming > -----邮件原件--

Chao: You can to add them ECC exception list in MdePkg\MdePkg.ci.yaml if they are all defined in MdePkg. Thanks Liming 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Chao Li 发送时间: 2022年4月21日 16:5

Change: https://github.com/tianocore/edk2/pull/2797 is used to merge these two patches. Thanks Liming > -----邮件原件----- > 发件人: Ke, Bo-ChangX <bo-changx.ke@...> > 发送时间: 2022年4月21日 19:06 > 收件人: dev

Oliver: The change is good to me. I also include ARM maintainer Ard to review this change. Reviewed-by: Liming Gao <gaoliming@...> Thanks Liming > -----邮件原件----- > 发件人: Oliver Steffen <oste

Guomin: gEfiCallerBaseName is the module base name, not source file name. It can verify the build reproduce, but it can't provide the same functionality to _FILE_. Thanks Liming > -----邮件原件----- > 发件人

Chang: PR shows the patch coding style issue. Please fix them. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming > 发送时间: 2022年4月20日 7:50 > 收件人: devel@edk2.

PR https://github.com/tianocore/edk2/pull/2797 is created. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Gao, Zhichao > 发送时间: 2022年4月19日 13:09 > 收件人: devel@edk2.

For Q2, if key word is defined in public spec, they can be handled as the exception. You can see MdePkg\MdePkg.ci.yaml EccCheck section that has ExceptionList and IgnoreFiles. Thanks Liming 发件人: devel

GCC Stack Protector options come from GCC4.9.3. But, there is GCC48 in tools_def. I am not sure whether GCC48 is still used. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@...

Min: The change in MdePkg is good to me. Reviewed-by: Liming Gao <gaoliming@...> Thanks Liming > -----邮件原件----- > 发件人: Min Xu <min.m.xu@...> > 发送时间: 2022年4月17日 11:01 > 收件人: devel@edk2

Zhihao: I see three platforms in edk2-platforms to consume VariableStandaloneMm module. So, I think this change will impact them. Can you confirm this change with those platform owners? Platform\ARM\S

Reviewed-by: Liming Gao <gaoliming@...> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Bo Chang Ke > 发送时间: 2022年4月15日 16:35 > 收件人: Gao, Zhichao <zhichao.gao@...

Guomin: I understand the purpose. But, I don't see the complete solution to configure DEBUG_FILE_PATH for every source file in order to meet with the debug image reproducible builds. Have you verified

Zhihao: I remember CI has the check for the package dependency. If this patch passes CI, seemly this checker doesn't do. You can see DependencyCheck in MdeModulePkg\MdeModulePkg.ci.yaml. And, this pat

Guomin: Can you introduce DEBUG_FILE_PATH usage? If the developer wants to enable this feature, how configure DEBUG_FILE_PATH? Thanks Liming > -----邮件原件----- > 发件人: Guomin Jiang <guomin.jiang@...

Michael: Thanks for your update. Reviewed-by: Liming Gao <gaoliming@...> for this patch set. Thanks Liming > -----邮件原件----- > 发件人: Michael Kubacki <mikuback@...> > 发送时间: 202