From the function description of GetIfrBinaryData(), FormSetGuid can be NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes exception when FormSetGuid is NULL. Signed-off-by: Nickle Wang

From the function description of GetIfrBinaryData(), FormSetGuid can be NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes exception when FormSetGuid is NULL. Signed-off-by: Nickle Wang

Hi Dandan, Thanks for your reminder. I update my patch and it passed BaseTools/Scripts/PatchCheck.py test. Nickle

Hi Liming, Yes, I made a function and call GetIfrBinaryData() with NULL value to second parameter. Then I see system assert. Thanks, Nickle

No, I can have a dummy variable to work around this issue. Nickle

Follow the implementation from Unix host to implement SNP EMU_IO_THUNK_PROTOCOL and EMU_SNP_PROTOCOL. The network IO driver is the same one as Nt32. Please refer to NETWORK-IO Subproject for network I

Follow the implementation from Unix host to implement SNP EMU_IO_THUNK_PROTOCOL and EMU_SNP_PROTOCOL. The network IO driver is the same one as Nt32. Please refer to NETWORK-IO Subproject for network I

Hi Justen, Andrew, Ray, Could you please help me to review my change? This is version 2 patch to address the comment from TianoDesign meeting on 04/03. Thanks, Nickle

Reviewed-by: Nickle Wang <nickle.wang@...>

Reviewed-by: Nickle Wang <nickle.wang@...>

Hi Abner, I found that the parameter is not defined as it is described in function header. Please check my comment inline below. Thanks, Nickle

Hi Abner, I do not see any usage of DEBUG macro in this NULL library so maybe "DebugLib" could be removed from INF file. Thanks, Nickle

Reviewed-by: Nickle Wang <nickle.wang@...>

Hi Abner, Do we need to specify the library instance under [Components] section when they are specified in [LibraryClasses] already? Thanks, Nickle

Reviewed-by: Nickle Wang <nickle.wang@...>

Hi Abner, I found an issue on function header of EFI_REST_JSON_STRUCTURE_REGISTER that is not follow UEFI spec. Thanks, Nickle

Hi Abner, I have comment for function RestJsonStructureUnload(). Please check my inline comment below. Thanks, Nickle

Reviewed-by: Nickle Wang <nickle.wang@...>

Hi Abner, Thanks for addressing my comment. Reviewed-by: Nickle Wang <nickle.wang@...>

Reviewed-by: Nickle Wang <nickle.wang@...>