Hi If TdxDxe breaks SEV, should we skip the TdxDxe in SEV path? I don't understand why we need use Cfg8. Thank you Yao Jiewen

Thanks Min. Merged - https://github.com/tianocore/edk2/pull/2790

Hi I am confused. This patch set has already been merged. Why it is sent again? Have you rebased to latest tree, before you send out patch? Thank you Yao Jiewen

Thanks for the update. With CCEL Rsvd changed to 2 bytes, the series reviewed-by: Jiewen Yao <Jiewen.yao@...>

+typedef struct { + EFI_ACPI_DESCRIPTION_HEADER Header; + EFI_CC_TYPE CcType; + UINT32 Rsvd; <== HERE! + UINT64 Laml; + UINT64 Lasa; +} EFI_CC_EVENTLOG_ACPI_TABLE; Would you please double check the sp

Series reviewed-by: Jiewen Yao <Jiewen.yao@...>

Exactly. Lacking of doc from different compilers is very painful. The Asan or UBsan support is just a hack - https://github.com/jyao1/SecurityEx/blob/master/StackCheckPkg/Library/StackCheckLib/ASanStu

Merged - https://github.com/tianocore/edk2/pull/2779

Ah, thanks for the reminder. I overlooked this one. Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Thanks. The v2 series merged - https://github.com/tianocore/edk2/pull/2777

Thank you very much, James and Min, for the quick response. I have one small concern on the naming - TdProbeLib. Would it be better if we create a generic CcProbeLib, and just return the CC_GUEST_TYPE

Thanks for the contribution. Great progress on adding ECC. With PcdLib removed and "no-ec" removed, the series is reviewed-by: Jiewen Yao <Jiewen.yao@...>

I think you can remove the no-ec directly. No need to comment it. - "no-ec", + # "no-ec", Thank you Yao Jiewen

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Since this PcdEcEnabled is static, you don't need add PcdLib in the INF. Thank you Yao Jiewen

Thanks for the contribution. Merged https://github.com/tianocore/edk2/pull/2766

OK. Having implementation in .h is not allowed in EDKII. Sorry, I missed that. Please move it to CrtWrapper.c and drop inline.

Can we remove inline keyword? I don't think it is really needed in EDKII project. Thank you Yao Jiewen

With inline keyword removed in patch-7/8, Series reviewed-by: Jiewen Yao <Jiewen.yao@...>

Can we use a SecMeasurementLib here? Instead of implementing all things in Startup.