Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Since this PcdEcEnabled is static, you don't need add PcdLib in the INF. Thank you Yao Jiewen

Thanks for the contribution. Merged https://github.com/tianocore/edk2/pull/2766

OK. Having implementation in .h is not allowed in EDKII. Sorry, I missed that. Please move it to CrtWrapper.c and drop inline.

Can we remove inline keyword? I don't think it is really needed in EDKII project. Thank you Yao Jiewen

With inline keyword removed in patch-7/8, Series reviewed-by: Jiewen Yao <Jiewen.yao@...>

Can we use a SecMeasurementLib here? Instead of implementing all things in Startup.

I am not sure if we really need router here. TDX only supports SHA384. What if we just provide HashLibTdx? If we really want to provide a router, then it should be HashLibCCRouter. And TDX should be t

Reiewed-by: Jiewen Yao <Jiewen.yao@...>

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Hi The rule for lib instance is: It must provide all interfaces defined in .h file. As such, please use NULL version other algorithms in SEC instance. Thank you Yao Jiewen

Acked-by: Jiewen Yao <Jiewen.yao@...>

Merged https://github.com/tianocore/edk2/pull/2729

Series: reviewed-by: Jiewen Yao <Jiewen.yao@...>

for all reviewed-by jiewen.yao@... thank you! Yao, Jiewen

Reviewed-by: Jiewen Yao <Jiewen.yao@...> Is this a standalone patch? Or one of a series patch? I think it should be later. But, please enlighten me.

Thanks Min Series: Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Agree with Jian. I don’t understand this patch set and the feature. I request a design review in EDKII. Thank you Yao Jiewen

Merged: https://github.com/tianocore/edk2/pull/2692