Parsing command line parameters is done in the shell command wrapper. This declutters the core code and improves modular design. Cc: Ray Ni <ray.ni@...> Cc: Zhichao Gao <zhichao.gao@...> R

The UefiShellAcpiViewCommandLib is converted from NULL library to a named library so that it may be used in modules other than shell. The library interface exposes the main method for to AcpiView func

A new file and header (AcpiViewConfig.[ch]) is created that houses the user configuration. This declutters the core code and improves modularity of the design. The module level symbols for verbosity,

The table count module level symbols are now reset when executing the core method, rather than the shell command wrapper. Cc: Ray Ni <ray.ni@...> Cc: Zhichao Gao <zhichao.gao@...> Reviewed

The error and warning counters are reset in the AcpiView main method. This improves reusability of the main method. Cc: Ray Ni <ray.ni@...> Cc: Zhichao Gao <zhichao.gao@...> Reviewed-by: Z

This patchset adds a new application module to the ShellPkg with the functionality of the 'acpiview' command. The existing code is tidied and a clean boundary between the UEFI shell command wrapper an

Hi Ray, Zhichao, Do you have any opinions on the respun patches? Cheers, Tom

Method is refactored into two parts. A new method is created that dumps arbitrary buffers into a newly created file. This method is called from core code after the core code determined the appropriate

A new file and header (AcpiViewConfig.[ch]) is created that houses the user configuration. This declutters the core code and improves modularity of the design. The module level symbols for verbosity,

Parsing command line parameters is done in the shell command wrapper. This declutters the core code and improves modular design. Cc: Ray Ni <ray.ni@...> Cc: Zhichao Gao <zhichao.gao@...> R

Simple application wrapper that invokes the shell command wrapper for 'acpiview'. This allows the AcpiView functionality to be used on platforms with older specifications of the UEFI shell or where th

This patchset adds a new application module to the ShellPkg with the functionality of the 'acpiview' command. The existing code is tidied and a clean boundary between the UEFI shell command wrapper an

The UefiShellAcpiViewCommandLib is converted from NULL library to a named library so that it may be used in modules other than shell. The library interface exposes the main method for to AcpiView func

The error and warning counters are reset in the AcpiView main method. This improves reusability of the main method. Cc: Ray Ni <ray.ni@...> Cc: Zhichao Gao <zhichao.gao@...> Reviewed-by: Z

The table count module level symbols are now reset when executing the core method, rather than the shell command wrapper. Cc: Ray Ni <ray.ni@...> Cc: Zhichao Gao <zhichao.gao@...> Reviewed

Thank you Zhichao, this is really useful, I was wondering how to hook into the shell help framework. Regarding the lower case const and static, I am entirely happy to change them, but I have a couple

Krzysztof has moved on to other pastures, I'll respin the patches accordingly. Cheers, Tom

Hi Kumar, The UEFI drivers follow a two stage loading mechanism. When the driver is loaded/executed, it loads itself into memory and installs a DRIVER_BINDING_PROTOCOL on its own handle. That protocol

Hi, By no means a complete answer but some important points below. There are two important concepts in UEFI that you absolutely need to get comfortable with. These two are Handles and Protocols. You c

Hi Zhichao, Thank you very much, I am just trying to make sure things don’t slip through the cracks. Cheers, Tom