Mike, Sounds like a good plan. Thanks, Andrew Fish

Marvin, Good point. This would make the rule moot. So maybe just removing the requirement would be the easiest long term fix. Other embedded projects I know of do this too, and as you point out the co

This issue is independent of CONST. I’m not sure a coding style tool is smart enough to catch this generically? You need an understanding of C types to know if the local variable assignment is going t

On the git-blame front we might be able to build a recipe that walks past the code style and line ending commits that would could add to an FAQ or Wiki. For bonus points we could add a git command tha

Can we disable the rule that does not like the DEBUG macro? I seem to remember clang nags about some strange () usage, so maybe we would not lose that much? Thanks, Andrew Fish

Should we move to require a min Python version at some point?

Are you using Python 2.7? Try using Python 3.* It looks like array.fromstring() got renamed to array.frombytes() in Python 3.2, so I’m guessing you are using Python 2.7? Thanks, Andrew Fish

Guo, Structure is the endian of the machine running Python which might not be correct. It would be more correct to use LittleEndianStructure vs Structure. This is probably good practice like using “<“

If we add QuickSort() API to the BaseLib can we not just port the existing MdeModulePkg/SortLib to use QuickSort() in the implementation? Or is there some other way to add the new thing in a backward

Sorry the patches stalled out. I need to push them…. Thanks, Andrew Fish

Mike, Stupid question but the BaseCryptLib seems to really be DxeCryptLib[1]? So are you worried about adding the dependency to this DXE Lib? It depends on UefiRuntimeServicesTableLib. Looks like SysC

It looks like a label starting with @ is not legal nasm syntax? "Valid characters in labels are letters, numbers, _, $, #, @, ~, ., and ?. The only characters which may be used as the first character

James, If we take a big step back the requirement for an EFI Runtime Service, like the variable API, is just exclusive access to hardware at OS runtime. The variable store needs to be on a hardware de

I’m also in the 16 MiB camp and I’m OK with the 256KiB varstore. Thanks, Andrew Fish

Mike, That reminds me that my patch to fix this for Xcode is still in limbo. Thanks, Andrew Fish

You are not subscribed so all your posts have to be manually approved.

Just ran across this today and wanted to share. The NASM Chapter 7 [1] defines the behavior for .rodata for ELF and mach-O . So the behavior is well defined. From 7.8.1 macho extensions to the SECTION

That sounds like a good plan. I think this brings up a point that we should have are more formal set of libraries for the BaseTools and some standard coding patterns If I was looking for EFI_TIME() or

We should use (LittleEndianStructure) vs. (Structure). Structure is the endian of the Host, and EFI is little endian. Same comment for all the ctype structs. LittleEndianStructure is like using < with

Rebecca, Sorry I may have been a commit or 2 behind on the private branch. Can you try again? I think I fixed this? The `efi symbols` command is saving user context, so it can restore the context. If