Reviewed-by: Michael D Kinney <michael.d.kinney@...>

Hi Leif, Thank you for the reviews! For generated files, I think there are two categories 1) Files generated as part of the build process that are placed in the build output directly and are

Hi, I think you are seeing the impact of compiler optimizations. If a global variable is never referenced after optimizing the code, then the global variable will be optimized away. This type of

Hi Leif, Sorry I missed your mail. For License issue I will update it later. I know there are some DesignWare USB controller driver, but most of them are for USB Host Mode. The driver "UsbDeviceDxe"

I can't shake the feeling this code has the wrong level of complexity. It's reserving *one* memory window, at a given alignment. (As has been pointed out to me in the past, 1 is also a power of

Drop space before Buffer. Drop space before Buffer. I will note here that you are adding identical content to two different ChassisLib implementations. This is a strong indicator that the

For this patch: Reviewed-by: Leif Lindholm <leif@...> Pushed as e5c5ad8bfb03.

Hi Mike, For the series: Reviewed-by: Leif Lindholm <leif@...> Recent events make me think though - should we have an explicit statement regarding those files we have that are generated

Thanks! For the series: Reviewed-by: Leif Lindholm <leif@...> Pushed as 02cf0dcf8f93..b2eebc1d593e.

Hi, Liming: Thanks for your reply! I checked map file, not find this global data array. I found if added this build option in this PEIM's inf, then it seems ok. [BuildOptions] MSFT:*_*_IA32_CC_FLAGS

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2777 Code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES is deprecated. So remove it. Cc: Jian J Wang <jian.j.wang@...> Cc: Hao A Wu

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2777 Code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES is deprecated. So remove it. Cc: Michael D Kinney <michael.d.kinney@...> Cc: Liming

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2777 Code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES is deprecated. So remove it from MdePkg and MdeModulePkg. Cc: Hao A Wu

Reviewed-by: Guomin Jiang <guomin.jiang@...> for the patch series.

Reviewed-by: Bob Feng <bob.c.feng@...>

Reviewed-by: Bob Feng <bob.c.feng@...>

Dear Community Members, Our monthly community meeting is coming up on Thursday (Aug 6) of this week. We will cover our standard topics - download from Stewards call, Stable tag updates, ARs/updates

I saw one R-b for the series from Wei6 Xu. Could the remaining reviewers please help with review? I have a larger series that is based on it that I'd like to send once this series is

Update list of content that is covered by a license other than the BSD-2-Clause Plus Patent License and break out list of content that is included as a git submodule from upstream projects. * Use