`CreateDirectoryIfCreating` is used only if `PermitCreation` is set. `NewNodeIsDirectory` might not set in case of error, but that would lead to leaving the function before invalid use. Ref:

`Dupes` is used only if `Duplicates != NULL` and function is left if allocation of memory for `Dupes` fails, so it can't be used uninitialized. Ref:

Compiling for IA32 target with gcc-5.5.0 emits "maybe-uninitialized" warnings. Compilation command: build -a IA32 -p OvmfPkg/OvmfPkgIa32.dsc -t GCC49 Sergei Dmitrouk (2):

Thanks Isaac. I'll make those changes at submission time.

Now that we are doing SoC detection and adjusting the DMA window it should be safe to turn DMA on by default. Signed-off-by: Jeremy Linton <jeremy.linton@...> ---

The newer BCM2711 SoC's don't have a DMA constraint on the emmc2 controller. So we don't need to do the 1G translation. Lets allow the AML to detect the SoC revision and return a different _DMA

The _DMA range needs to change depending on the SOC in use, this was part of the problem with enabling DMA by default because there wasn't a clear way to determine the SOC revision in use. Now that

The genet is capable of addressing the entire memory space on the RPI4. Lets allow it to dma into those regions. This solves intermittent issues with grub/etc being able to communicate when the 3G

Under normal circumstances GenetSimpleNetworkTransmit won't be called unless the rest of the network stack detects the link is up. So, during normal operation when the adapter is initialized the link

When PXE booting with grub the network link isn't given a chance to resume so grub's transmit calls fail. This results in failed boots. Similarly the DMA range for the adapter isn't right since

When PXE booting with grub the network link isn't given a chance to resume so grub's transmit calls fail. This results in failed boots. Similarly the DMA range for the adapter isn't right since

Series Reviewed-by: Isaac Oram <isaac.w.oram@...>

Series Reviewed-by: Isaac Oram <isaac.w.oram@...> Some nit observations. Not critical, but nice to update. Patch 05/18:

Thanks!! Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@...>

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3324 The SEV-ES stacks currently share a page with the reset code and data. Separate the SEV-ES stacks from the reset vector code and data to

Hi Etienne, Thank you for this patch. I am getting build errors in VariableMmDependency.inf when building for ARM. Not sure if you are getting these or it is my development environment (I am

Hi Etienne, Thank you for this patch. A space should not be there between a unary operator add its

Hi Etienne, Thank you for this patch. Please find my comments below marked [SAMI]. Regards, Sami Mujawar [SAMI] if condition should evaluate a Boolean value. See

Hi Etienne, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Etienn, This patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar