Hi Nhi, Apologies, this dragged out a bit longer than I intended. Some high-level comments before I get into the contents: In order to build this against current upstream, I needed to go back to

According to the edk2 coding style, this should be written as: return (BOOLEAN)(Msr.Bits.SevSnpBit != 0); primarily because "Msr.Bits.SevSnpBit" does not have type BOOLEAN, so it should not be

Hi Vu, For this set: Reviewed-by: Leif Lindholm <leif@...> Is there any value to you in me pushing this before the edk2-platforms set goes in? If not, I'll hold back and push them both at

Hi Ray, This commit breaks many of the ARM platforms. I end up seeing GenFw: Elf64Convert.c:719: ScanSections64: Assertion `FALSE' failed. when generating certain ACPI tables. Note: this applies

Hmmm... indeed, but that discussion happened off-list, namely under the original posting of this v3 RFC set that did not reach the list. And now I was working with my list folder. Right, this branch

Hi Laszlo, The main issue is I typed wrong branch name in the cover letter. The branch name should be "sev-snp-rfc-3" and not "sev-snp-rfc-2". I apologies for it :(. Ray asked the branch name and I

OK. Yes, that's it. All these PCDs come in pairs -- base and size. (IIRC.) If there's no architectural requirement to keep these two kinds of info in different pages (such as different page

Totally agree with this. Confidential Computing is a very niche use case, and there is no justification for exploding the complexity of the standard OVMF build. If, several years from now, it ever

Thank you Laszlo for reviewing this. James explained the difference from Secure Boot setup and our choice of hash validation of kernel+initrd+cmdline. [Skipping...] Brijesh's approach mandates

thank you Laszlo. Your feedback is received. I am waiting for comment from other people. thank you! Yao, Jiewen

I mean option (B). Create a completely separate DSC+FDF for Intel TDX. In my mind, there are two (very high level) stages for developing the "Confidential Computing with TDX" feature in edk2. Stage

From SysTableInfo Hob, get ACPI table address, and creat gPldAcpiTableGuid = Hob to store it. Remove diretly adding ACPI table to ConfigurationTable. Dxe ACPI driver will parse it and install ACPI

V1: If HOB contains APCI table information, entry point of AcpiTableDxe.inf should parse the APCI table from HOB, and install these tables. We assume the whole ACPI table (starting with

Cc: Liming Gao <gaoliming@...> Cc: Jian J Wang <jian.j.wang@...> Cc: Hao A Wu <hao.a.wu@...> Signed-off-by: Zhiguang Liu <zhiguang.liu@...> ---

From SysTableInfo Hob, get Smbios table address, and creat gPldSmbiosTableG= uid Hob to store it. Remove diretly adding smbios table to ConfigurationTable. Dxe module SmbiosDxe will parse it and

V1: The default EfiSmbiosProtocol operates on an empty SMBIOS table. The SMBIOS tables are provided by the bootloader on UefiPayloadPkg. Scan for existing tables in SmbiosDxe and load them if they

Cc: Liming Gao <gaoliming@...> Cc: Jian J Wang <jian.j.wang@...> Cc: Hao A Wu <hao.a.wu@...> Signed-off-by: Zhiguang Liu <zhiguang.liu@...> ---

UefiPayload parse gPldPciRootBridgeInfoGuid Guid Hob to retrieve PCI root b= ridges information. gPldPciRootBridgeInfoGuid Guid Hob should be created by Bootlo= ader. Cc: Maurice Ma

Cc: Liming Gao <gaoliming@...> Cc: Jian J Wang <jian.j.wang@...> Cc: Hao A Wu <hao.a.wu@...> Signed-off-by: Zhiguang Liu <zhiguang.liu@...> ---

V1: This patch set is based on Universal Payload on https://universalpayload.github.io/documentation/payload-interfaces/index.html This patch set introduce one general header, three different hob