Using Ref: in the signoff section of the patch is perfectly fine with me. I'll go over this series on Thursday and merge it if everything looks ok. Thanks all for the review.

I don’t think we would need to change PEI. 1s you need to figure out which UsbIo service you would need to code the USB Audio driver against. MdePkg/Include/Protocol/UsbIo.h:485:

I believe the convention is that this line be in the individual patch commit messages just like this (i.e. with the BZ: tag and the first line), not as a Ref: tag at the end of the commit

Reviewed-by: Tom Lendacky <thomas.lendacky@...>

A comment about the use of INT32 in the for loop to protect against a large entry length value would be useful. I don't think it's worth another version, but if you have to make any updates it would

PEI use of USB is usually limited to access to recovery images from media devices. I would recommend focusing on UEFI components, Mike

In my opinion MdePkg is where this should be as it is meant to be used by multiple software entities (linux kernel, grub, edk2, coreboot w/ uefi binding) and probably should be documented in some spec

Reviewed-by: Brijesh Singh <brijesh.singh@...> thanks

Reviewed-by: Brijesh Singh <brijesh.singh@...> thanks

Reviewed-by: Tom Lendacky <thomas.lendacky@...>

Reviewed-by: Tom Lendacky <thomas.lendacky@...>

Reviewed-by: Tom Lendacky <thomas.lendacky@...>

Reviewed-by: Tom Lendacky <thomas.lendacky@...>

Hello all, A few days ago Leif determined that the USB DXE does not implement isochronous transfers. This will make USB Audio quite impossible as the audio data endpoint requires isochronous

I’ve got a branch on a private repo (BZ3500-gdb @ https://github.com/ajfish/edk2.git) that has gdb and lldb scripts that can attach to QEMU and symbolicate EFI. These scripts also provide other

Ard: Thanks! I have added this feature into https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning. Thanks Liming

Just saw two minor issues with the patch subject and messages. Maybe Ard can directly help fix them while pushing the change. 😊 - For the subject, we should change "HIDs" to either "CIDs" or

Round up the size of the SEV launch secret area to a whole page, as required by BuildMemoryAllocationHob. This will allow the secret area defined in the MEMFD to take less than a whole 4KB page. Cc:

Newer kernels support efistub and therefore don't need all the legacy stuff in X86QemuLoadImageLib, which are harder to secure. Specifically the verification of kernel/initrd/cmdline blobs will be

From: James Bottomley <jejb@...> Support QEMU's -kernel option. Create a QemuKernel.c for PlatformBootManagerLibGrub which is an exact copy of the file PlatformBootManagerLib/QemuKernel.c