Ah, I see why that's a problem now. The path is constructed in BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py:             # make GCC5_ARM_PREFIX to align with

Create a read-only openSSL BIO wrapper for the existing input buffer passed to Pkcs7Verify() instead of copying the buffer into an empty writable BIO which causes memory allocations within

(+ Gerd) <dbautista@...> wrote:

FYI this is actually a supported and recommended way of doing things: any user can send PRs and the CI will run on them. Only maintainers can do so and set the 'pull' label, in which case the PR will

Yes, please. Feel free to submit your own PR. As long as you did not label - PUSH, this CI just shows the test result. It will NOT merge automatically. Thank you Yao Jiewen

Now with everything in place for virtio 1.0 devices we can let VirtioMmioInit() return SUCCESS. Signed-off-by: Gerd Hoffmann <kraxel@...> Reviewed-by: Philippe Mathieu-Daude

Use QueueNumMax as QueueNum default for drivers which do not explicitly call VIRTIO_DEVICE_PROTOCOL->SetQueueSize(). Signed-off-by: Gerd Hoffmann <kraxel@...> Reviewed-by: Philippe

virtio 1.0 has 64 feature bits instead of 32. Signed-off-by: Gerd Hoffmann <kraxel@...> Reviewed-by: Philippe Mathieu-Daude <philmd@...> --- .../VirtioMmioDeviceFunctions.c

Nothing to do here for virtio 1.0 devices. Signed-off-by: Gerd Hoffmann <kraxel@...> Reviewed-by: Philippe Mathieu-Daude <philmd@...> ---

Virtio 1.0 allows a more flexible virtio ring layout, so we have to set addresses for descriptors avail flags and use flags separately. We continue to use a ring layout compatible with virtio 0.9.5

This little series adds virtio 1.0 support for the virtio-mmio transport. For the mmio transport the difference between 0.9.5 and 1.0 is rather small (when compared to the pci transport), it is just

Add #defines for the Version field. Read and store the version, log the version found as info message. Continue to return UNSUPPORTED for now, we need some more patches to complete virtio 1.0

Add defines for the config space offsets for virtio 1.0 mmio transport. Signed-off-by: Gerd Hoffmann <kraxel@...> Reviewed-by: Philippe Mathieu-Daude <philmd@...> ---

Hi This patch failed in CI - https://github.com/tianocore/edk2/pull/1922 Please take a look and submit patch again.

Is there some way to run the CI before posting the patches? I could probably create a dummy pull request for that and delete it when the CI is done. That'll probably make gitlab send out a bunch

You are changing the compiler from arm-linux-gnueabihf-gcc to arm-none-linux-gnueabihf-gcc (and likewise for aarch64) so I am not surprised you are hitting problems.

Thanks for this series, and thanks all for the reviews. Gary, could you please resend it with the following changes so it applies cleanly: - Move the bugzilla link into the signoff block, preceded by

Patch is pushed - 80e67af9afcac3b860384cdb1f4613f7240e1630.. b9af5037b270c4767b275fd5d23b942c422e742f

Merged as #1920 Thanks all,

I am sorry, I mess up https://github.com/tianocore/edk2/pull/1917, please ignore that. This pull request is re-created at https://github.com/tianocore/edk2/pull/1918. Please take a look at 1918.