Reviewed-by: Dandan Bi <dandan.bi@...> Thanks, Dandan

1. Or if you add a "Index = 0" to reset Index for each Socket, that also work. 2. My code is wrong. The for-loop above is not needed. I think you can simply make sure resetting "Index" to 0 for each

Yes agreed, making this more consistent would be a good improvement and one that I would support. There is always the perennial issue of finding the time to make those improvements and balancing that

Pushed: https://github.com/tianocore/edk2-platforms/commit/b401dfd

Hi Nate, That makes sense. I had been concerned that UiApp might be used in some places, but I didn't expect significant disparity between the boards (and I didn't check all of them, my

Hi Benjamin, In principle this is a good idea, unfortunately some platforms have been coded to do stuff like

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

Pushed: https://github.com/tianocore/edk2-platforms/commit/784f773

HI Caden, You accidentally added a bunch of trailing white space on line 371, but that should be fixable during the check-in process. Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

Hi Benjamin, Sounds good. I have pushed your patch. Thanks, Nate

Pushed: https://github.com/tianocore/edk2-platforms/commit/fe47032

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

I've created a ticket in Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3594. -- Rebecca Cran

Mike, That reminds me that my patch to fix this for Xcode is still in limbo. Thanks, Andrew Fish

Hey Ray, As I said, the updated proposal no longer has any impact on backwards-compatibility. For the new file format, there is still a big, big amount of time to reconsider later. Samer said the

Marvin, If we can keep the secure parsing code inside the PeCoff library, all the backward combability issues because of removing the HII section support don't exist. The PeCoff library might be very

Hey Ray, Yes it is, but the most secure parsing code is that which doesn't exist. I'm confident in the one I wrote for the new PE/COFF library, but if variables suit the need, I really would like to

This might be the key reason? Is it theoretically possible to write a secure parsing code? Thanks, Ray

Though CopyMem() copies nothing when Length equals to 0, I agree this patch to totally skip the CopyMem() call. Reviewed-by: Ray Ni <ray.ni@...>

1. I think you need to change above code to as below? UINTN IndexInSocket[MAX_SOCKET]; ZeroMem (IndexInSocket, sizeof (IndexInSocket)); for (Socket = 0; Socket < MAX_SOCKET; Socket++) { for