Pushed via: PR - https://github.com/tianocore/edk2/pull/1947 Commit - https://github.com/tianocore/edk2/commit/c5e805ffe1098601e84fd501d5fa1d45e9d96a62 Best Regards, Hao Wu

HI Min/Gerd I think we have multiple ways to enable 5 level paging. 1) We do not change to 5 level in initial paging in reset vector. We can switch from 4 level to 5 level later when permanent memory

Reminder: TianoCore Community Meeting - APAC/NAMO When: 09/02/2021 7:30pm to 8:30pm (UTC-07:00) America/Los

Reminder: TianoCore Community Meeting - APAC/NAMO When: 09/02/2021 7:30pm to 8:30pm (UTC-07:00) America/Los

Series Reviewed-by: Michael D Kinney <michael.d.kinney@...>

Marvin: Yes. We need to keep CONSTRUCTOR and LIBRARY_CLASS in PiSmmCoreMemoryAllocationLib.inf that is required to make sure SmmCore build pass. Otherwise, we have to provide another PiSmmCore

Hi Comment on 2/3. I am not sure if the a new function AuthenticateFmpImageWithParallelhash() is absolutely necessary. Why you do the parallel hash before authentication and transfer the result

Hi It is good idea to have a protocol to abstract TDX and SEV. I think we need clearly document what service can be used in EFI_ACCEPT_MEMORY. For example, can we use memory allocation service, GCD

Mike, Stupid question but the BaseCryptLib seems to really be DxeCryptLib[1]? So are you worried about adding the dependency to this DXE Lib? It depends on UefiRuntimeServicesTableLib. Looks like

I should clarify the statement, the format itself does not contain anything  SNP specific. However, the CPUID page format is documented in the SNP specific spec. Are you thinking about using it for

Thanks, that makes sense. I haven't reviewed the entire patch, so I've given an Acked-by instead. -- Rebecca Cran

Acked-by: Rebecca Cran <rebecca@...> -- Rebecca Cran

Hi Rebecca, Responses below. Some of the items you are observing are due to following the exact same pattern as the Python 2.x ports. There are many things that can get cleaned up in the Python 3.x

It looks like a label starting with @ is not legal nasm syntax? "Valid characters in labels are letters, numbers, _, $, #, @, ~, ., and ?. The only characters which may be used as the first character

This looks like it's formatted using Markdown, so should it be Py368ReadMe.md? The xcopy commands should probably have error checking after them. -- Rebecca Cran

A branch of edk2-libc with both commits is available here for evaluation. https://github.com/jpshivakavi/edk2-libc/commits/py36_port_for_uefi Mike

Versions of the DXE module perform nearly identical functions, and are therefore mutually exclusive. Including both modules results in at least a duplicate HII package and possibly an "already

The DXE and SMM versions of AcpiDebug perform the same functions, and are therefore mutually exclusive. Including both modules results in a duplicate ACPI table, resulting in the feature not working

From: Jayaprakash Nevara <n.jayaprakash@...> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3588 This commit contains several changes made to the base Python 3.6.8 source code to compile

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3588 This patch series contains the modifications required to support Python 3.6.8 in the UEFI Shell. Currently supports building Py3.6.8 for