|
Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal
+ Shaker
Get Outlook for iOS
+ Shaker
Get Outlook for iOS
|
By
Ashish Singhal
·
#81833
·
|
|
Re: [PATCH V2 0/3] Introduce TdProtocol into EDK2
Hi Min,
Thank you for this patch.
I think it would greatly help if the EFI_TD_PROTOCOL is changed to something more architecture neutral. As I understand, this patch series is removing the
Hi Min,
Thank you for this patch.
I think it would greatly help if the EFI_TD_PROTOCOL is changed to something more architecture neutral. As I understand, this patch series is removing the
|
By
Sami Mujawar
·
#81832
·
|
|
Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal
Marc,
In the document ARM062-1010708621-30 (AArch64 Programmer's Guides Generic Timer), towards the end of section 3.4 it says: "When writing an interrupt handler for the timers, it is important that
Marc,
In the document ARM062-1010708621-30 (AArch64 Programmer's Guides Generic Timer), towards the end of section 3.4 it says: "When writing an interrupt handler for the timers, it is important that
|
By
Ashish Singhal
·
#81831
·
|
|
Re: [PATCH V9 2/4] OvmfPkg: Clear WORK_AREA_GUEST_TYPE in Main.asm
A regular SEV guest can be built in the hybrid IA32 and X64 configuration, so this will break existing SEV firmwares built in that manner. Only SEV-ES and SEV-SNP require the full X64
A regular SEV guest can be built in the hybrid IA32 and X64 configuration, so this will break existing SEV firmwares built in that manner. Only SEV-ES and SEV-SNP require the full X64
|
By
Lendacky, Thomas
·
#81830
·
|
|
Re: [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe
Hmm.
We already have a local apic timer implementation (XenTimerDxe). Works
fine with kvm, microvm already uses that. See commit 76602f45dcd9
("OvmfPkg/Microvm: use XenTimerDxe (lapic
Hmm.
We already have a local apic timer implementation (XenTimerDxe). Works
fine with kvm, microvm already uses that. See commit 76602f45dcd9
("OvmfPkg/Microvm: use XenTimerDxe (lapic
|
By
Gerd Hoffmann
·
#81828
·
|
|
Re: [PATCH V2 27/28] OvmfPkg: Update IoMmuDxe to support TDX
Hi,
Yet another place where you should be able to just use the
ConfidentialComputing PCD.
take care,
Gerd
Hi,
Yet another place where you should be able to just use the
ConfidentialComputing PCD.
take care,
Gerd
|
By
Gerd Hoffmann
·
#81827
·
|
|
Re: [PATCH V2 25/28] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library
Hmm, doesn't have tianocore a lib for such allocation pools?
Seems to be never used.
Why this is needed?
No need to add that, there is OvmfPkg/Include/IndustryStandard/PageTable.h
take care,
Hmm, doesn't have tianocore a lib for such allocation pools?
Seems to be never used.
Why this is needed?
No need to add that, there is OvmfPkg/Include/IndustryStandard/PageTable.h
take care,
|
By
Gerd Hoffmann
·
#81826
·
|
|
Re: [PATCH V2 24/28] OvmfPkg: Add TdxDxe driver
Hi,
+ sizeof(MadtMpWk)
[ ... ]
You are not updating the MADT. You create a new one from scratch. Not
a good plan. I think you should simply get the installed table, copy it
to a larger buffer
Hi,
+ sizeof(MadtMpWk)
[ ... ]
You are not updating the MADT. You create a new one from scratch. Not
a good plan. I think you should simply get the installed table, copy it
to a larger buffer
|
By
Gerd Hoffmann
·
#81825
·
|
|
Re: [PATCH V2 14/28] OvmfPkg: Update SecEntry.nasm to support Tdx
Hi,
Hmm, I'm wondering whenever it is useful to have this in the first place
with the longer-term plan to implement lazy on-demand acceptance.
take care,
Gerd
Hi,
Hmm, I'm wondering whenever it is useful to have this in the first place
with the longer-term plan to implement lazy on-demand acceptance.
take care,
Gerd
|
By
Gerd Hoffmann
·
#81824
·
|
|
Re: [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib
Hi,
Again: this should use PCD.
take care,
Gerd
Hi,
Again: this should use PCD.
take care,
Gerd
|
By
Gerd Hoffmann
·
#81823
·
|
|
Re: [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception
#ve
Hi,
Can please you explain in more detail why this is the case?
thanks,
Gerd
Hi,
Can please you explain in more detail why this is the case?
thanks,
Gerd
|
By
Gerd Hoffmann
·
#81822
·
|
|
Re: [edk2-platforms][PATCH 00/15] Changes to compliant with BZ:#3665
No issues with these, as long as they're merged (very shortly) after
the edk2 set.
Although please fix the typo in all of the commit messages
complaint ->
compliant
(But please don't send a v4 just
No issues with these, as long as they're merged (very shortly) after
the edk2 set.
Although please fix the typo in all of the commit messages
complaint ->
compliant
(But please don't send a v4 just
|
By
Leif Lindholm
·
#81821
·
|
|
Re: [PATCH edk2-platforms 1/1] Silicon/Qemu: don't advertise GICC legacy mmio interface in SbsaQamu MADT
Thanks - pushed as 69035742d336.
/
Leif
Thanks - pushed as 69035742d336.
/
Leif
|
By
Leif Lindholm
·
#81820
·
|
|
Re: [PATCH V2 07/28] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib
Hi,
Use ConfidentialComputing PCD ?
I'd suggest to reverse the logic, i.e. have a AccessMsrTdxCall() which
returns true in case (a) tdx is active and (b) the msr is not on the
white list for native
Hi,
Use ConfidentialComputing PCD ?
I'd suggest to reverse the logic, i.e. have a AccessMsrTdxCall() which
returns true in case (a) tdx is active and (b) the msr is not on the
white list for native
|
By
Gerd Hoffmann
·
#81819
·
|
|
Re: [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx
This monster patch needs splitting up. At least into io + mmio + fifo.
Adding the tdx helper functions can be a separate patch too.
Calling CPUID should not be needed, we have a new
This monster patch needs splitting up. At least into io + mmio + fifo.
Adding the tdx helper functions can be a separate patch too.
Calling CPUID should not be needed, we have a new
|
By
Gerd Hoffmann
·
#81818
·
|
|
Re: [Patch V4 1/1] BaseTools: Change RealPath to AbsPath
Reviewed-by: Bob Feng <bob.c.feng@...>
Reviewed-by: Bob Feng <bob.c.feng@...>
|
By
Bob Feng
·
#81817
·
|
|
[PATCH] IntelSiliconPkg/FirmwareInterfaceTable: Define FIT 4 record
By
Holland, Michael <michael.holland@...>
·
#81816
·
|
|
[PATCH 2/2] Allow wildcards in hostname
This PR is cherry-picked from
https://github.com/microsoft/mu_basecore/commit/d0c7733400c35722499eedcd4279042a9bcb0eb4
BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3679
Signed-off-by:
This PR is cherry-picked from
https://github.com/microsoft/mu_basecore/commit/d0c7733400c35722499eedcd4279042a9bcb0eb4
BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3679
Signed-off-by:
|
By
Vineel Kovvuri <vineel.kovvuri@...>
·
#81815
·
|
|
[PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms
This commit is a cherry pick of project mu's commit
https://github.com/microsoft/mu_tiano_plus/commit/1f3b135ddc821718a78c352316197889c5d3e0c2
Reconfigure OpensslLib to add elliptic curve chipher
This commit is a cherry pick of project mu's commit
https://github.com/microsoft/mu_tiano_plus/commit/1f3b135ddc821718a78c352316197889c5d3e0c2
Reconfigure OpensslLib to add elliptic curve chipher
|
By
Vineel Kovvuri <vineel.kovvuri@...>
·
#81814
·
|
|
Re: [PATCH] MdeModulePkg/Core/Dxe: Acquire a lock when iterating gHandleList
Hi Dandan,
Thanks for the comment.
Patch v2 is just sent with the update.
Please help to review.
Thank you,
Ma Hua
Hi Dandan,
Thanks for the comment.
Patch v2 is just sent with the update.
Please help to review.
Thank you,
Ma Hua
|
By
Ma, Hua
·
#81813
·
|