Heh, sorry about that :) How about using PCDs, but at a higher level in the edk2 network stack (regardless of the SNP driver(s) used)? Not that I'm a huge fan of them, but we already have

i don't maintain any of the packages in question, but the changes look appropriate to me, so Reviewed-by: Ard Biesheuvel <ardb@...>

The patches look fine to me, but what does 'Pipeline' mean?

Hi Ray/Jian/Liming Would you be able to review this patch please? Many thanks Sean

Welcome back old friend! I have to confess that I was the one who suggested this approach to Yuan internally, but mainly to get the discussion going, as I was anticipating some pushback, just not

Fix using RmrNodeCount uninitliased by initliasing it to zero. Also, add an additional check for ACPI version. This fixes a crash running on kvmtool. Signed-off-by: Edward Pickup

Merged as 444260d45ec2a84e8f8c192b3539a3cd5591d009

Reviewed-by: Sean Rhodes <sean@...>

Merged as 79aab22fcaecf0bd70099e97c92fe3e816e450ce

Reviewed-by: Sean Rhodes <sean@...>

Well I've not been reviewing upstream edk2 patches for a while, but the virtio-net driver is still very close to my heart, so this patch kind of hits a nerve. I think I disagree with the idea and the

1. Old code contains a picture that describes the buffer layout. It seems the picture disappears in new code. 2. When TSS is enabled, there is one descriptor in GDT that points to the TSS. But TSS is

For the series: Reviewed-by: Michael Kubacki <michael.kubacki@...> The patch formatting seems a little strange: 1. The patches don't have "Cc" lines. 2. What is this GUID message at the

Generally, convention for "Pkg-Module" is "Pkg/Module: " not "Pkg: Module: ". Kind of a nit, but using : as separator will make parsing tools harder to write. Convention for comments is "no newline

Pushed as d09dafd0b9..a6b7458972 (fixed author format and trailing whitespace)

Reviewed-by: Isaac Oram <isaac.w.oram@...> Please run \edk2\BaseTools\Scripts\PatchCheck.py on commits to identify whitespace and other simple issues. There are also typically editor settings

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@...>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3794 This change introduces a new error code definitions under Host Software class. The new error code definition will cover system reboot

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3794 This change includes specification update markdown file that describes the proposed PI Specification v1.7 Errata A in detail and

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794 This patch series is a rebase of previous submission: https://edk2.groups.io/g/devel/message/86374 This change is sent for review to reflect