Mike: I have two comments. 1) Could you also provide the patch to use this utility in edk2 platform, such as quark platform? 2) Suggest to support append mode as one option. If so, we can use this

Hi Jiewen, Updating "all the code that uses the old API to use the new API" is not always possible. We can certainly update all the EDKII packages; however, it is trickier with the non-open source

Thank you for asking / offering, I did stash the full trace :), I just didn't want to foist it upon you without you offering first

Hi Brandon Huber, Thanks for reporting this, I will investigate it and fix it. Best Regards, Zhu Yonghong

It's not BSP that enters SMM, it's the currently executing processor. So this means that CPU #3 has written to B2. Thanks, Paolo

Any trace I can look at? What about case 14, with PcdCpuSmmStaticPageTable=TRUE? Paolo

With your v2 series applied, Jeff's patches replace the crash / emulation failure symptoms during S3 resume with less intrusive symptoms, namely that some of the APs cannot be brought up by the

Right, when you run a guest on TCG (QEMU's emulator) vs. on KVM (the virtualizer / accelerator in the host Linux kernel), you get very-very different timing behavior and interleaving of actions. For

Hi Laszlo Thanks to test for us. Are you saying Jeff's patch introduces a new issue? Or is this a previous issue but just not fixed by Jeff's patch? Thank you Yao Jiewen Sent: Thursday, November

Thanks to report case 3 issue on bugzillar. Let's focus on Case 8. It seems another random failure issue. I did more test. 1) I tested some other our internal real platform for UEFI32 OS boot.

I applied this on top of Jiewen's v2, for testing. This series (with my addition for patch #1) doesn't fix the boot failure in case 8. (See "case 8" in

Reviewed-by: Paolo Bonzini <pbonzini@...> It would be slightly more robust to do the "InterlockedDecrement (&mNumberToFinish);" while in safe state, but the race window is really really

Thank you. Since you're going to send a v2: while applying this patch for testing, git-am warned me that there were 7 new lines with trailing whitespace. Can you please trim those? Thanks Laszlo

I have a few comments: (1) I propose to split this patch into three patches, with the following subjects: MdeModulePkg/Ip4Dxe: Catch invalid subnet early in manual setting MdeModulePkg/Ip4Dxe: Fix

V2: Correct the unaligned parameter name in BaseCryptLib.h. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi <dandan.bi@...> ---

I agree with your proposal. Great suggestion. I will create v2 later.

Can we please append, to both commit messages: Analyzed-by: Paolo Bonzini <pbonzini@...> I think we should give credit to Paolo for his work in this thread. I'll report back with test

Before I test this, I have one question / suggestion: Here I suggest to append the following assignment: TopOfStack &= ~(UINT32) (CPU_STACK_ALIGNMENT - 1); This will clear the least significant

This patch is used to add the wrong/invalid subnet check. Meanwhile, correct the the return status. Cc: Laszlo Ersek <lersek@...> Cc: Ye Ting <ting.ye@...> Cc: Fu Siyuan

Yes! I will correct them and send a V2 patch. Thanks, Dandan