Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@...>

Laszlo, I agree. I will do a different patch to fix the function names in comments. Mike

Thanks for trying it. Unfortunately, I can't find the time to dig into this now. And, I think it's likely related to ShellPkg anyway. Can you please help by filing a BZ for ShellPkg, and/or bisecting

Laszlo, Yes. I can split. I will send V2 with your feedback. For the following line, the cast to (VOID *) before cast to (UINTN) was required to pass VS build. Since mNumberToFinish is a volatile

Ah! Thank you. That's a completely valid set of updates then; but I think it should be in a different patch. Cheers Laszlo

Thanks! I was eager and already committed it with Jiewen's R-b. Cheers! Laszlo

I have two requests before you commit the patch: (1) please prefix the subject line with "OvmfPkg: ", (2) please commit this patch only after you commit the patch "UefiCpuPkg/PiSmmCpu: Check

Tested-by: Laszlo Ersek <lersek@...> Thanks! Laszlo

Laszlo, Thanks for the feedback. I will update and send V2. I did not change the names of any functions. The comment blocks had names that did not match the name of the function, so I was only

Unfortunately the patch doesn't fix the problem I'm seeing. -- Bruce

Thank you for fixing it. Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@...>

Thanks! Commit 2048ab4b3ec9. Laszlo

Both patches are submitted. I will discuss with Jeff tomorrow to see how we can improve the debug message. -- "Stack Overflow" for "XD page fault" is definitely a misreport. :( Thank you Yao

Tested boot with below configuration: IA32 IA32X64 X64 Tested boot with XD enabled/disabled. Requested-by: Laszlo Ersek <lersek@...> Cc: Jordan Justen <jordan.l.justen@...> Cc: Laszlo

When XD is not supported, the BIT63 is reserved. We should not set BIT63 in the page table. Test OVMF IA32/IA32X64 with XD enabled/disabled. Analyzed-by: Laszlo Ersek <lersek@...> Cc: Jeff

Yes, Laszlo. You are right. Thanks to catch this. I will 1) Submit a new patch to fix XD issue. 2) Submit V2 patch for OVMF. Sent: Thursday, November 17, 2016 8:18 PM To: Yao, Jiewen

Hi star I am sorry that I am confused on this patch. 1) Below update is not related to the GIT message. I think there is nothing wrong with previous code. May I know if you observe something? 2) I

Reviewed-by: jiewen.yao@...

Hi Star 1) I am a little confused on below description. + @param[in,out] Buffer Buffer to hold TPML_DIGEST_VALUES. I think the buffer is the *TPML_DIGEST_VALUES compact binary buffer*,

Thank you for submitting the patch! (1) Please wrap the new comments in the DSC files at 79 characters, like this: # # Force PE/COFF sections to be aligned at 4KB boundaries to support page level #