Hi Bob, You are suggesting to knowingly break builds between one stable tag and another on a technicality, for one of the most common (and up to date) build operating systems. The purpose of the

Reviewed-by: Ray Ni <ray.ni@...>

Hi, I mean this one. take care, Gerd

As I mentioned CcProbe is used in BaseIoLib which is a basic library and it is used in SEC/PEI/DXE phases. Global variable cannot be used in SEC phase. Unless BaseIoLib is split into 2 instance, one

Hi, When using RT_DATA is out of question there is no way around two instances I think. I don't see the point in reinventing the wheel though. We know what the guest type is, why determine it

Ping ... Any comments? Thanks Jianyong

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

One of the situation of CcProbe used is in BaseIoLib. https://github.com/tianocore/edk2/blob/master/MdePkg/Library/BaseIoLibIntrinsic/IoLibInternalTdx.c#L35-L40 BaseIoLib is a basic library and it

From: Michael Kubacki <michael.kubacki@...> The DEBUG macro updated in this patch previously contained 11 print specifiers in the debug string but passeed 13 arguments. This change attempts

From: Michael Kubacki <michael.kubacki@...> Removes Status argument that is not needed from DEBUG macros. Cc: Maciej Rabeda <maciej.rabeda@...> Cc: Jiaxin Wu

From: Michael Kubacki <michael.kubacki@...> Cc: Sami Mujawar <Sami.Mujawar@...> Cc: Alexei Fedorov <Alexei.Fedorov@...> Signed-off-by: Michael Kubacki

From: Michael Kubacki <michael.kubacki@...> The debug macro modified in this change was missing a print specifier for a debug message argument given. Cc: Jian J Wang

From: Michael Kubacki <michael.kubacki@...> The debug macro argument in this change is removed since it does have a corresponding print specifier in the debug message string. Cc: Abner

From: Michael Kubacki <michael.kubacki@...> Updates debug macros in the package that have an imbalanced number of print specifiers to arguments. These changes try to preserve what was

From: Michael Kubacki <michael.kubacki@...> This debug macro should take one argument based on the number of print specifiers defined. However, two arguments are given. It looks like the

From: Michael Kubacki <michael.kubacki@...> These debug messages are repeated in both NorFlashBlockIoReadBlocks() and NorFlashBlockIoWriteBlocks():

From: Michael Kubacki <michael.kubacki@...> After noticing a few occurrences of DEBUG macros with a mismatched number of arguments, I wrote a script to automatically detect this. This

In these changes: updated with the address the address The text "A pointer..." became unaligned with the block. Likely due to the extra character added when changing "in" to "out". Can you please

Reviewed-by: James Lu <james.lu@...> Thanks, James

The API of InitializeSeparateExceptionStacks is just changed before, and makes the struct CPU_EXCEPTION_INIT_DATA an internal definition. Furthermore, we can even remove the struct to make core