devel@edk2.groups.io

Re: [PATCH v2 19/21] DynamicTablesPkg: AML code generation to add an _LPI state

Hi Pierre, This patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential

By Sami Mujawar · #81688 ·

Re: [PATCH v2 18/21] DynamicTablesPkg: AML code generation for a _LPI object

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and

By Sami Mujawar · #81687 ·

Re: [PATCH edk2-platforms 1/1] Silicon/Qemu: don't advertise GICC legacy mmio interface in SbsaQamu MADT

Acked-by: Ard Biesheuvel <ardb@...>

By Ard Biesheuvel · #81686 ·

Re: [PATCH v2 17/21] DynamicTablesPkg: AML code generation for a Method returning a NS

Hi Pierre, I think this v2 patch has introduced an issue (which was not there in v1), see my comment marked inline as [SAMI]. With that fixed, Reviewed-by: Sami Mujawar

By Sami Mujawar · #81685 ·

Re: [PATCH v2 15/21] DynamicTablesPkg: AML code generation for a Method

Hi Pierre, Thank you for adding documentation for the steps for generating a Method. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this

By Sami Mujawar · #81684 ·

Re: [PATCH v2 14/21] DynamicTablesPkg: AML code generation for a ResourceTemplate

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and

By Sami Mujawar · #81683 ·

Re: [PATCH v2 11/21] DynamicTablesPkg: AML Code generation for Resource data EndTag

Hi Pierre, This patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential

By Sami Mujawar · #81682 ·

Re: [PATCH v2 12/21] DynamicTablesPkg: AML code generation for a Package

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and

By Sami Mujawar · #81681 ·

Re: [PATCH v2 08/21] DynamicTablesPkg: Update error handling for node creation

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and

By Sami Mujawar · #81680 ·

Re: [PATCH v2 07/21] DynamicTablesPkg: Clear pointer in node creation fcts

Hi Pierre, There is a minor typo in the commit message that I will fix when pushing the patch. Otherwise, this patch looks good to me. Reviewed-by: Sami Mujawar

By Sami Mujawar · #81679 ·

Re: [PATCH v2 05/21] DynamicTablesPkg: Add AmlSetRdListCheckSum()

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and

By Sami Mujawar · #81678 ·

Re: [PATCH v2 06/21] DynamicTablesPkg: Set EndTag's Checksum if RdList is modified

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and

By Sami Mujawar · #81677 ·

Re: [PATCH v2 04/21] DynamicTablesPkg: Add AmlRdSetEndTagChecksum()

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and

By Sami Mujawar · #81676 ·

Re: [PATCH v2 02/21] DynamicTablesPkg: Add missing parameter check

Hi Pierre, This patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential

By Sami Mujawar · #81675 ·

Re: [PATCH v2 03/21] DynamicTablesPkg: Add AddSsdtAcpiHeader()

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and

By Sami Mujawar · #81674 ·

Re: [PATCH v2 01/21] DynamicTablesPkg: Remove unnecessary includes

Hi Pierre, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any

By Sami Mujawar · #81673 ·

Re: [edk2-platforms: PATCH v3 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

Reviewed-by: Kathappan Esakkithevar <kathappan.esakkithevar@...>

By Kathappan Esakkithevar · #81672 ·

Re: [edk2-platforms: PATCH v3 2/9] CometlakeOpenBoardPkg: Use same variable name for FspNvsHob.

Reviewed-by: Kathappan Esakkithevar <kathappan.esakkithevar@...>

By Kathappan Esakkithevar · #81671 ·

Re: [PATCH v2 16/21] DynamicTablesPkg: AML code generation to Return a NameString

Hi Pierre, Thanks you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and

By Sami Mujawar · #81670 ·

[PATCH edk2-platforms 1/1] Silicon/Qemu: don't advertise GICC legacy mmio interface in SbsaQamu MADT

The MADT GICC structure contains the field PhysicalBaseAddress, which is needed for a GICv1/v2 implementation, or to indicate legacy compatibility in modern GICs. Linux commit 9739f6ef053f1, included

By Leif Lindholm · #81669 ·